fix: docsgpt up removes Caddy when leaving a domain; clearer Docker permission error

Caddy sits behind the https profile, so once COMPOSE_PROFILES no longer
enables it, `up --remove-orphans` left it running on ports 80 and 443 and
`down -v` left its volumes. `up` now removes Caddy when an install moves
off its domain, and down and uninstall name the profile explicitly.

A user outside the docker group was told Docker is not running; the error
now says how to get access to the socket.

docsgpt/deploy/commands.py

@@ -23,6 +23,9 @@ PROJECT = "docsgpt"
 DATABASE_VOLUME = f"{PROJECT}_postgres_data"
 _MOVING_TAGS = ("latest", "develop")
 _KEY = re.compile(r"^[A-Za-z_][A-Za-z0-9_]*$")
+# Commands that stop or remove services name every profile, so Caddy goes too
+# even when COMPOSE_PROFILES no longer enables it.
+_EVERY_PROFILE = ("--profile", "https")
 
 EXPOSURE_CHOICES = [
     ("local", "Only this computer"),
@@ -208,6 +211,9 @@ def up(args, context: Optional[Context] = None) -> int:
     envfile.update(env_path, updates)
     env = envfile.read(env_path)
 
+    if stack.exposure(existing) == "domain" and stack.exposure(env) != "domain":
+        # With the https profile off, `up --remove-orphans` would leave Caddy running on ports 80 and 443.
+        context.docker.compose(directory, *_EVERY_PROFILE, "rm", "--stop", "--force", "caddy", check=False)
     up_args = ["up", "-d", "--remove-orphans"]
     if image_tag in _MOVING_TAGS:
         up_args += ["--pull", "always"]
@@ -252,7 +258,7 @@ def down(args, context: Optional[Context] = None) -> int:
     directory = stack.stack_dir(args.dir)
     if _installed(directory) is None:
         return 1
-    context.docker.compose(directory, "down")
+    context.docker.compose(directory, *_EVERY_PROFILE, "down")
     return 0
 
 
@@ -369,7 +375,7 @@ def uninstall(args, context: Optional[Context] = None) -> int:
         if not context.prompter.confirm(f"Remove the DocsGPT {what} in {directory}?", default=False):
             print("Nothing removed.")
             return 1
-    context.docker.compose(directory, "down", "--remove-orphans", *(["-v"] if args.purge else []))
+    context.docker.compose(directory, *_EVERY_PROFILE, "down", "--remove-orphans", *(["-v"] if args.purge else []))
     if args.purge:
         shutil.rmtree(directory)
         print(f"Removed DocsGPT and its data from {directory}.")

docsgpt/deploy/docker.py

@@ -59,7 +59,13 @@ class Docker:
         """Make sure Docker is installed and running and Compose is new enough, starting Docker Desktop on macOS."""
         if not self._which("docker"):
             raise DeployError("Docker is not installed. Get it from https://docs.docker.com/get-docker/ and run this again.")
-        if not self.daemon_running():
+        info = self._run(["docker", "info"], capture=True, check=False)
+        if info.returncode != 0:
+            if "permission denied" in (info.stderr or "").lower():
+                raise DeployError(
+                    "Your user cannot use Docker (permission denied on its socket). Add it to the docker group "
+                    "with `sudo usermod -aG docker $USER`, log out and back in, and run this again."
+                )
             self._start_daemon()
         result = self._run(["docker", "compose", "version", "--short"], capture=True, check=False)
         version = _parse_version(result.stdout) if result.returncode == 0 else None