mirror of
https://github.com/tiennm99/DocsGPT.git
synced 2026-10-15 20:15:30 +00:00
refactor(settings): treat unset spellings of every optional string as None
Review follow-up. The per-group secret validators normalised a hand-picked list of API keys, which left other optional credentials and overrides (OPEN_ROUTER_API_KEY, S3 and Daytona keys, ELASTIC_PASSWORD, the OIDC trio, connector client ids, MICROSOFT_AUTHORITY, MCP_OAUTH_REDIRECT_URI) holding the literal "None" or "" a .env file spells "unset" with, so truthiness checks and fallbacks downstream saw a value. One rule on the group base replaces those lists: every Optional[str] field maps "", "None" and whitespace to None and strips real values. Plain str fields are left alone. The OIDC required-settings check therefore also rejects those spellings. EMBEDDINGS_POOLING is Literal["cls", "mean"] with case-insensitive parsing; its consumer silently ignored anything else. Bounds added where the consumer rejects or misbehaves on the value: SCHEDULE_RUN_OUTPUT_RETENTION_DAYS and MESSAGE_EVENTS_RETENTION_DAYS (the cleanup repositories raise on <= 0), EMBEDDINGS_DELEGATE_TIMEOUT, the remote-device idle/pairing/invocation TTLs and CELERY_VISIBILITY_TIMEOUT (> 0), REMOTE_DEVICE_CMD_QUEUE_TTL_SECONDS (> 605, the documented drain deadline), GRAPHRAG_MAX_CHUNKS_FOR_EXTRACTION (>= 0; negative would slice the pending list from the end). The generated reference now renders generic type arguments (dict[str, int] rather than dict).
This commit is contained in:
1 parent
f882ef49a7
commit
5578039c19
13 files changed
+113
-67
No files matched your search
@@ -58,6 +58,7 @@ class EventsSettings(SettingsGroup):
|
||||
EVENTS_REPLAY_BUDGET_WINDOW_SECONDS: int = Field(default=60, description="Length of the replay budget window.")
|
||||
MESSAGE_EVENTS_RETENTION_DAYS: int = Field(
|
||||
default=14,
|
||||
gt=0,
|
||||
description=(
|
||||
"Retention for the message_events journal, enforced by the cleanup_message_events beat task. Replay "
|
||||
"only needs streams a client could still be tailing."
|
||||
@@ -66,14 +67,15 @@ class EventsSettings(SettingsGroup):
|
||||
|
||||
# Remote Device feature.
|
||||
REMOTE_DEVICE_SESSION_IDLE_SECONDS: int = Field(
|
||||
default=60, description="Seconds without a heartbeat before a remote-device session is considered idle."
|
||||
default=60, gt=0, description="Seconds without a heartbeat before a remote-device session is considered idle."
|
||||
)
|
||||
REMOTE_DEVICE_REQUIRE_SIGNATURE: bool = Field(
|
||||
default=False, description="Require signed commands from remote devices."
|
||||
)
|
||||
REMOTE_DEVICE_PAIRING_TTL_SECONDS: int = Field(default=600, description="Lifetime of a pairing code.")
|
||||
REMOTE_DEVICE_PAIRING_TTL_SECONDS: int = Field(default=600, gt=0, description="Lifetime of a pairing code.")
|
||||
REMOTE_DEVICE_CMD_QUEUE_TTL_SECONDS: int = Field(
|
||||
default=900,
|
||||
gt=605,
|
||||
description=(
|
||||
"Redis TTL of the per-device command queue, routing invocations cross-process so a scheduled run "
|
||||
"reaches the web-held device session. Must exceed the max drain deadline (605s) so a command for a "
|
||||
@@ -81,7 +83,7 @@ class EventsSettings(SettingsGroup):
|
||||
),
|
||||
)
|
||||
REMOTE_DEVICE_INVOCATION_TTL_SECONDS: int = Field(
|
||||
default=900, description="Redis TTL of a pending remote-device invocation."
|
||||
default=900, gt=0, description="Redis TTL of a pending remote-device invocation."
|
||||
)
|
||||
REMOTE_DEVICE_OUTPUT_STREAM_MAXLEN: int = Field(
|
||||
default=10_000, description="Cap on buffered output entries per remote-device invocation stream."
|
||||
|
||||
Reference in new issue
Block a user