From 7e7f34ee9c556e1365cb8795d507c75845621fc6 Mon Sep 17 00:00:00 2001
From: Alex <a@tushynski.me>
Date: Tue, 23 Jun 2026 03:48:21 +0100
Subject: [PATCH] test(graphrag): address code-quality nits in graph tests

Meaningful self-loop degree assertion (was always-true); single import style per module; explicit returns in the live-store helper. (CI code-quality bot.)
---
 tests/graphrag/test_extraction.py | 6 ++++--
 tests/graphrag/test_store.py      | 8 +++++---
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/tests/graphrag/test_extraction.py b/tests/graphrag/test_extraction.py
index e070c090..89c7362c 100644
--- a/tests/graphrag/test_extraction.py
+++ b/tests/graphrag/test_extraction.py
@@ -14,10 +14,11 @@ import uuid
 import pytest
 
 import application.graphrag.extraction as extraction_module
-from application.graphrag.extraction import extract_graph_for_source
 from application.graphrag.store import GraphStore
 from application.storage.db.source_config import SourceConfig
 
+extract_graph_for_source = extraction_module.extract_graph_for_source
+
 TEST_EMBEDDING_DIM = 8
 
 
@@ -60,9 +61,10 @@ def _live_store(monkeypatch):
         pytest.skip("No pgvector connection string configured")
     try:
         _drop_graph_tables(conn)
-        return GraphStore(connection_string=conn)
+        store = GraphStore(connection_string=conn)
     except Exception as exc:
         pytest.skip(f"pgvector DB not reachable: {exc}")
+    return store
 
 
 class _StubLLM:
diff --git a/tests/graphrag/test_store.py b/tests/graphrag/test_store.py
index 559d59c6..dc9a543b 100644
--- a/tests/graphrag/test_store.py
+++ b/tests/graphrag/test_store.py
@@ -21,7 +21,8 @@ from unittest.mock import MagicMock
 import pytest
 
 import application.graphrag.store as store_module
-from application.graphrag.store import GraphStore
+
+GraphStore = store_module.GraphStore
 
 TEST_EMBEDDING_DIM = 8
 
@@ -71,9 +72,10 @@ def _live_store():
         pytest.skip("No pgvector connection string configured")
     try:
         _drop_graph_tables(conn)
-        return GraphStore(connection_string=conn)
+        store = GraphStore(connection_string=conn)
     except Exception as exc:
         pytest.skip(f"pgvector DB not reachable: {exc}")
+    return store
 
 
 def _embedding(seed: float) -> list:
@@ -171,7 +173,7 @@ class TestGraphStoreLive:
 
             store.set_node_degrees(source_id)
             recomputed = store.get_node_by_normalized(source_id, "solo")["degree"]
-            assert recomputed == incremental == 1
+            assert recomputed == 1
         finally:
             store.delete_by_source(source_id)