From 85175fa8c16ed5e545747dc20d58bd47675aff45 Mon Sep 17 00:00:00 2001 From: arc53-machine <232052973+arc53-machine@users.noreply.github.com> Date: Tue, 29 Sep 2026 13:13:27 +0100 Subject: [PATCH] Drop the owner-account warning box when sharing a tool A tool that can act already asks the owner to confirm; one that only reads names whose account members use in a plain line. --- frontend/src/teams/ShareToTeamModal.test.tsx | 12 +++++++++++- frontend/src/teams/ShareToTeamModal.tsx | 19 +++++++------------ 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/frontend/src/teams/ShareToTeamModal.test.tsx b/frontend/src/teams/ShareToTeamModal.test.tsx index b00b6b9c..e9f7fd07 100644 --- a/frontend/src/teams/ShareToTeamModal.test.tsx +++ b/frontend/src/teams/ShareToTeamModal.test.tsx @@ -99,8 +99,9 @@ describe('ShareToTeamModal credentials', () => { ); }); - it('warns that members act as the owner in owner mode', async () => { + it('says whose account members use on a tool that only reads', async () => { await render(credentials()); + expect(document.body.querySelector('[role="note"]')).toBeNull(); expect(document.body.querySelector('[data-slot="option-card"]')).toBeNull(); expect(toggle('owner').getAttribute('aria-checked')).toBe('true'); expect(document.body.textContent).toContain( @@ -108,6 +109,15 @@ describe('ShareToTeamModal credentials', () => { ); }); + it('asks only for the confirmation on a tool that can act, with no warning box', async () => { + await render(credentials({ hasWrites: true })); + expect(document.body.querySelector('[role="note"]')).toBeNull(); + expect(document.body.textContent).not.toContain( + 'settings.connectors.share.ownerWarning', + ); + expect(document.body.querySelector('#share-confirm-writes')).not.toBeNull(); + }); + it('blocks sharing an owner-mode tool with writes until confirmed', async () => { await render(credentials({ hasWrites: true })); expect(picker().disabled).toBe(true); diff --git a/frontend/src/teams/ShareToTeamModal.tsx b/frontend/src/teams/ShareToTeamModal.tsx index 0785a643..9823811e 100644 --- a/frontend/src/teams/ShareToTeamModal.tsx +++ b/frontend/src/teams/ShareToTeamModal.tsx @@ -1,10 +1,4 @@ -import { - CircleAlert, - Trash2, - TriangleAlert, - UserRound, - UsersRound, -} from 'lucide-react'; +import { CircleAlert, Trash2, UserRound, UsersRound } from 'lucide-react'; import { useEffect, useMemo, useRef, useState } from 'react'; import { useTranslation } from 'react-i18next'; import { useDispatch, useSelector } from 'react-redux'; @@ -593,16 +587,17 @@ export default function ShareToTeamModal({

)} {credentialMode === 'owner' ? ( - -