From a42037eadd35708c4de31c4854c6c927747b5908 Mon Sep 17 00:00:00 2001 From: Elton Chen-Yu Ho Date: Mon, 8 Jan 2018 22:07:40 +0300 Subject: [PATCH] Fix error when menu URL shorter than 4 characters is set Fix the error when calling slicestr to slice out-of-range bounds See #439 --- layouts/partials/navbar.html | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/layouts/partials/navbar.html b/layouts/partials/navbar.html index adb00f44..f344e68e 100644 --- a/layouts/partials/navbar.html +++ b/layouts/partials/navbar.html @@ -51,11 +51,13 @@ {{ else }} - - {{ if eq "http" (slicestr .URL 0 4) }} - {{ $.Scratch.Set "target" " target=\"_blank\" rel=\"noopener\"" }} - {{ else }} - {{ $.Scratch.Set "target" "" }} + + {{/* Set target for link. */}} + {{ $.Scratch.Set "target" "" }} + {{ if gt (len .URL) 4 }} + {{ if eq "http" (slicestr .URL 0 4) }} + {{ $.Scratch.Set "target" " target=\"_blank\" rel=\"noopener\"" }} + {{ end }} {{ end }}