From eb15a07dc3e0b6414a09e16494cc0462f4a23db1 Mon Sep 17 00:00:00 2001
From: George Cushen <gcushen@users.noreply.github.com>
Date: Wed, 30 Sep 2020 15:46:04 +0100
Subject: [PATCH] feat: improvements to author list

- Re-refactor code to use Hugo's `GetTerms` function now that Hugo fixed the unordered bug
  - GetTerms may provide better support for names with unicode or spaces
- Use Bootstrap's bundled PopoverJS for *instant* and more legible author note tooltips.
- Make author notes more intuitive and mobile friendly - use FA icon with left padding to discern touches.
- Add support for highlighting multiple author names (e.g. team members)

BREAKING CHANGE:

To highlight an author name, add `highlight_name: true` to the author's profile.

Close #1750
Fix #1861
Close #1864
---
 wowchemy/layouts/partials/page_metadata_authors.html | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/wowchemy/layouts/partials/page_metadata_authors.html b/wowchemy/layouts/partials/page_metadata_authors.html
index 3ce56cef..13012ede 100644
--- a/wowchemy/layouts/partials/page_metadata_authors.html
+++ b/wowchemy/layouts/partials/page_metadata_authors.html
@@ -1,17 +1,18 @@
 {{/* Display author list. */}}
 
 {{- $taxonomy := "authors" }}
-{{ with .Param $taxonomy }}
+{{ if .Param $taxonomy }}
   {{ $link_authors := site.Params.link_authors | default true }}
-  {{ range $index, $name_raw := . }}
-    {{- $profile_page := site.GetPage (printf "/%s/%s" $taxonomy .) -}}
-    {{- $name := $profile_page.Title | default $name_raw -}}
+  {{ range $index, $value := (.GetTerms $taxonomy) }}
+    {{- /* Highlight the author's name? */ -}}
+    {{- $highlight_name := .Page.Params.highlight_name | default false -}}
+
     {{- if gt $index 0 }}, {{ end -}}
     <span {{ if $highlight_name }}class="author-highlighted"{{end}}>
       {{- if $link_authors -}}
         <a href="{{.RelPermalink}}">{{.LinkTitle}}</a>
       {{- else -}}
-        {{$name}}
+        {{ .LinkTitle }}
       {{- end -}}
     </span>
     {{- if isset $.Params "author_notes" -}}