feat: flag repos that stopped receiving pushes

The maintenance criterion was unfalsifiable, so entries went years
without a push before anyone noticed by hand. The updater already
fetches pushedAt; warn when it is older than 90 days, alongside the
existing rename and archival annotations. Archived repos keep their own
warning rather than getting two.

Quantify the criterion in the README and CONTRIBUTING: dropped after 6
months idle, flagged past 3, with removal still a human decision.

Also correct two CONTRIBUTING claims the code contradicts — duplicates
are rejected by CI rather than ignored at run time, and renames do carry
history over once canonicalKeyMigrations has the old key.
This commit is contained in:
tiennm99 committed 2026-09-11 14:37:26 +07:00
1 parent 2e2ad56add
commit ce81c85645
4 files changed
+108 -7

No files matched your search

+85
View File
@@ -6,10 +6,12 @@ import (
"io"
"net/http"
"net/http/httptest"
"os"
"regexp"
"strconv"
"strings"
"testing"
"time"
)
// aliasRe extracts the numeric alias index from a GraphQL query fragment
@@ -227,3 +229,86 @@ func TestFetchStats_DriftWarnings(t *testing.T) {
}
}
}
// captureStdout redirects os.Stdout for the duration of fn and returns what
// was written, so the ::warning:: annotations fetchStats emits are assertable.
func captureStdout(t *testing.T, fn func()) string {
t.Helper()
r, w, err := os.Pipe()
if err != nil {
t.Fatalf("os.Pipe: %v", err)
}
orig := os.Stdout
os.Stdout = w
defer func() { os.Stdout = orig }()
fn()
if err := w.Close(); err != nil {
t.Fatalf("close pipe writer: %v", err)
}
out, err := io.ReadAll(r)
if err != nil {
t.Fatalf("read pipe: %v", err)
}
return string(out)
}
func TestFetchStats_StaleWarning(t *testing.T) {
fixed := time.Date(2026, 9, 11, 0, 0, 0, 0, time.UTC)
origNow := timeNow
timeNow = func() time.Time { return fixed }
defer func() { timeNow = origNow }()
agents := []Agent{
{Owner: "org", Repo: "fresh", Category: "cli"},
{Owner: "org", Repo: "stale", Category: "cli"},
{Owner: "org", Repo: "stale-and-archived", Category: "cli"},
}
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
node := func(name, pushedAt string, archived bool) map[string]any {
return map[string]any{
"stargazerCount": 5,
"nameWithOwner": name,
"pushedAt": pushedAt,
"isArchived": archived,
}
}
out, _ := json.Marshal(map[string]any{"data": map[string]any{
// 2 days idle: inside the window, no warning.
"r0": node("org/fresh", "2026-09-09T00:00:00Z", false),
// 120 days idle: past staleWarnAfter.
"r1": node("org/stale", "2026-05-14T00:00:00Z", false),
// Also stale, but archived — the archived warning covers it.
"r2": node("org/stale-and-archived", "2025-01-01T00:00:00Z", true),
}})
_, _ = w.Write(out) // httptest write error is not actionable in a test fake
}))
defer srv.Close()
withGraphQLURL(t, srv)
var stats []Stat
var fetchErr error
logs := captureStdout(t, func() { stats, fetchErr = fetchStats("test-token", agents) })
if fetchErr != nil {
t.Fatalf("fetchStats: %v (staleness should warn, not fail)", fetchErr)
}
if len(stats) != 3 {
t.Fatalf("expected 3 stats, got %d", len(stats))
}
if want := "::warning::repo org/stale has no push in 120 days"; !strings.Contains(logs, want) {
t.Errorf("missing stale warning %q in:\n%s", want, logs)
}
if strings.Contains(logs, "org/fresh has no push") {
t.Errorf("warned about a repo pushed 2 days ago:\n%s", logs)
}
if strings.Contains(logs, "org/stale-and-archived has no push") {
t.Errorf("stale warning duplicates the archived warning:\n%s", logs)
}
if want := "::warning::repo org/stale-and-archived is archived"; !strings.Contains(logs, want) {
t.Errorf("missing archived warning %q in:\n%s", want, logs)
}
}