fix(ui): keep remote read-only notice accurate

tests/unit/web-server/api-routes-remote-write-guard.test.ts

@@ -1,10 +1,15 @@
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it } from 'bun:test';
+import bcrypt from 'bcrypt';
 import express from 'express';
 import type { Server } from 'http';
 import * as fs from 'fs';
 import * as os from 'os';
 import * as path from 'path';
 import { apiRoutes } from '../../../src/web-server/routes';
+import {
+  authMiddleware,
+  createSessionMiddleware,
+} from '../../../src/web-server/middleware/auth-middleware';
 
 describe('api-routes remote write guard', () => {
   let server: Server;
@@ -107,12 +112,93 @@ describe('api-routes remote write guard', () => {
     });
   });
 
-  it('allows remote writes again when dashboard auth is enabled', async () => {
-    process.env.CCS_DASHBOARD_AUTH_ENABLED = 'true';
+  it('blocks remote PUT requests when dashboard auth is disabled', async () => {
+    const response = await fetch(`${baseUrl}/api/cliproxy-server`, {
+      method: 'PUT',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({}),
+    });
 
-    const response = await fetch(`${baseUrl}/api/profiles`, {
+    expect(response.status).toBe(403);
+    expect(await response.json()).toEqual({
+      error: 'Remote dashboard writes require localhost access when dashboard auth is disabled.',
+    });
+  });
+
+  it('blocks remote PATCH requests when dashboard auth is disabled', async () => {
+    const response = await fetch(`${baseUrl}/api/codex/config/patch`, {
+      method: 'PATCH',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({}),
+    });
+
+    expect(response.status).toBe(403);
+    expect(await response.json()).toEqual({
+      error: 'Remote dashboard writes require localhost access when dashboard auth is disabled.',
+    });
+  });
+
+  it('blocks remote DELETE requests when dashboard auth is disabled', async () => {
+    const response = await fetch(`${baseUrl}/api/profiles/demo`, {
+      method: 'DELETE',
+    });
+
+    expect(response.status).toBe(403);
+    expect(await response.json()).toEqual({
+      error: 'Remote dashboard writes require localhost access when dashboard auth is disabled.',
+    });
+  });
+
+  it('allows remote writes again when dashboard auth is enabled', async () => {
+    const password = 'testpassword123';
+    process.env.CCS_DASHBOARD_AUTH_ENABLED = 'true';
+    process.env.CCS_DASHBOARD_USERNAME = 'admin';
+    process.env.CCS_DASHBOARD_PASSWORD_HASH = await bcrypt.hash(password, 10);
+
+    const authApp = express();
+    authApp.use(express.json());
+    authApp.use((req, _res, next) => {
+      Object.defineProperty(req.socket, 'remoteAddress', {
+        value: forcedRemoteAddress,
+        configurable: true,
+      });
+      next();
+    });
+    authApp.use(createSessionMiddleware());
+    authApp.use(authMiddleware);
+    authApp.use('/api', apiRoutes);
+
+    const authServer = await new Promise<Server>((resolve, reject) => {
+      const instance = authApp.listen(0, '127.0.0.1');
+      instance.once('error', reject);
+      instance.once('listening', () => resolve(instance));
+    });
+
+    const address = authServer.address();
+    if (!address || typeof address === 'string') {
+      throw new Error('Unable to resolve auth-enabled test server port');
+    }
+    const authBaseUrl = `http://127.0.0.1:${address.port}`;
+
+    const loginResponse = await fetch(`${authBaseUrl}/api/auth/login`, {
       method: 'POST',
       headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({
+        username: 'admin',
+        password,
+      }),
+    });
+    const cookie = loginResponse.headers.get('set-cookie');
+
+    expect(loginResponse.status).toBe(200);
+    expect(cookie).toBeTruthy();
+
+    const response = await fetch(`${authBaseUrl}/api/profiles`, {
+      method: 'POST',
+      headers: {
+        'Content-Type': 'application/json',
+        Cookie: cookie as string,
+      },
       body: JSON.stringify({
         name: 'demo',
         baseUrl: 'https://api.example.com',
@@ -120,6 +206,11 @@ describe('api-routes remote write guard', () => {
       }),
     });
 
-    expect(response.status).not.toBe(403);
+    expect(response.status).toBe(201);
+
+    await new Promise<void>((resolve) => authServer.close(() => resolve()));
+
+    delete process.env.CCS_DASHBOARD_USERNAME;
+    delete process.env.CCS_DASHBOARD_PASSWORD_HASH;
   });
 });