fix(cliproxy): complete backend param propagation per code review

- Add backend param to checkLatestVersion()
- Add backend param to isPinned(), getPinned(), clearPin() wrappers
- Use getBackendLabel() consistently in showStatus()

Addresses review feedback from PR #359.
This commit is contained in:
kaitranntt committed 2026-01-23 13:20:31 -05:00
1 parent 628148c359
commit 388ab69a97
2 files changed
+18 -9

No files matched your search

+17 -8
View File
@@ -70,10 +70,13 @@ export function getBinaryStatus(backend?: CLIProxyBackend): BinaryStatusResult {
/** /**
* Check for latest version * Check for latest version
*/ */
export async function checkLatestVersion(): Promise<LatestVersionResult> { export async function checkLatestVersion(backend?: CLIProxyBackend): Promise<LatestVersionResult> {
const effectiveBackend =
backend ?? loadOrCreateUnifiedConfig().cliproxy?.backend ?? DEFAULT_BACKEND;
try { try {
const latestVersion = await fetchLatestCliproxyVersion(); const latestVersion = await fetchLatestCliproxyVersion();
const currentVersion = getInstalledCliproxyVersion(); const currentVersion = getInstalledCliproxyVersion(effectiveBackend);
const updateAvailable = latestVersion !== currentVersion; const updateAvailable = latestVersion !== currentVersion;
return { return {
@@ -177,20 +180,26 @@ export async function installLatest(
/** /**
* Check if a version is pinned * Check if a version is pinned
*/ */
export function isPinned(): boolean { export function isPinned(backend?: CLIProxyBackend): boolean {
return isVersionPinned(); const effectiveBackend =
backend ?? loadOrCreateUnifiedConfig().cliproxy?.backend ?? DEFAULT_BACKEND;
return isVersionPinned(effectiveBackend);
} }
/** /**
* Get pinned version if any * Get pinned version if any
*/ */
export function getPinned(): string | null { export function getPinned(backend?: CLIProxyBackend): string | null {
return getPinnedVersion(); const effectiveBackend =
backend ?? loadOrCreateUnifiedConfig().cliproxy?.backend ?? DEFAULT_BACKEND;
return getPinnedVersion(effectiveBackend);
} }
/** /**
* Clear version pin * Clear version pin
*/ */
export function clearPin(): void { export function clearPin(backend?: CLIProxyBackend): void {
clearPinnedVersion(); const effectiveBackend =
backend ?? loadOrCreateUnifiedConfig().cliproxy?.backend ?? DEFAULT_BACKEND;
clearPinnedVersion(effectiveBackend);
} }
+1 -1
View File
@@ -488,7 +488,7 @@ async function showStatus(verbose: boolean, backend: CLIProxyBackend): Promise<v
const status = getBinaryStatus(backend); const status = getBinaryStatus(backend);
console.log(''); console.log('');
const backendLabel = backend === 'plus' ? 'CLIProxy Plus' : 'CLIProxy (Original)'; const backendLabel = getBackendLabel(backend);
console.log(color(`${backendLabel} Status`, 'primary')); console.log(color(`${backendLabel} Status`, 'primary'));
console.log(''); console.log('');