mirror of
https://github.com/tiennm99/ccs.git
synced 2026-10-12 18:15:48 +00:00
fix(cliproxy): close second-round review gaps in pool onboarding and remote env
- create-command: show the pool onboarding hint only after profile creation fully succeeds; the pre-create placement burned the once-per-install dismissal when creation failed or rolled back - remote env (claude): skip the read-level stale-pin filter once the migration marker exists - a post-migration pin is user-intentional (e.g. an explicit --config pick equal to a historical default) - unified-config loader: document that loadOrCreateUnifiedConfig never writes to disk, so read paths on legacy installs stay side-effect free
This commit is contained in:
1 parent
cff9008f49
commit
7b8a6f5cce
5 files changed
+64
-27
No files matched your search
@@ -189,18 +189,6 @@ export async function handleCreate(ctx: CommandContext, args: string[]): Promise
|
||||
}
|
||||
};
|
||||
|
||||
// Pool suggestion: when creating a 2nd+ native Claude profile, show the
|
||||
// once-per-install onboarding hint. Print-only, TTY-gated, never blocks.
|
||||
// Pass existingCount + 1 so the hint sees the post-create count (>= 2).
|
||||
// Gated on hasUnifiedConfig() so legacy profiles.json-only installs receive
|
||||
// the hint from ccs doctor only (where dismissal semantics are preserved).
|
||||
if (!profileExistedBeforeCreate && hasUnifiedConfig()) {
|
||||
const existingCount = countNativeClaudeProfiles();
|
||||
if (existingCount >= 1) {
|
||||
maybeShowPoolOnboardingHint(existingCount + 1);
|
||||
}
|
||||
}
|
||||
|
||||
try {
|
||||
// Create instance directory
|
||||
console.log(info(`Creating profile: ${profileName}`));
|
||||
@@ -326,6 +314,16 @@ export async function handleCreate(ctx: CommandContext, args: string[]): Promise
|
||||
)
|
||||
);
|
||||
console.log('');
|
||||
// Pool suggestion: shown only AFTER the profile creation fully
|
||||
// succeeded (a pre-create hint would burn the once-per-install
|
||||
// dismissal even when creation fails or rolls back). Print-only,
|
||||
// TTY-gated, never blocks. Gated on hasUnifiedConfig() so legacy
|
||||
// profiles.json-only installs receive the hint from ccs doctor only
|
||||
// (where dismissal semantics are preserved). The profile now exists,
|
||||
// so the registry count is already post-create (no +1 needed).
|
||||
if (!profileExistedBeforeCreate && hasUnifiedConfig()) {
|
||||
maybeShowPoolOnboardingHint(countNativeClaudeProfiles());
|
||||
}
|
||||
process.exit(0);
|
||||
} else {
|
||||
await rollbackFailedCreate();
|
||||
|
||||
Reference in new issue
Block a user