tiennm99/ccs
1
0 Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-10-13 16:14:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(browser): track explicit devtools_port from config (#1383)

Browse Source 
#1369 unconditionally set hasExplicitDevtoolsPort=false for config-attach,
which broke users who explicitly set devtools_port in config. Now track
whether config.claude.devtools_port was actually provided.
This commit is contained in:
Kai (Tam Nhu) Tran authored and GitHub committed 2026-05-23 21:55:02 -04:00
1 parent f985cec3ff
commit b63943eb45
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
src/utils/browser/browser-settings.ts
+2 -1
View File
@@ -230,6 +230,7 @@ export function getEffectiveClaudeBrowserAttachConfig(
const override = getBrowserAttachOverride(env); const override = getBrowserAttachOverride(env);
const configUserDataDir = const configUserDataDir =
resolveBrowserUserDataDir(config.claude.user_data_dir) ?? getRecommendedBrowserUserDataDir(); resolveBrowserUserDataDir(config.claude.user_data_dir) ?? getRecommendedBrowserUserDataDir();
const configHasExplicitPort = config.claude.devtools_port !== undefined;
const configPort = normalizeDevtoolsPort(config.claude.devtools_port); const configPort = normalizeDevtoolsPort(config.claude.devtools_port);
const configEvalMode = config.claude.eval_mode ?? 'readonly'; const configEvalMode = config.claude.eval_mode ?? 'readonly';
const envEvalMode = parseBrowserEvalMode(env.CCS_BROWSER_EVAL_MODE); const envEvalMode = parseBrowserEvalMode(env.CCS_BROWSER_EVAL_MODE);
@@ -253,7 +254,7 @@ export function getEffectiveClaudeBrowserAttachConfig(
overrideActive: false, overrideActive: false,
userDataDir: configUserDataDir, userDataDir: configUserDataDir,
devtoolsPort: configPort, devtoolsPort: configPort,
hasExplicitDevtoolsPort: false, hasExplicitDevtoolsPort: configHasExplicitPort,
evalMode: effectiveEvalMode, evalMode: effectiveEvalMode,
}; };
} }