feat(dashboard-auth): clarify remote dashboard login flow

- add explicit access modes so remote users see setup guidance instead of an ambiguous login

- redesign the login page with remote setup messaging, password visibility, and light/dark controls

- cover the access-state contract and login UI with focused tests
This commit is contained in:
Tam Nhu Tran committed 2026-04-06 17:01:49 -04:00
1 parent 9b3e85c5d9
commit d130972916
7 files changed
+600 -89

No files matched your search

@@ -1,13 +1,14 @@
/**
* Auth Check Route — Remote Access Detection Tests
*
* Verifies that /api/auth/check returns effectiveAuthRequired=true
* for remote clients when auth is disabled, preventing a silently
* broken dashboard.
* Verifies that /api/auth/check produces a distinct setup state for
* remote clients or incomplete host config instead of always showing
* a login form.
*/
import { describe, it, expect } from 'bun:test';
import { isLoopbackRemoteAddress } from '../../../src/web-server/middleware/auth-middleware';
import { resolveDashboardAccessState } from '../../../src/web-server/routes/auth-routes';
describe('isLoopbackRemoteAddress', () => {
it('returns true for IPv4 localhost', () => {
@@ -37,27 +38,69 @@ describe('isLoopbackRemoteAddress', () => {
});
});
describe('effectiveAuthRequired logic', () => {
// Mirrors the logic in auth-routes.ts GET /api/auth/check:
// effectiveAuthRequired = authConfig.enabled || !isLocal
function computeEffectiveAuthRequired(authEnabled: boolean, remoteAddress: string | undefined) {
const isLocal = isLoopbackRemoteAddress(remoteAddress);
return authEnabled || !isLocal;
}
it('localhost + auth disabled -> authRequired=false', () => {
expect(computeEffectiveAuthRequired(false, '127.0.0.1')).toBe(false);
describe('resolveDashboardAccessState', () => {
it('allows localhost through when auth is disabled', () => {
expect(
resolveDashboardAccessState(
{ enabled: false, username: '', password_hash: '', session_timeout_hours: 24 },
'127.0.0.1'
)
).toEqual({
authRequired: false,
authEnabled: false,
authConfigured: false,
isLocalAccess: true,
accessMode: 'open',
});
});
it('remote + auth disabled -> authRequired=true', () => {
expect(computeEffectiveAuthRequired(false, '192.168.2.100')).toBe(true);
it('shows setup state for remote access when auth is disabled', () => {
expect(
resolveDashboardAccessState(
{ enabled: false, username: '', password_hash: '', session_timeout_hours: 24 },
'192.168.2.100'
)
).toEqual({
authRequired: true,
authEnabled: false,
authConfigured: false,
isLocalAccess: false,
accessMode: 'setup',
});
});
it('remote + auth enabled -> authRequired=true', () => {
expect(computeEffectiveAuthRequired(true, '192.168.2.100')).toBe(true);
it('shows login state only when auth is enabled and fully configured', () => {
expect(
resolveDashboardAccessState(
{
enabled: true,
username: 'admin',
password_hash: '$2b$10$123456789012345678901u4cPFsKnzGWxZmfq6OnpZnN0UiM6Qf7e',
session_timeout_hours: 24,
},
'192.168.2.100'
)
).toEqual({
authRequired: true,
authEnabled: true,
authConfigured: true,
isLocalAccess: false,
accessMode: 'login',
});
});
it('localhost + auth enabled -> authRequired=true', () => {
expect(computeEffectiveAuthRequired(true, '127.0.0.1')).toBe(true);
it('shows setup state when auth is enabled but credentials are incomplete', () => {
expect(
resolveDashboardAccessState(
{ enabled: true, username: 'admin', password_hash: '', session_timeout_hours: 24 },
'127.0.0.1'
)
).toEqual({
authRequired: true,
authEnabled: true,
authConfigured: false,
isLocalAccess: true,
accessMode: 'setup',
});
});
});