feat(dashboard-auth): clarify remote dashboard login flow

- add explicit access modes so remote users see setup guidance instead of an ambiguous login

- redesign the login page with remote setup messaging, password visibility, and light/dark controls

- cover the access-state contract and login UI with focused tests
This commit is contained in:
Tam Nhu Tran committed 2026-04-06 17:01:49 -04:00
1 parent 9b3e85c5d9
commit d130972916
7 files changed
+600 -89

No files matched your search

+252 -57
View File
@@ -10,32 +10,68 @@ import { Button } from '@/components/ui/button';
import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label';
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
import { AlertCircle, Loader2, Lock } from 'lucide-react';
import { Alert, AlertDescription } from '@/components/ui/alert';
import { useTheme } from '@/hooks/use-theme';
import { cn } from '@/lib/utils';
import {
AlertCircle,
Command,
Eye,
EyeOff,
Loader2,
Lock,
MonitorSmartphone,
Moon,
ShieldCheck,
Sun,
} from 'lucide-react';
import { Alert, AlertDescription, AlertTitle } from '@/components/ui/alert';
import { useTranslation } from 'react-i18next';
export function LoginPage() {
const { t } = useTranslation();
const { isDark, setTheme } = useTheme();
const [username, setUsername] = useState('');
const [password, setPassword] = useState('');
const [showPassword, setShowPassword] = useState(false);
const [error, setError] = useState<string | null>(null);
const [loading, setLoading] = useState(false);
const [submitting, setSubmitting] = useState(false);
const { login, authRequired, isAuthenticated } = useAuth();
const { login, authRequired, isAuthenticated, loading, accessMode, authEnabled } = useAuth();
const navigate = useNavigate();
const location = useLocation();
const isSetupState = accessMode === 'setup';
const heroLabel = isSetupState ? t('auth.remoteGuardLabel') : t('auth.protectedAccessLabel');
const heroDescription = isSetupState
? authEnabled
? t('auth.incompleteSetupDescription')
: t('auth.remoteSetupDescription')
: t('auth.loginDescription');
// Get redirect destination (default to home)
const from = (location.state as { from?: { pathname: string } })?.from?.pathname || '/';
// Redirect if already authenticated or auth not required (via useEffect to avoid render side effects)
useEffect(() => {
if (loading) {
return;
}
if (isAuthenticated || !authRequired) {
navigate(from, { replace: true });
}
}, [isAuthenticated, authRequired, navigate, from]);
}, [isAuthenticated, authRequired, loading, navigate, from]);
// Show nothing while redirecting
if (loading) {
return (
<div className="flex min-h-[100dvh] items-center justify-center bg-background px-4">
<div className="flex items-center gap-3 rounded-full border border-border/80 bg-card/90 px-5 py-3 text-sm text-muted-foreground shadow-sm">
<Loader2 className="h-4 w-4 animate-spin" />
{t('auth.loading')}
</div>
</div>
);
}
if (isAuthenticated || !authRequired) {
return null;
}
@@ -43,7 +79,7 @@ export function LoginPage() {
const handleSubmit = async (e: React.FormEvent) => {
e.preventDefault();
setError(null);
setLoading(true);
setSubmitting(true);
try {
await login(username, password);
@@ -51,67 +87,226 @@ export function LoginPage() {
} catch (err) {
setError(err instanceof Error ? err.message : t('auth.loginFailed'));
} finally {
setLoading(false);
setSubmitting(false);
}
};
return (
<div className="flex min-h-screen items-center justify-center bg-background p-4">
<Card className="w-full max-w-sm">
<CardHeader className="space-y-1 text-center">
<div className="mx-auto mb-2 flex h-12 w-12 items-center justify-center rounded-full bg-primary/10">
<Lock className="h-6 w-6 text-primary" />
</div>
<CardTitle className="text-2xl">{t('auth.dashboardTitle')}</CardTitle>
<CardDescription>{t('auth.loginDescription')}</CardDescription>
</CardHeader>
<CardContent>
<form onSubmit={handleSubmit} className="space-y-4">
{error && (
<Alert variant="destructive">
<AlertCircle className="h-4 w-4" />
<AlertDescription>{error}</AlertDescription>
</Alert>
)}
<div className="space-y-2">
<Label htmlFor="username">{t('auth.username')}</Label>
<Input
id="username"
type="text"
value={username}
onChange={(e) => setUsername(e.target.value)}
placeholder={t('auth.usernamePlaceholder')}
autoComplete="username"
disabled={loading}
required
/>
<div className="relative min-h-[100dvh] overflow-hidden bg-background">
<div className="absolute inset-0 bg-[radial-gradient(circle_at_top_left,rgba(167,85,52,0.16),transparent_42%),radial-gradient(circle_at_bottom_right,rgba(39,39,42,0.12),transparent_48%)]" />
<div className="absolute inset-0 opacity-[0.18] [background-image:linear-gradient(rgba(127,117,107,0.14)_1px,transparent_1px),linear-gradient(90deg,rgba(127,117,107,0.14)_1px,transparent_1px)] [background-size:24px_24px]" />
<div className="relative mx-auto flex min-h-[100dvh] max-w-6xl items-center px-4 py-8 sm:px-6">
<div className="grid w-full items-stretch gap-6 lg:grid-cols-[minmax(0,1.05fr)_minmax(360px,430px)]">
<section className="flex flex-col justify-between rounded-[28px] border border-border/70 bg-card/85 p-6 shadow-[0_24px_80px_-48px_rgba(68,48,34,0.55)] backdrop-blur sm:p-8">
<div className="space-y-6">
<div className="flex flex-wrap items-center justify-between gap-3">
<span className="inline-flex w-fit items-center gap-2 rounded-full border border-border/70 bg-background/75 px-3 py-1 text-xs font-semibold uppercase tracking-[0.24em] text-muted-foreground">
<ShieldCheck className="h-3.5 w-3.5 text-accent" />
{heroLabel}
</span>
<div className="inline-flex items-center gap-1 rounded-full border border-border/70 bg-background/75 p-1 shadow-sm backdrop-blur">
<Button
type="button"
variant="ghost"
size="sm"
className={cn(
'rounded-full px-3 text-xs font-semibold',
!isDark && 'bg-card text-foreground shadow-sm'
)}
aria-pressed={!isDark}
onClick={() => setTheme('light')}
>
<Sun className="h-3.5 w-3.5" />
{t('auth.lightMode')}
</Button>
<Button
type="button"
variant="ghost"
size="sm"
className={cn(
'rounded-full px-3 text-xs font-semibold',
isDark && 'bg-card text-foreground shadow-sm'
)}
aria-pressed={isDark}
onClick={() => setTheme('dark')}
>
<Moon className="h-3.5 w-3.5" />
{t('auth.darkMode')}
</Button>
</div>
</div>
<div className="space-y-3">
<h1 className="max-w-xl text-4xl font-semibold tracking-[-0.04em] text-balance text-foreground sm:text-5xl">
{isSetupState ? t('auth.remoteSetupTitle') : t('auth.dashboardTitle')}
</h1>
<p className="max-w-2xl text-base leading-7 text-muted-foreground sm:text-lg">
{heroDescription}
</p>
</div>
</div>
<div className="space-y-2">
<Label htmlFor="password">{t('auth.password')}</Label>
<Input
id="password"
type="password"
value={password}
onChange={(e) => setPassword(e.target.value)}
placeholder={t('auth.passwordPlaceholder')}
autoComplete="current-password"
disabled={loading}
required
/>
<div className="mt-8 grid gap-3 text-sm text-muted-foreground sm:grid-cols-3">
<div className="rounded-2xl border border-border/70 bg-background/70 p-4">
<MonitorSmartphone className="mb-3 h-4 w-4 text-accent" />
<p>{t('auth.safetyNoteRemote')}</p>
</div>
<div className="rounded-2xl border border-border/70 bg-background/70 p-4">
<Lock className="mb-3 h-4 w-4 text-accent" />
<p>{t('auth.safetyNoteLocal')}</p>
</div>
<div className="rounded-2xl border border-border/70 bg-background/70 p-4">
<ShieldCheck className="mb-3 h-4 w-4 text-accent" />
<p>{t('auth.safetyNoteSession')}</p>
</div>
</div>
<Button type="submit" className="w-full" disabled={loading}>
{loading ? (
</section>
<Card className="justify-center rounded-[28px] border-border/70 bg-card/95 py-0 shadow-[0_24px_90px_-54px_rgba(34,24,16,0.62)]">
<CardHeader className="space-y-3 border-b border-border/70 px-6 py-6">
<div className="flex h-12 w-12 items-center justify-center rounded-2xl border border-accent/20 bg-accent/10">
{isSetupState ? (
<MonitorSmartphone className="h-5 w-5 text-accent" />
) : (
<Lock className="h-5 w-5 text-accent" />
)}
</div>
<div className="space-y-1.5">
<CardTitle className="text-2xl tracking-[-0.03em]">
{isSetupState ? t('auth.remoteSetupTitle') : t('auth.dashboardTitle')}
</CardTitle>
<CardDescription className="text-sm leading-6 text-muted-foreground">
{isSetupState ? heroDescription : t('auth.credentialsHint')}
</CardDescription>
</div>
</CardHeader>
<CardContent className="space-y-5 px-6 py-6">
{isSetupState ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
{t('auth.signingIn')}
<Alert
variant="warning"
className="rounded-2xl border-yellow-300/70 bg-yellow-50/80"
>
<AlertCircle className="h-4 w-4" />
<AlertTitle>{t('auth.noDefaultCredentials')}</AlertTitle>
<AlertDescription>{t('auth.credentialsHint')}</AlertDescription>
</Alert>
<div className="grid gap-3 sm:grid-cols-2">
<div className="rounded-2xl border border-border/70 bg-background/75 p-4">
<div className="flex items-center gap-2 text-sm font-semibold text-foreground">
<Command className="h-4 w-4 text-accent" />
{t('auth.hostStepTitle')}
</div>
<p className="mt-2 text-sm leading-6 text-muted-foreground">
{t('auth.hostStepDescription')}
</p>
<code className="mt-4 block rounded-xl border border-border/70 bg-muted/60 px-3 py-2 font-mono text-[13px] text-foreground">
ccs config auth setup
</code>
</div>
<div className="rounded-2xl border border-border/70 bg-background/75 p-4">
<div className="flex items-center gap-2 text-sm font-semibold text-foreground">
<ShieldCheck className="h-4 w-4 text-accent" />
{t('auth.localStepTitle')}
</div>
<p className="mt-2 text-sm leading-6 text-muted-foreground">
{t('auth.localStepDescription')}
</p>
</div>
</div>
</>
) : (
t('auth.signIn')
<form onSubmit={handleSubmit} className="space-y-4">
{error && (
<Alert variant="destructive" className="rounded-2xl">
<AlertCircle className="h-4 w-4" />
<AlertDescription>{error}</AlertDescription>
</Alert>
)}
<Alert variant="info" className="rounded-2xl border-blue-200/80 bg-blue-50/80">
<ShieldCheck className="h-4 w-4" />
<AlertTitle>{t('auth.noDefaultCredentials')}</AlertTitle>
<AlertDescription>{t('auth.credentialsHint')}</AlertDescription>
</Alert>
<div className="space-y-2">
<Label htmlFor="username" className="text-sm font-semibold">
{t('auth.username')}
</Label>
<Input
id="username"
type="text"
value={username}
onChange={(e) => setUsername(e.target.value)}
placeholder={t('auth.usernamePlaceholder')}
autoComplete="username"
className="h-12 rounded-2xl border-border/80 bg-background/85 px-4 text-base md:text-base"
disabled={submitting}
required
/>
</div>
<div className="space-y-2">
<Label htmlFor="password" className="text-sm font-semibold">
{t('auth.password')}
</Label>
<div className="relative">
<Input
id="password"
type={showPassword ? 'text' : 'password'}
value={password}
onChange={(e) => setPassword(e.target.value)}
placeholder={t('auth.passwordPlaceholder')}
autoComplete="current-password"
className="h-12 rounded-2xl border-border/80 bg-background/85 px-4 pr-14 text-base md:text-base"
disabled={submitting}
required
/>
<Button
type="button"
variant="ghost"
size="sm"
className="absolute inset-y-1 right-1 h-auto rounded-xl px-3 text-muted-foreground hover:text-foreground"
aria-label={showPassword ? t('auth.hidePassword') : t('auth.showPassword')}
aria-pressed={showPassword}
onClick={() => setShowPassword((value) => !value)}
disabled={submitting}
>
{showPassword ? (
<EyeOff className="h-4 w-4" />
) : (
<Eye className="h-4 w-4" />
)}
</Button>
</div>
</div>
<Button
type="submit"
className="h-12 w-full rounded-2xl text-sm font-semibold"
disabled={submitting}
>
{submitting ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
{t('auth.signingIn')}
</>
) : (
t('auth.signIn')
)}
</Button>
</form>
)}
</Button>
</form>
</CardContent>
</Card>
</CardContent>
</Card>
</div>
</div>
</div>
);
}