tiennm99/ccs
1
0 Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-10-14 16:17:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1430 from kaitranntt/codex/fix-vulnerability-in-shell-completion-scripts

Browse Source 
fix: avoid relative completion backend execution
This commit is contained in:
Kai (Tam Nhu) Tran authored and GitHub committed 2026-05-30 16:12:15 -04:00
2 parents f41480cdbd 4f2dd70b8c
commit e2d487883f
5 files changed
+21 -46
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/unit/commands/shell-completion-command.test.ts
+21
View File
@@ -143,6 +143,27 @@ describe('shell-completion command', () => {
);
});
it('completion adapters only delegate to the ccs command on PATH', () => {
const completionScripts = [
'../../../scripts/completion/ccs.bash',
'../../../scripts/completion/ccs.zsh',
'../../../scripts/completion/ccs.fish',
'../../../scripts/completion/ccs.ps1',
];
for (const scriptPath of completionScripts) {
const script = readFileSync(join(import.meta.dir, scriptPath), 'utf8');
expect(script).not.toContain('../..');
expect(script).not.toContain('repo_root');
expect(script).not.toContain('repoRoot');
expect(script).not.toContain('repo_cli');
expect(script).not.toContain('repoCli');
expect(script).not.toContain('node ');
expect(script).not.toContain('& node');
}
});
it('fish completion strips a duplicated partial token before delegating to __complete', () => {
const fishScript = readFileSync(
join(import.meta.dir, '../../../scripts/completion/ccs.fish'),