mirror of
https://github.com/tiennm99/ccs.git
synced 2026-10-13 16:14:31 +00:00
fix(codex-auth): address persistent review focus
This commit is contained in:
1 parent
81c4acc73a
commit
e461c7a67e
4 files changed
+61
-6
No files matched your search
@@ -193,6 +193,14 @@ function resolveActive(registry: CodexProfileData): CodexAuthActiveProfile | nul
|
||||
// Precedence 2: $CCS_CODEX_PROFILE env var
|
||||
const profileEnv = (process.env.CCS_CODEX_PROFILE ?? '').trim();
|
||||
if (profileEnv) {
|
||||
if (!Object.prototype.hasOwnProperty.call(registry.profiles, profileEnv)) {
|
||||
logger.warn(
|
||||
'codex-auth.dashboard.stale-env-profile',
|
||||
'Ignoring CCS_CODEX_PROFILE because it is not registered',
|
||||
{ profileName: profileEnv }
|
||||
);
|
||||
return null;
|
||||
}
|
||||
return {
|
||||
name: profileEnv,
|
||||
source: 'env',
|
||||
|
||||
@@ -16,6 +16,7 @@ import { resolveCodexProfileDir, ensureSharedConfigSymlink } from '../index';
|
||||
import { decodeAccountIdentity } from '../codex-account-identity';
|
||||
import { detectCodexCli } from '../../targets/codex-detector';
|
||||
import { parseArgs, rejectUnsupportedOptions, getProfileNameError } from './types';
|
||||
import type { CodexProfileMetadata } from '../types';
|
||||
import type { CodexCommandContext } from './types';
|
||||
|
||||
const logger = createLogger('codex-auth:cmd:login');
|
||||
@@ -98,12 +99,11 @@ export async function handleLoginCodex(ctx: CodexCommandContext, args: string[])
|
||||
if (exitCode === 0 && fs.existsSync(authJsonPath)) {
|
||||
const identity = decodeAccountIdentity(authJsonPath);
|
||||
const now = new Date().toISOString();
|
||||
registry.updateProfile(profileName, {
|
||||
last_used: now,
|
||||
email: identity.email,
|
||||
plan_type: identity.plan_type ?? null,
|
||||
account_id: identity.account_id,
|
||||
});
|
||||
const metadataUpdate: Partial<CodexProfileMetadata> = { last_used: now };
|
||||
if (identity.email !== undefined) metadataUpdate.email = identity.email;
|
||||
if (identity.plan_type !== undefined) metadataUpdate.plan_type = identity.plan_type;
|
||||
if (identity.account_id !== undefined) metadataUpdate.account_id = identity.account_id;
|
||||
registry.updateProfile(profileName, metadataUpdate);
|
||||
const emailStr = identity.email ?? '<unknown>';
|
||||
const planStr = identity.plan_type ? ` (plan: ${identity.plan_type})` : '';
|
||||
console.log(ok(`Logged in as ${emailStr}${planStr}`));
|
||||
|
||||
Reference in new issue
Block a user