fix(codex-auth): address persistent review focus

This commit is contained in:
Tam Nhu Tran committed 2026-05-17 18:33:20 -04:00
1 parent 81c4acc73a
commit e461c7a67e
4 files changed
+61 -6

No files matched your search

@@ -363,6 +363,23 @@ describe('getCodexAuthProfilesSummary', () => {
expect(result.active?.name).toBe('work');
});
it('active resolution: ignores stale CCS_CODEX_PROFILE values missing from registry', async () => {
const { getCodexAuthProfilesSummary, invalidateCodexAuthProfilesCache } = await importService();
invalidateCodexAuthProfilesCache();
process.env.CCS_CODEX_PROFILE = 'ghost';
const registryPath = path.join(ccsDir, 'codex-profiles.yaml');
fs.writeFileSync(
registryPath,
`version: "1.0"\ndefault: null\nprofiles:\n work:\n type: codex\n created: "2026-01-01T00:00:00Z"\n last_used: null\n`,
{ mode: 0o600 }
);
const result = await getCodexAuthProfilesSummary();
expect(result.active).toBeNull();
});
it('active resolution: registry default set -> source=default', async () => {
const { getCodexAuthProfilesSummary, invalidateCodexAuthProfilesCache } = await importService();
invalidateCodexAuthProfilesCache();
@@ -217,6 +217,36 @@ describe('handleLoginCodex — clean exit updates registry', () => {
expect(meta.last_used).toBeTruthy();
});
it('preserves cached identity metadata when a re-login token is sparse', async () => {
const detectorMod = await import('../../../../src/targets/codex-detector');
spyOn(detectorMod, 'detectCodexCli').mockReturnValue('/usr/bin/codex');
spawnReturnsCode(0, true); // writes auth.json with a valid but sparse JWT payload
const { handleLoginCodex } = await import('../../../../src/codex-auth/commands/login-command');
const ctx = await makeCtx();
ctx.registry.createProfile('preservemeta', {
created: new Date().toISOString(),
last_used: null,
email: 'cached@example.com',
plan_type: 'pro',
account_id: 'acct-cached',
});
const origLog = console.log;
console.log = () => {};
try {
await handleLoginCodex(ctx, ['preservemeta']);
} finally {
console.log = origLog;
}
const meta = ctx.registry.getProfile('preservemeta');
expect(meta.last_used).toBeTruthy();
expect(meta.email).toBe('cached@example.com');
expect(meta.plan_type).toBe('pro');
expect(meta.account_id).toBe('acct-cached');
});
it('persists account_id when login token has account_id only', async () => {
const detectorMod = await import('../../../../src/targets/codex-detector');
spyOn(detectorMod, 'detectCodexCli').mockReturnValue('/usr/bin/codex');