mirror of
https://github.com/tiennm99/coolify.git
synced 2026-10-13 20:14:45 +00:00
fix(auth): enforce authorization checks across API and Livewire components
- Add authorization checks to API controller endpoints (view, create, update, delete) - Wrap Livewire component methods with try-catch for consistent error handling - Add AuthorizesRequests trait to components requiring authorization checks - Ensure all sensitive operations verify user permissions before execution - Implement unified error handling with handleError() helper function
This commit is contained in:
1 parent
12f8f80eb1
commit
86b05b902a
84 files changed
+4046
-1055
No files matched your search
@@ -0,0 +1,122 @@
|
||||
<?php
|
||||
|
||||
use App\Models\StandaloneDocker;
|
||||
use App\Models\User;
|
||||
use App\Policies\StandaloneDockerPolicy;
|
||||
|
||||
it('allows any user to view any standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->viewAny($user))->toBeTrue();
|
||||
});
|
||||
|
||||
it('allows team member to view their team standalone docker', function () {
|
||||
$teams = collect([
|
||||
(object) ['id' => 1],
|
||||
]);
|
||||
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('getAttribute')->with('teams')->andReturn($teams);
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->view($user, $standaloneDocker))->toBeTrue();
|
||||
});
|
||||
|
||||
it('denies user from viewing another team standalone docker', function () {
|
||||
$teams = collect([
|
||||
(object) ['id' => 1],
|
||||
]);
|
||||
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('getAttribute')->with('teams')->andReturn($teams);
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 2]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->view($user, $standaloneDocker))->toBeFalse();
|
||||
});
|
||||
|
||||
it('allows admin to create standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('isAdmin')->andReturn(true);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->create($user))->toBeTrue();
|
||||
});
|
||||
|
||||
it('denies non-admin from creating standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('isAdmin')->andReturn(false);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->create($user))->toBeFalse();
|
||||
});
|
||||
|
||||
it('allows team admin to update standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('isAdminOfTeam')->with(1)->andReturn(true);
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->update($user, $standaloneDocker))->toBeTrue();
|
||||
});
|
||||
|
||||
it('denies non-admin from updating standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('isAdminOfTeam')->with(1)->andReturn(false);
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->update($user, $standaloneDocker))->toBeFalse();
|
||||
});
|
||||
|
||||
it('allows team admin to delete standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('isAdminOfTeam')->with(1)->andReturn(true);
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->delete($user, $standaloneDocker))->toBeTrue();
|
||||
});
|
||||
|
||||
it('denies non-admin from deleting standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
$user->shouldReceive('isAdminOfTeam')->with(1)->andReturn(false);
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->delete($user, $standaloneDocker))->toBeFalse();
|
||||
});
|
||||
|
||||
it('denies restore for standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->restore($user, $standaloneDocker))->toBeFalse();
|
||||
});
|
||||
|
||||
it('denies force delete for standalone docker', function () {
|
||||
$user = Mockery::mock(User::class)->makePartial();
|
||||
|
||||
$standaloneDocker = Mockery::mock(StandaloneDocker::class)->makePartial();
|
||||
$standaloneDocker->shouldReceive('getAttribute')->with('server')->andReturn((object) ['team_id' => 1]);
|
||||
|
||||
$policy = new StandaloneDockerPolicy;
|
||||
expect($policy->forceDelete($user, $standaloneDocker))->toBeFalse();
|
||||
});
|
||||
Reference in new issue
Block a user