tiennm99/coolify
1
0 Fork 0
mirror of https://github.com/tiennm99/coolify.git synced 2026-10-13 04:14:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(github): require opt-in custom webhook endpoint

Browse Source
This commit is contained in:
Andras Bacsai committed 2026-05-27 09:11:23 +02:00
1 parent a07cee7ad6
commit 9d1ede0733
3 files changed
+49 -29
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/Feature/GithubSourceChangeTest.php
+8 -4
View File
@@ -109,7 +109,7 @@ describe('GitHub Source Change Component', function () {
->assertSet('webhook_endpoint', 'http://localhost:8000');
});
test('custom webhook endpoint input is used as an override for selected endpoint', function () {
test('custom webhook endpoint is selected explicitly with a checkbox', function () {
config(['app.url' => 'http://localhost:8000']);
InstanceSettings::findOrFail(0)->update([
@@ -131,12 +131,16 @@ describe('GitHub Source Change Component', function () {
Livewire::withQueryParams(['github_app_uuid' => $githubApp->uuid])
->test(Change::class)
->assertSuccessful()
->assertSet('use_custom_webhook_endpoint', false)
->set('custom_webhook_endpoint', 'https://staging.example.com')
->set('use_custom_webhook_endpoint', true)
->assertSet('webhook_endpoint', 'http://staging.example.com')
->assertSet('custom_webhook_endpoint', 'https://staging.example.com')
->assertSee('Use a custom URL only when it should override the selected endpoint.', false)
->assertSee('Custom Webhook Endpoint')
->assertSee('createGithubApp(webhookEndpoint, customWebhookEndpoint');
->assertSet('use_custom_webhook_endpoint', true)
->assertSee('Use custom webhook endpoint')
->assertSee('Selected endpoint')
->assertSee('Custom endpoint')
->assertSee('createGithubApp(webhookEndpoint, useCustomWebhookEndpoint, customWebhookEndpoint');
});
test('can mount with fully configured github app', function () {