mirror of
https://github.com/tiennm99/coolify.git
synced 2026-10-13 18:15:24 +00:00
fix(git-ref-validation): prevent command injection via git references
Add validateGitRef() helper function that uses an allowlist approach to prevent OS command injection through git commit SHAs, branch names, and tags. Only allows alphanumeric characters, dots, hyphens, underscores, and slashes. Changes include: - Add validateGitRef() helper in bootstrap/helpers/shared.php - Apply validation in Rollback component when accepting rollback commit - Add regex validation to git commit SHA fields in Livewire components - Apply regex validation to API rules for git_commit_sha - Use escapeshellarg() in git log and git checkout commands - Add comprehensive unit tests covering injection payloads Addresses GHSA-mw5w-2vvh-mgf4
This commit is contained in:
1 parent
a3e59e5c96
commit
a1c30cb0e7
8 files changed
+165
-6
No files matched your search
@@ -147,6 +147,39 @@ function validateShellSafePath(string $input, string $context = 'path'): string
|
||||
return $input;
|
||||
}
|
||||
|
||||
/**
|
||||
* Validate that a string is a safe git ref (commit SHA, branch name, tag, or HEAD).
|
||||
*
|
||||
* Prevents command injection by enforcing an allowlist of characters valid for git refs.
|
||||
* Valid: hex SHAs, HEAD, branch/tag names (alphanumeric, dots, hyphens, underscores, slashes).
|
||||
*
|
||||
* @param string $input The git ref to validate
|
||||
* @param string $context Descriptive name for error messages
|
||||
* @return string The validated input (trimmed)
|
||||
*
|
||||
* @throws \Exception If the input contains disallowed characters
|
||||
*/
|
||||
function validateGitRef(string $input, string $context = 'git ref'): string
|
||||
{
|
||||
$input = trim($input);
|
||||
|
||||
if ($input === '' || $input === 'HEAD') {
|
||||
return $input;
|
||||
}
|
||||
|
||||
// Must not start with a hyphen (git flag injection)
|
||||
if (str_starts_with($input, '-')) {
|
||||
throw new \Exception("Invalid {$context}: must not start with a hyphen.");
|
||||
}
|
||||
|
||||
// Allow only alphanumeric characters, dots, hyphens, underscores, and slashes
|
||||
if (! preg_match('/^[a-zA-Z0-9][a-zA-Z0-9._\-\/]*$/', $input)) {
|
||||
throw new \Exception("Invalid {$context}: contains disallowed characters. Only alphanumeric characters, dots, hyphens, underscores, and slashes are allowed.");
|
||||
}
|
||||
|
||||
return $input;
|
||||
}
|
||||
|
||||
function generate_readme_file(string $name, string $updated_at): string
|
||||
{
|
||||
$name = sanitize_string($name);
|
||||
|
||||
Reference in new issue
Block a user