tiennm99/coolify
1
0 Fork 0
mirror of https://github.com/tiennm99/coolify.git synced 2026-10-19 20:14:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(security): sanitize newlines in health check commands to prevent RCE (#8898)

Browse Source
This commit is contained in:
Andras Bacsai authored and GitHub committed 2026-03-11 08:57:38 +01:00
2 parents fc8f18a534 76084ce69b
commit b817ed97c1
1 file changed
+3 -2
Download Patch File Download Diff File Expand all files Collapse all files
app/Jobs/ApplicationDeploymentJob.php
+3 -2
View File
@@ -2777,9 +2777,10 @@ class ApplicationDeploymentJob implements ShouldBeEncrypted, ShouldQueue
{ {
// Handle CMD type healthcheck // Handle CMD type healthcheck
if ($this->application->health_check_type === 'cmd' && ! empty($this->application->health_check_command)) { if ($this->application->health_check_type === 'cmd' && ! empty($this->application->health_check_command)) {
$this->full_healthcheck_url = $this->application->health_check_command; $command = str_replace(["\r\n", "\r", "\n"], ' ', $this->application->health_check_command);
$this->full_healthcheck_url = $command;
return $this->application->health_check_command; return $command;
} }
// HTTP type healthcheck (default) // HTTP type healthcheck (default)