Merge remote-tracking branch 'origin/next' into 10633-invitation-link-redirect

tests/Feature/Team/TeamInvitationPrivilegeEscalationTest.php

@@ -0,0 +1,221 @@
+<?php
+
+use App\Livewire\Team\InviteLink;
+use App\Models\InstanceSettings;
+use App\Models\Team;
+use App\Models\TeamInvitation;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Livewire\Livewire;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    InstanceSettings::unguarded(fn () => InstanceSettings::query()->updateOrCreate(['id' => 0], ['fqdn' => null]));
+
+    // Create a team with owner, admin, and member
+    $this->team = Team::factory()->create();
+
+    $this->owner = User::factory()->create();
+    $this->admin = User::factory()->create();
+    $this->member = User::factory()->create();
+
+    $this->team->members()->attach($this->owner->id, ['role' => 'owner']);
+    $this->team->members()->attach($this->admin->id, ['role' => 'admin']);
+    $this->team->members()->attach($this->member->id, ['role' => 'member']);
+});
+
+describe('privilege escalation prevention', function () {
+    test('member cannot invite admin (SECURITY FIX)', function () {
+        // Login as member
+        $this->actingAs($this->member);
+        session(['currentTeam' => $this->team]);
+
+        // Attempt to invite someone as admin
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newadmin@example.com')
+            ->set('role', 'admin')
+            ->call('viaLink')
+            ->assertDispatched('error');
+    });
+
+    test('member cannot invite owner (SECURITY FIX)', function () {
+        // Login as member
+        $this->actingAs($this->member);
+        session(['currentTeam' => $this->team]);
+
+        // Attempt to invite someone as owner
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newowner@example.com')
+            ->set('role', 'owner')
+            ->call('viaLink')
+            ->assertDispatched('error');
+    });
+
+    test('admin cannot invite owner', function () {
+        // Login as admin
+        $this->actingAs($this->admin);
+        session(['currentTeam' => $this->team]);
+
+        // Attempt to invite someone as owner
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newowner@example.com')
+            ->set('role', 'owner')
+            ->call('viaLink')
+            ->assertDispatched('error');
+    });
+
+    test('admin can invite member', function () {
+        // Login as admin
+        $this->actingAs($this->admin);
+        session(['currentTeam' => $this->team]);
+
+        // Invite someone as member
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newmember@example.com')
+            ->set('role', 'member')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        // Verify invitation was created
+        $this->assertDatabaseHas('team_invitations', [
+            'email' => 'newmember@example.com',
+            'role' => 'member',
+            'team_id' => $this->team->id,
+        ]);
+    });
+
+    test('admin can invite admin', function () {
+        // Login as admin
+        $this->actingAs($this->admin);
+        session(['currentTeam' => $this->team]);
+
+        // Invite someone as admin
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newadmin@example.com')
+            ->set('role', 'admin')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        // Verify invitation was created
+        $this->assertDatabaseHas('team_invitations', [
+            'email' => 'newadmin@example.com',
+            'role' => 'admin',
+            'team_id' => $this->team->id,
+        ]);
+    });
+
+    test('owner can invite member', function () {
+        // Login as owner
+        $this->actingAs($this->owner);
+        session(['currentTeam' => $this->team]);
+
+        // Invite someone as member
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newmember@example.com')
+            ->set('role', 'member')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        // Verify invitation was created
+        $this->assertDatabaseHas('team_invitations', [
+            'email' => 'newmember@example.com',
+            'role' => 'member',
+            'team_id' => $this->team->id,
+        ]);
+    });
+
+    test('owner can invite admin', function () {
+        // Login as owner
+        $this->actingAs($this->owner);
+        session(['currentTeam' => $this->team]);
+
+        // Invite someone as admin
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newadmin@example.com')
+            ->set('role', 'admin')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        // Verify invitation was created
+        $this->assertDatabaseHas('team_invitations', [
+            'email' => 'newadmin@example.com',
+            'role' => 'admin',
+            'team_id' => $this->team->id,
+        ]);
+    });
+
+    test('owner can invite owner', function () {
+        // Login as owner
+        $this->actingAs($this->owner);
+        session(['currentTeam' => $this->team]);
+
+        // Invite someone as owner
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newowner@example.com')
+            ->set('role', 'owner')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        // Verify invitation was created
+        $this->assertDatabaseHas('team_invitations', [
+            'email' => 'newowner@example.com',
+            'role' => 'owner',
+            'team_id' => $this->team->id,
+        ]);
+    });
+
+    test('new user invitation magic link uses instance fqdn when configured', function () {
+        InstanceSettings::unguarded(fn () => InstanceSettings::query()->updateOrCreate(
+            ['id' => 0],
+            ['fqdn' => 'https://coolify.example.com']
+        ));
+
+        $this->actingAs($this->owner);
+        session(['currentTeam' => $this->team]);
+
+        Livewire::test(InviteLink::class)
+            ->set('email', 'fqdn-invitee@example.com')
+            ->set('role', 'member')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        $invitation = TeamInvitation::whereEmail('fqdn-invitee@example.com')->firstOrFail();
+
+        expect($invitation->link)->toStartWith('https://coolify.example.com/auth/link?token=');
+    });
+
+    test('new user invitation magic link falls back to route url when instance fqdn is not configured', function () {
+        InstanceSettings::unguarded(fn () => InstanceSettings::query()->updateOrCreate(
+            ['id' => 0],
+            ['fqdn' => null]
+        ));
+
+        $this->actingAs($this->owner);
+        session(['currentTeam' => $this->team]);
+
+        Livewire::test(InviteLink::class)
+            ->set('email', 'fallback-invitee@example.com')
+            ->set('role', 'member')
+            ->call('viaLink')
+            ->assertDispatched('success');
+
+        $invitation = TeamInvitation::whereEmail('fallback-invitee@example.com')->firstOrFail();
+
+        $expectedPrefix = route('auth.link', ['token' => '']);
+        expect($invitation->link)->toStartWith($expectedPrefix);
+    });
+
+    test('member cannot bypass policy by calling viaEmail', function () {
+        // Login as member
+        $this->actingAs($this->member);
+        session(['currentTeam' => $this->team]);
+
+        // Attempt to invite someone as admin via email
+        Livewire::test(InviteLink::class)
+            ->set('email', 'newadmin@example.com')
+            ->set('role', 'admin')
+            ->call('viaEmail')
+            ->assertDispatched('error');
+    });
+});