mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-10-14 12:16:54 +00:00
fix(tools): fail closed on github cli credentials (#154)
This commit is contained in:
1 parent
f077d56ea7
commit
9203782ae3
7 files changed
+160
-10
No files matched your search
@@ -0,0 +1,31 @@
|
||||
# Secure CLI GitHub Credential Runtime Fix
|
||||
|
||||
## Summary
|
||||
|
||||
Fixed GitHub-related SecureCLI auth diagnostics for `git` and `gh` runtime
|
||||
commands linked to digitopvn/goclaw#138 and digitopvn/goclaw#151.
|
||||
|
||||
## Root Cause
|
||||
|
||||
- Adapter-managed `git` remote commands could reach raw Git when no typed PAT
|
||||
or SSH credential was selected.
|
||||
- Required env validation only covered `rapidapi`, so credentialed `gh`
|
||||
commands without `GH_TOKEN` could reach raw GitHub CLI auth guidance.
|
||||
|
||||
## Changes
|
||||
|
||||
- Added fail-closed git credential readiness validation before adapter prepare.
|
||||
- Generalized required env checks to preset non-optional env vars.
|
||||
- Added regression tests for missing git typed credentials and missing
|
||||
`GH_TOKEN`.
|
||||
- Updated git adapter docs and project changelog.
|
||||
|
||||
## Validation
|
||||
|
||||
- `/usr/local/go/bin/go test ./internal/tools`
|
||||
- `/usr/local/go/bin/go build ./...`
|
||||
- `/usr/local/go/bin/go build -tags sqliteonly ./...`
|
||||
|
||||
## Unresolved Questions
|
||||
|
||||
None.
|
||||
Reference in new issue
Block a user