diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f2e0af46..075f2a6f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,6 +12,28 @@ permissions: jobs: go: runs-on: ubuntu-latest + # Postgres service container for integration tests. pgvector/pgvector:pg18 + # matches the local dev image (Makefile uses the same tag on port 5433). + # Healthcheck blocks the job until PG accepts connections, avoiding + # first-connection flakiness on cold runner starts. + services: + pg: + image: pgvector/pgvector:pg18 + env: + POSTGRES_PASSWORD: test + POSTGRES_DB: goclaw_test + ports: + - 5432:5432 + options: >- + --health-cmd "pg_isready -U postgres" + --health-interval 5s + --health-timeout 3s + --health-retries 10 + env: + # tests/integration/v3_test_helper.go reads TEST_DATABASE_URL and runs + # migrations once via golang-migrate. Uses port 5432 (CI-clean) vs 5433 + # for local dev (avoids clash with desktop Postgres installs). + TEST_DATABASE_URL: postgres://postgres:test@localhost:5432/goclaw_test?sslmode=disable steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 @@ -24,7 +46,14 @@ jobs: # -timeout=90s caps each test binary so a deadlocked test fails fast # instead of blocking CI for the 10-minute default. Race-heavy wave C # suites run in <20s, so 90s leaves ample breathing room. - - run: go test -race -timeout=90s -coverpkg=./... -coverprofile=coverage.out ./... + - name: Unit tests + run: go test -race -timeout=90s -coverpkg=./... -coverprofile=coverage.out ./... + # Integration suite runs against the `pg` service container above. + # Longer -timeout=180s because the first test runs migrations from + # scratch (can take 10-30s on a cold CI runner). Local full suite + # completes in <3s against a warm DB. + - name: Integration tests + run: go test -race -timeout=180s -tags integration ./tests/integration/ - name: Coverage summary run: go tool cover -func=coverage.out | tail -1 diff --git a/tests/integration/v3_test_helper.go b/tests/integration/v3_test_helper.go index 0c620787..66062546 100644 --- a/tests/integration/v3_test_helper.go +++ b/tests/integration/v3_test_helper.go @@ -16,6 +16,7 @@ import ( _ "github.com/jackc/pgx/v5/stdlib" "github.com/nextlevelbuilder/goclaw/internal/store" + "github.com/nextlevelbuilder/goclaw/internal/store/pg" ) const defaultTestDSN = "postgres://postgres:test@localhost:5433/goclaw_test?sslmode=disable" @@ -58,6 +59,13 @@ func testDB(t *testing.T) *sql.DB { return } m.Close() + + // Initialize pg package's sqlx wrapper. Without this, any store + // method that uses pkgSqlxDB.SelectContext panics on nil deref if + // the test runs before any other test happens to call InitSqlx. + // Centralizing here removes the ordering-dependency land mine. + pg.InitSqlx(db) + sharedDB = db })