Final step of Phase 4: rename the silently-nil-on-error helper so its
behavior is self-documenting at the call site. No behavior change — all
remaining call sites (~24) were already classified as WARN-acceptable
(read-only SELECT WHERE paths with validated inputs from cursor
pagination or WS boundary) during sub-step 4b migration.
The parseUUID error variant stays as-is for CRITICAL writes.
Also cleans up a now-stale comment in vault_handler_upload.go.
Phase 4 Step 4d of agent identity hardening (TD-1).
Two new helpers alongside existing mustParseUUID:
- parseUUID(s) (uuid.UUID, error) — use for INSERT/UPDATE/UPSERT/DELETE
and SELECT-WHERE paths where silent nil hides bugs. Returns a wrapped
error that includes the raw value (for debuggability) and the
underlying uuid parse error (for errors.Is unwrap).
- parseUUIDOrNil(s) uuid.UUID — intentionally silent, for read-only
SELECT-WHERE paths where empty result is acceptable.
mustParseUUID is kept as a transitional alias delegating to parseUUIDOrNil
so existing call sites compile unchanged. Sub-step 4d will rename it.
Phase 4 Step 4a of agent identity hardening (TD-1).
viettranx