mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-10-14 06:17:41 +00:00
dc605b911e
* feat(mcp): expand CRUD MCP server to near-complete CLI parity Closes the CLI-vs-MCP tool coverage gap identified by auditing every `goclaw` CLI command against the existing goclaw_* MCP tool set. Adds skill grant/revoke, agent skill pin/unpin, and full CRUD/inspection surfaces for memory, knowledge graph (including dedup/merge/prune), tenants, providers, LLM traces, channel contacts, pending messages, audit activity, system config, tenant storage (list/size/delete/move), scoped agent config export/import, secure-CLI binary registry, and a DB-backed health check. Deliberately out of scope, documented inline where relevant: - `goclaw credentials`: confirmed CLI-local (~/.goclaw/config.yaml + keychain), no server resource to wrap. goclaw_secure_cli_binaries_* covers the closest real, previously-uncovered server resource instead. - Full tar-archive agent export/import (KG + workspace files): the CLI's version streams a multi-section archive with progress events, a shape that doesn't map to a single MCP tool call. Config + context files (the portable "brain") is covered. - `kg extract` (LLM-driven text extraction): goclaw_kg_ingest accepts the same Entity/Relation shapes the extractor produces, so a caller can run extraction itself and hand off the result. Wires 8 new store dependencies (Memory, KnowledgeGraph, Tracing, Contacts, PendingMessages, Activity, SystemConfigs, SecureCLI) through gateway.Server setters -> cmd/gateway.go -> CRUDDeps, following the existing Providers/Tenants pattern. Storage and secure-CLI-binary handlers duplicate internal/http's path-escape/symlink-hiding validation logic (documented inline) since internal/http already imports internal/mcp and the reverse would cycle. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(mcp): return sessionKey in goclaw_chat_send response for persistent conversations The goclaw_chat_send tool creates a new session internally when sessionKey is empty, but never returned the key to the caller. This prevented using goclaw_chat_history to fetch previous messages in the session. Add SessionKey field to ChatSendResult so callers can: 1. Start a new agent chat without providing sessionKey 2. Receive the sessionKey back in the response 3. Use that sessionKey for follow-up messages and history queries Fixes the training loop pattern: start chat → get sessionKey → call goclaw_chat_history with that key → iterate skill based on actual failures. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * feat(mcp): add timing diagnostics to goclaw_chat_send for timeout troubleshooting Log request arrival, processing duration, and errors with millisecond precision. Helps identify whether timeouts occur at MCP client→goclaw, goclaw→ollama, or during agent execution. Critical for production debugging. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix(gateway): add http.Server timeouts for defensive timeout handling Set explicit timeouts in http.Server: - ReadTimeout: 1h (allow large uploads, long-running agent operations) - WriteTimeout: 1h (allow streaming responses to slow clients) - IdleTimeout: 30s (close idle keep-alive connections quickly) Provides defense-in-depth when Nginx/Traefik timeouts are misconfigured. Matches Nginx timeout (3600s) to prevent race conditions. Timeout chain: traefik 3600s = nginx 3600s = goclaw 3600s Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> --------- Co-authored-by: Bruno Clermont <bruno.clermont@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
52 lines
2.2 KiB
Go
52 lines
2.2 KiB
Go
package mcp
|
|
|
|
import (
|
|
"context"
|
|
|
|
mcpgo "github.com/mark3labs/mcp-go/mcp"
|
|
mcpserver "github.com/mark3labs/mcp-go/server"
|
|
|
|
"github.com/nextlevelbuilder/goclaw/internal/store"
|
|
)
|
|
|
|
// registerActivityCRUDTools registers goclaw_activity_list, backed by
|
|
// store.ActivityStore — closes a CLI-vs-MCP coverage gap (`goclaw activity
|
|
// list`, the audit log of admin/agent actions emitted via emitAudit
|
|
// throughout internal/http).
|
|
func registerActivityCRUDTools(srv *mcpserver.MCPServer, activity store.ActivityStore) {
|
|
srv.AddTool(mcpgo.NewTool("goclaw_activity_list",
|
|
mcpgo.WithDescription("List audit log entries (admin/agent actions), optionally filtered."),
|
|
mcpgo.WithString("actor_type", mcpgo.Description("Filter by actor type (e.g. \"user\", \"agent\", \"system\").")),
|
|
mcpgo.WithString("actor_id", mcpgo.Description("Filter by actor ID.")),
|
|
mcpgo.WithString("action", mcpgo.Description("Filter by action name (e.g. \"skill.file_updated\").")),
|
|
mcpgo.WithString("entity_type", mcpgo.Description("Filter by entity type (e.g. \"skill\", \"agent\").")),
|
|
mcpgo.WithString("entity_id", mcpgo.Description("Filter by entity ID.")),
|
|
mcpgo.WithNumber("limit", mcpgo.Description("Maximum entries to return; defaults to 50.")),
|
|
mcpgo.WithNumber("offset", mcpgo.Description("Pagination offset.")),
|
|
mcpgo.WithReadOnlyHintAnnotation(true),
|
|
), handleActivityList(activity))
|
|
}
|
|
|
|
func handleActivityList(activity store.ActivityStore) mcpserver.ToolHandlerFunc {
|
|
return func(ctx context.Context, req mcpgo.CallToolRequest) (*mcpgo.CallToolResult, error) {
|
|
opts := store.ActivityListOpts{
|
|
ActorType: req.GetString("actor_type", ""),
|
|
ActorID: req.GetString("actor_id", ""),
|
|
Action: req.GetString("action", ""),
|
|
EntityType: req.GetString("entity_type", ""),
|
|
EntityID: req.GetString("entity_id", ""),
|
|
Limit: intArg(req, "limit", 50),
|
|
Offset: intArg(req, "offset", 0),
|
|
}
|
|
list, err := activity.List(ctx, opts)
|
|
if err != nil {
|
|
return toolError("activity.list", err)
|
|
}
|
|
total, err := activity.Count(ctx, opts)
|
|
if err != nil {
|
|
return toolError("activity.list", err)
|
|
}
|
|
return jsonToolResult(map[string]any{"entries": list, "total": total})
|
|
}
|
|
}
|