mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-10-14 20:17:20 +00:00
* feat(mcp): expand CRUD MCP server to near-complete CLI parity Closes the CLI-vs-MCP tool coverage gap identified by auditing every `goclaw` CLI command against the existing goclaw_* MCP tool set. Adds skill grant/revoke, agent skill pin/unpin, and full CRUD/inspection surfaces for memory, knowledge graph (including dedup/merge/prune), tenants, providers, LLM traces, channel contacts, pending messages, audit activity, system config, tenant storage (list/size/delete/move), scoped agent config export/import, secure-CLI binary registry, and a DB-backed health check. Deliberately out of scope, documented inline where relevant: - `goclaw credentials`: confirmed CLI-local (~/.goclaw/config.yaml + keychain), no server resource to wrap. goclaw_secure_cli_binaries_* covers the closest real, previously-uncovered server resource instead. - Full tar-archive agent export/import (KG + workspace files): the CLI's version streams a multi-section archive with progress events, a shape that doesn't map to a single MCP tool call. Config + context files (the portable "brain") is covered. - `kg extract` (LLM-driven text extraction): goclaw_kg_ingest accepts the same Entity/Relation shapes the extractor produces, so a caller can run extraction itself and hand off the result. Wires 8 new store dependencies (Memory, KnowledgeGraph, Tracing, Contacts, PendingMessages, Activity, SystemConfigs, SecureCLI) through gateway.Server setters -> cmd/gateway.go -> CRUDDeps, following the existing Providers/Tenants pattern. Storage and secure-CLI-binary handlers duplicate internal/http's path-escape/symlink-hiding validation logic (documented inline) since internal/http already imports internal/mcp and the reverse would cycle. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(mcp): return sessionKey in goclaw_chat_send response for persistent conversations The goclaw_chat_send tool creates a new session internally when sessionKey is empty, but never returned the key to the caller. This prevented using goclaw_chat_history to fetch previous messages in the session. Add SessionKey field to ChatSendResult so callers can: 1. Start a new agent chat without providing sessionKey 2. Receive the sessionKey back in the response 3. Use that sessionKey for follow-up messages and history queries Fixes the training loop pattern: start chat → get sessionKey → call goclaw_chat_history with that key → iterate skill based on actual failures. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * feat(mcp): add timing diagnostics to goclaw_chat_send for timeout troubleshooting Log request arrival, processing duration, and errors with millisecond precision. Helps identify whether timeouts occur at MCP client→goclaw, goclaw→ollama, or during agent execution. Critical for production debugging. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix(gateway): add http.Server timeouts for defensive timeout handling Set explicit timeouts in http.Server: - ReadTimeout: 1h (allow large uploads, long-running agent operations) - WriteTimeout: 1h (allow streaming responses to slow clients) - IdleTimeout: 30s (close idle keep-alive connections quickly) Provides defense-in-depth when Nginx/Traefik timeouts are misconfigured. Matches Nginx timeout (3600s) to prevent race conditions. Timeout chain: traefik 3600s = nginx 3600s = goclaw 3600s Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> --------- Co-authored-by: Bruno Clermont <bruno.clermont@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
94 lines
3.4 KiB
Go
94 lines
3.4 KiB
Go
package mcp
|
|
|
|
import (
|
|
"context"
|
|
|
|
mcpgo "github.com/mark3labs/mcp-go/mcp"
|
|
mcpserver "github.com/mark3labs/mcp-go/server"
|
|
|
|
"github.com/nextlevelbuilder/goclaw/internal/store"
|
|
)
|
|
|
|
// registerSystemConfigCRUDTools registers the goclaw_system_config_* MCP
|
|
// tools backed by store.SystemConfigStore — closes a CLI-vs-MCP coverage
|
|
// gap (`goclaw system-config list`, plus set/delete which the CLI reference
|
|
// didn't surface but the store supports).
|
|
func registerSystemConfigCRUDTools(srv *mcpserver.MCPServer, cfg store.SystemConfigStore) {
|
|
srv.AddTool(mcpgo.NewTool("goclaw_system_config_list",
|
|
mcpgo.WithDescription("List all system config key/value pairs visible to the current tenant (master merged with tenant overrides)."),
|
|
mcpgo.WithReadOnlyHintAnnotation(true),
|
|
), handleSystemConfigList(cfg))
|
|
|
|
srv.AddTool(mcpgo.NewTool("goclaw_system_config_get",
|
|
mcpgo.WithDescription("Get a single system config value by key."),
|
|
mcpgo.WithString("key", mcpgo.Required(), mcpgo.Description("Config key.")),
|
|
mcpgo.WithReadOnlyHintAnnotation(true),
|
|
), handleSystemConfigGet(cfg))
|
|
|
|
srv.AddTool(mcpgo.NewTool("goclaw_system_config_set",
|
|
mcpgo.WithDescription("Set a system config value for the current tenant."),
|
|
mcpgo.WithString("key", mcpgo.Required(), mcpgo.Description("Config key.")),
|
|
mcpgo.WithString("value", mcpgo.Required(), mcpgo.Description("Config value.")),
|
|
), handleSystemConfigSet(cfg))
|
|
|
|
srv.AddTool(mcpgo.NewTool("goclaw_system_config_delete",
|
|
mcpgo.WithDescription("Delete a system config value for the current tenant."),
|
|
mcpgo.WithString("key", mcpgo.Required(), mcpgo.Description("Config key.")),
|
|
mcpgo.WithDestructiveHintAnnotation(true),
|
|
), handleSystemConfigDelete(cfg))
|
|
}
|
|
|
|
func handleSystemConfigList(cfg store.SystemConfigStore) mcpserver.ToolHandlerFunc {
|
|
return func(ctx context.Context, _ mcpgo.CallToolRequest) (*mcpgo.CallToolResult, error) {
|
|
all, err := cfg.List(ctx)
|
|
if err != nil {
|
|
return toolError("system_config.list", err)
|
|
}
|
|
return jsonToolResult(all)
|
|
}
|
|
}
|
|
|
|
func handleSystemConfigGet(cfg store.SystemConfigStore) mcpserver.ToolHandlerFunc {
|
|
return func(ctx context.Context, req mcpgo.CallToolRequest) (*mcpgo.CallToolResult, error) {
|
|
key, err := req.RequireString("key")
|
|
if err != nil {
|
|
return toolError("system_config.get", err)
|
|
}
|
|
value, err := cfg.Get(ctx, key)
|
|
if err != nil {
|
|
return toolError("system_config.get", err)
|
|
}
|
|
return jsonToolResult(map[string]string{"key": key, "value": value})
|
|
}
|
|
}
|
|
|
|
func handleSystemConfigSet(cfg store.SystemConfigStore) mcpserver.ToolHandlerFunc {
|
|
return func(ctx context.Context, req mcpgo.CallToolRequest) (*mcpgo.CallToolResult, error) {
|
|
key, err := req.RequireString("key")
|
|
if err != nil {
|
|
return toolError("system_config.set", err)
|
|
}
|
|
value, err := req.RequireString("value")
|
|
if err != nil {
|
|
return toolError("system_config.set", err)
|
|
}
|
|
if err := cfg.Set(ctx, key, value); err != nil {
|
|
return toolError("system_config.set", err)
|
|
}
|
|
return jsonToolResult(map[string]string{"ok": "true"})
|
|
}
|
|
}
|
|
|
|
func handleSystemConfigDelete(cfg store.SystemConfigStore) mcpserver.ToolHandlerFunc {
|
|
return func(ctx context.Context, req mcpgo.CallToolRequest) (*mcpgo.CallToolResult, error) {
|
|
key, err := req.RequireString("key")
|
|
if err != nil {
|
|
return toolError("system_config.delete", err)
|
|
}
|
|
if err := cfg.Delete(ctx, key); err != nil {
|
|
return toolError("system_config.delete", err)
|
|
}
|
|
return jsonToolResult(map[string]string{"ok": "true"})
|
|
}
|
|
}
|