mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-10-12 20:15:42 +00:00
viettranx
0c44149fad
Slow tests were dominating CI feedback time and AI dev loop because they waited through real exponential backoffs and 1s ticker intervals. Test-only override pattern keeps production behavior 100% identical. Speed wins (no-race wall-clock per package): - internal/vault 16.3s -> 0.6s (-15.7s) - internal/cron 11.7s -> 1.5s (-10.2s) - internal/channels/facebook 6.3s -> 3.0s (-3.3s) - Full -race ./... suite 90s+ -> 51s Changes: - vault: new fastBackoffsForTest(t) helper overrides enrichRetryBackoffs + enrichRetryTimeouts to 1ms in 3 retry tests; drop 2 duplicate tests (FirstAttemptSuccess, MaxRetriesConstant) - cron: extract runLoopTickInterval as package var (default 1s); test-only setFastTick(t) helper shortens to 20ms so 6 scheduler tests no longer sleep 1.5s each waiting for a tick - facebook: extract graphBackoffBase as package var (default 1s); newFakeGraph helper shortens to 1ms so HTTP retry tests don't burn 6s of real waits Coverage ratchet removed: - Delete scripts/check_coverage.go + scripts/coverage_thresholds.json - Remove "Coverage ratchet gate" CI step - Keep coverage profile + go tool cover summary as informational only - Philosophy: signal over coverage %. Forced tests to bump % were the root cause of the slowness this commit unwinds. Production behavior unchanged. Coverage profile shows isolated package coverage matches prior thresholds (vault 27.4%, cron 73.7%, facebook 81.9%).
30 lines
1.1 KiB
Go
30 lines
1.1 KiB
Go
package vault
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// fastBackoffsForTest overrides the package-level enrichRetryBackoffs and
|
|
// enrichRetryTimeouts arrays so retry tests don't wait through the real
|
|
// exponential backoff (default {0, 2s, 4s} = 6 seconds per all-retry test).
|
|
//
|
|
// Production behavior is 100% unchanged — only the test sees the fast values.
|
|
// Original values are restored via t.Cleanup so parallel/sequential tests
|
|
// remain isolated.
|
|
//
|
|
// Use in any test that exercises callClassifyWithRetry / chatWithRetry with
|
|
// >1 attempt. Do NOT use in tests that explicitly assert on the default
|
|
// values (e.g. TestCallClassifyWithRetry_RetriesAndBackoffs).
|
|
func fastBackoffsForTest(t *testing.T) {
|
|
t.Helper()
|
|
savedBackoffs := enrichRetryBackoffs
|
|
savedTimeouts := enrichRetryTimeouts
|
|
enrichRetryBackoffs = [enrichMaxRetries]time.Duration{0, time.Millisecond, time.Millisecond}
|
|
enrichRetryTimeouts = [enrichMaxRetries]time.Duration{time.Second, time.Second, time.Second}
|
|
t.Cleanup(func() {
|
|
enrichRetryBackoffs = savedBackoffs
|
|
enrichRetryTimeouts = savedTimeouts
|
|
})
|
|
}
|