Files
goclaw/internal/agent/prompt_builder_orchestration_test.go
T
Duc Nguyenandntduc bb7712a9ff fix(collaboration): harden delegated task isolation (#1486)
* feat(collaboration): isolate delegated artifacts and child runs

Isolate delegated inputs and outputs behind secure artifact exchange lifecycles. Scope Agent Link tasks by tenant and root agent, and enforce delegation spawn-tree boundaries. Add process-wide child-run admission and preserve logical media paths across native, MCP, and sandbox execution.

* fix(collaboration): harden delegated task isolation

Enforce tenant and root-agent task scope across migrations and stores. Add exactly-once async completion delivery, delegated sandbox boundaries, and confined artifact and media recovery across runtime surfaces.

* fix(collaboration): recover interrupted async tasks

* fix(collaboration): normalize persisted child-run status

---------

Co-authored-by: ntduc <ntduc@cpp.ai.vn>
2026-07-30 14:17:40 +07:00

121 lines
3.3 KiB
Go

package agent
import (
"strings"
"testing"
)
func TestBridgePromptBuilder_OrchestrationSection(t *testing.T) {
builder := NewBridgePromptBuilder()
tests := []struct {
name string
cfg PromptConfig
wantContain string
wantAbsent bool
}{
{
name: "orchestration enabled with targets",
cfg: PromptConfig{
Identity: true,
IdentityData: IdentityData{AgentName: "test-agent"},
Orchestration: true,
OrchestrationData: OrchestrationSectionData{
Mode: ModeDelegate,
DelegateTargets: []DelegateTargetEntry{
{AgentKey: "helper", DisplayName: "Helper Bot", Description: "Helps with tasks"},
{AgentKey: "coder", DisplayName: "Coder", Description: "Writes code"},
},
},
},
wantContain: "## Delegation Targets",
},
{
name: "orchestration enabled but no targets",
cfg: PromptConfig{
Identity: true,
IdentityData: IdentityData{AgentName: "test-agent"},
Orchestration: true,
OrchestrationData: OrchestrationSectionData{
Mode: ModeDelegate,
},
},
wantContain: "Delegation Targets",
wantAbsent: true,
},
{
name: "orchestration disabled",
cfg: PromptConfig{
Identity: true,
IdentityData: IdentityData{AgentName: "test-agent"},
},
wantContain: "Delegation Targets",
wantAbsent: true,
},
{
name: "spawn mode skips section",
cfg: PromptConfig{
Identity: true,
IdentityData: IdentityData{AgentName: "test-agent"},
Orchestration: true,
OrchestrationData: OrchestrationSectionData{
Mode: ModeSpawn,
DelegateTargets: []DelegateTargetEntry{{AgentKey: "x"}},
},
},
wantContain: "Delegation Targets",
wantAbsent: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
output, err := builder.Build(tt.cfg)
if err != nil {
t.Fatalf("Build error: %v", err)
}
found := strings.Contains(output, tt.wantContain)
if tt.wantAbsent && found {
t.Errorf("output should NOT contain %q", tt.wantContain)
}
if !tt.wantAbsent && !found {
t.Errorf("output should contain %q", tt.wantContain)
}
})
}
}
func TestBridgePromptBuilder_OrchestrationTargetContent(t *testing.T) {
builder := NewBridgePromptBuilder()
cfg := PromptConfig{
Identity: true,
IdentityData: IdentityData{AgentName: "lead"},
Orchestration: true,
OrchestrationData: OrchestrationSectionData{
Mode: ModeDelegate,
DelegateTargets: []DelegateTargetEntry{
{AgentKey: "worker-1", DisplayName: "Worker One", Description: "Does work"},
},
},
}
output, err := builder.Build(cfg)
if err != nil {
t.Fatalf("Build error: %v", err)
}
if !strings.Contains(output, "worker-1") {
t.Error("output should contain agent key 'worker-1'")
}
if !strings.Contains(output, "Worker One") {
t.Error("output should contain display name")
}
if !strings.Contains(output, "Does work") {
t.Error("output should contain description")
}
if !strings.Contains(output, "Return generated files or media artifacts to the caller") {
t.Error("output should tell delegates to return media artifacts through the caller")
}
if !strings.Contains(output, "Do not ask the delegatee to send directly to your current chat") {
t.Error("output should prevent direct delivery attempts from the delegate channel")
}
}