Simplify code

- Use bytes.Equal instead of bytes.Compare
- Omit range's value where it's unused
This commit is contained in:
Christian Muehlhaeuser authored and Bjørn Erik Pedersen committed 2019-08-10 20:10:32 +02:00
1 parent bd98182dbd
commit a93cbb0d6c
2 files changed
+4 -4

No files matched your search

+1 -1
View File
@@ -45,7 +45,7 @@ func TestTrimShortHTML(t *testing.T) {
c := newTestContentSpec() c := newTestContentSpec()
for i, test := range tests { for i, test := range tests {
output := c.TrimShortHTML(test.input) output := c.TrimShortHTML(test.input)
if bytes.Compare(test.output, output) != 0 { if !bytes.Equal(test.output, output) {
t.Errorf("Test %d failed. Expected %q got %q", i, test.output, output) t.Errorf("Test %d failed. Expected %q got %q", i, test.output, output)
} }
} }
+3 -3
View File
@@ -512,7 +512,7 @@ func (t *htmlTemplates) addTemplateIn(tt *template.Template, name, tpl string) (
return nil, err return nil, err
} }
for k, _ := range c.notFound { for k := range c.notFound {
t.transformNotFound[k] = true t.transformNotFound[k] = true
} }
@@ -580,7 +580,7 @@ func (t *textTemplates) addTemplateIn(tt *texttemplate.Template, name, tpl strin
return nil, err return nil, err
} }
for k, _ := range c.notFound { for k := range c.notFound {
t.transformNotFound[k] = true t.transformNotFound[k] = true
} }
@@ -637,7 +637,7 @@ func (t *templateHandler) postTransform() error {
return templT.Tree return templT.Tree
}, t.text.transformNotFound}, }, t.text.transformNotFound},
} { } {
for name, _ := range s.transformNotFound { for name := range s.transformNotFound {
templ := s.lookup(name) templ := s.lookup(name)
if templ != nil { if templ != nil {
_, err := applyTemplateTransformers(templateUndefined, templ, s.lookup) _, err := applyTemplateTransformers(templateUndefined, templ, s.lookup)