update ava version, migrate to gacts/install-dnscontrol and use lockfiles

tests/domains.test.js

@@ -1,6 +1,6 @@
-const t = require("ava");
-const fs = require("fs-extra");
-const path = require("path");
+import t from "ava";
+import fs from "fs-extra";
+import path from "path";
 
 const domainsPath = path.resolve("domains");
 const files = fs.readdirSync(domainsPath).filter((file) => file.endsWith(".json"));

tests/json.test.js

@@ -1,6 +1,9 @@
-const t = require("ava");
-const fs = require("fs-extra");
-const path = require("path");
+import t from "ava";
+import fs from "fs-extra";
+import path from "path";
+
+import internalDomains from "../util/internal.json" with { type: "json" };
+import reservedDomains from "../util/reserved.json" with { type: "json" };
 
 const ignoredRootJSONFiles = ["package-lock.json", "package.json"];
 
@@ -32,9 +35,6 @@ const blockedFields = ["domain", "internal", "proxy", "reserved", "services", "s
 const emailRegex = /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/;
 const hostnameRegex = /^(?=.{1,253}$)(?:(?:[_a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)\.)+[a-zA-Z]{2,63}$/;
 
-const internalDomains = require("../util/internal.json");
-const reservedDomains = require("../util/reserved.json");
-
 const domainsPath = path.resolve("domains");
 const files = fs.readdirSync(domainsPath);
 

tests/pr.test.js

@@ -1,9 +1,10 @@
-const t = require("ava");
-const fs = require("fs-extra");
-const path = require("path");
+import t from "ava";
+import fs from "fs-extra";
+import path from "path";
+
+import trustedUsers from "../util/trusted.json" with { type: "json" };
 
 const requiredEnvVars = ["PR_AUTHOR", "PR_AUTHOR_ID"];
-const trustedUsers = require("../util/trusted.json");
 
 const trusted = trustedUsers.map((u) => u.id.toString());
 const admins = trustedUsers.filter((u) => u.admin).map((u) => u.id.toString());

tests/proxy.test.js

@@ -1,6 +1,6 @@
-const t = require("ava");
-const fs = require("fs-extra");
-const path = require("path");
+import t from "ava";
+import fs from "fs-extra";
+import path from "path";
 
 const requiredRecordsToProxy = new Set(["A", "AAAA", "CNAME"]);
 

tests/records.test.js

@@ -1,6 +1,8 @@
-const t = require("ava");
-const fs = require("fs-extra");
-const path = require("path");
+import t from "ava";
+import fs from "fs-extra";
+import path from "path";
+
+import disallowedCNAMEs from "../util/disallowed-cnames.json" with { type: "json" };
 
 const validRecordTypes = new Set(["A", "AAAA", "CAA", "CNAME", "DS", "MX", "NS", "SRV", "TLSA", "TXT", "URL"]);
 const hostnameRegex = /^(?=.{1,253}$)(?:(?:[_a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)\.)+[a-zA-Z]{2,63}$/;
@@ -88,8 +90,6 @@ function isValidHexadecimal(value) {
     return /^[0-9a-fA-F]+$/.test(value);
 }
 
-const disallowedCNAMEs = require("../util/disallowed-cnames.json");
-
 function validateRecordValues(t, data, file) {
     const subdomain = file.replace(/\.json$/, "");