From f76dda07f0f877bdc6dd16160ffb2de658b4a645 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Wed, 17 Jan 2024 09:36:55 +0800 Subject: [PATCH 1/4] feat(validation): gitlab verification --- tests/validations.test.js | 2 ++ utils/invalid-domains.json | 1 + utils/validations.js | 1 + 3 files changed, 4 insertions(+) diff --git a/tests/validations.test.js b/tests/validations.test.js index a07ccf6fa1..1726affaea 100644 --- a/tests/validations.test.js +++ b/tests/validations.test.js @@ -64,6 +64,7 @@ describe('validateDomainData', () => { { ...defaultDomain, record: { AAAA: '182.22.222.22' } }, { ...defaultDomain, record: { A: '::1' } }, { ...defaultDomain, name: '_discord' }, + { ...defaultDomain, name: '_gitlab-pages-verification-code' }, ]; const validCases = [ @@ -94,6 +95,7 @@ describe('validateDomainData', () => { { ...defaultDomain, record: { AAAA: ['::1', '2001:db8:3333:4444:5555:6666:7777:8888'] } }, { ...defaultDomain, record: { A: ['122.222.222.222'] } }, { ...defaultDomain, name: '_discord.subdomain' }, + { ...defaultDomain, name: '_gitlab-pages-verification-code.subdomain' }, ]; it('should return false for invalid data', () => { diff --git a/utils/invalid-domains.json b/utils/invalid-domains.json index ef66a55178..3a5369df56 100644 --- a/utils/invalid-domains.json +++ b/utils/invalid-domains.json @@ -2,6 +2,7 @@ "_acme-challenge", "_github-challenge-is-a-dev", "_github-pages-challenge-is-a-dev", + "_gitlab-pages-verification-code", "help", "no-reply", "noreply", diff --git a/utils/validations.js b/utils/validations.js index b9c851a19e..c7cdd7e16e 100644 --- a/utils/validations.js +++ b/utils/validations.js @@ -39,6 +39,7 @@ const checkRestrictedNames = R.complement(R.includes(R.__, INVALID_NAMES)) const extraSupportedNames = [ testRegex(/^_github(-pages)?-challenge-[a-z0-9-_]+$/i), // Exception for github verification records R.equals('_discord'), + R.equals('_gitlab-pages-verification-code'), ] const validateDomainData = validate({ From 7a043a65d3f7a1069482427d014e0ac79d8af1b9 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Wed, 17 Jan 2024 09:39:05 +0800 Subject: [PATCH 2/4] Create _gitlab-pages-verification-code.meerkats.shays.json --- .../_gitlab-pages-verification-code.meerkats.shays.json | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 domains/_gitlab-pages-verification-code.meerkats.shays.json diff --git a/domains/_gitlab-pages-verification-code.meerkats.shays.json b/domains/_gitlab-pages-verification-code.meerkats.shays.json new file mode 100644 index 0000000000..f16d84749f --- /dev/null +++ b/domains/_gitlab-pages-verification-code.meerkats.shays.json @@ -0,0 +1,9 @@ +{ + "owner": { + "username": "SHays24", + "email": "SHays24@student.sacs.nsw.edu.au" + }, + "record": { + "TXT": "gitlab-pages-verification-code=ae094773869d07be976fc107f5548311" + } +} From d4cf9a01940dd4c443586dcfba7c7f43261ee821 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Wed, 17 Jan 2024 09:40:05 +0800 Subject: [PATCH 3/4] Update and rename _gitlab-pages-verification-code.meerkats.shays.json to _gitlab-pages-verification-code.json --- ...meerkats.shays.json => _gitlab-pages-verification-code.json} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename domains/{_gitlab-pages-verification-code.meerkats.shays.json => _gitlab-pages-verification-code.json} (61%) diff --git a/domains/_gitlab-pages-verification-code.meerkats.shays.json b/domains/_gitlab-pages-verification-code.json similarity index 61% rename from domains/_gitlab-pages-verification-code.meerkats.shays.json rename to domains/_gitlab-pages-verification-code.json index f16d84749f..93ca0a4f1b 100644 --- a/domains/_gitlab-pages-verification-code.meerkats.shays.json +++ b/domains/_gitlab-pages-verification-code.json @@ -4,6 +4,6 @@ "email": "SHays24@student.sacs.nsw.edu.au" }, "record": { - "TXT": "gitlab-pages-verification-code=ae094773869d07be976fc107f5548311" + "TXT": "gitlab-pages-verification-code=testing123456" } } From c1f3e6a0088b154d840312088d002e5217538c48 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Wed, 17 Jan 2024 09:40:44 +0800 Subject: [PATCH 4/4] Discard changes to domains/_gitlab-pages-verification-code.json --- domains/_gitlab-pages-verification-code.json | 9 --------- 1 file changed, 9 deletions(-) delete mode 100644 domains/_gitlab-pages-verification-code.json diff --git a/domains/_gitlab-pages-verification-code.json b/domains/_gitlab-pages-verification-code.json deleted file mode 100644 index 93ca0a4f1b..0000000000 --- a/domains/_gitlab-pages-verification-code.json +++ /dev/null @@ -1,9 +0,0 @@ -{ - "owner": { - "username": "SHays24", - "email": "SHays24@student.sacs.nsw.edu.au" - }, - "record": { - "TXT": "gitlab-pages-verification-code=testing123456" - } -}