diff --git a/docs/maintainers/pr-review.md b/docs/maintainers/pr-review.md index 2737754bd7..0af094676f 100644 --- a/docs/maintainers/pr-review.md +++ b/docs/maintainers/pr-review.md @@ -1,6 +1,7 @@ # Reviewing pull requests There are a few things you'll need to look out for when reviewing pull requests for domain registrations. This list is not exhaustive and will be updated. +--- ### CI errors A lot of minor issues will be caught in the CI checks @@ -9,24 +10,63 @@ A lot of minor issues will be caught in the CI checks If the CI is failing, tag the user and comment on the pr. +--- + +### Contents of the website +We need to make sure that the contents being hosted via the record being registered is used for malicious purposes. +To do this, we must try our best to verify the contents of website and if required ask some questions regarding the contents in the PR. + +--- ### Invalid email/social link A way to contact the user is important in case we need to inform the users of some changes to the project. Confirm if the email looks valid or the social user name/link works. The user should have either an email or a valid social link. +❌ `"owner": { "username": "gh-username" }` is invalid as it doesn't contain an email or any social links + +❌ `"email": "28372878+user-name@users.noreply.github.com"` is invalid as the email cannot be used + +✅ `"owner": { "username": "phenax", "twitter": "twitter-username" }` is valid as it contains a social link + +✅ `"owner": { "username": "phenax", "email": "email@gmail.com" }` is valid as it contains an email + +--- ### Invalid CNAME -CNAME has to be a hostname. Something like 'example.com'. -People tend to accidentally put a url there instead sometimes like `http://something.com` or `something.com/path`. -Both of those are invalid. +CNAME has to be a hostname. Something like `example.com`. +❌ `http://example.com` is invalid as it contains a protocol `https://` + +❌ `example.com/some/path` is invalid as it contains the path name `/some/path` + +✅ `example.com` is valid as it is the hostname of the website + +--- ### Invalid A -A record has to be an array of ips +A record has to be an array of ips. +❌ `"A": "211.211.211.211"` is invalid as it must be an array + +❌ `"A": ["example.com"]` is invalid as it is not an ip address + +✅ `"A": ["211.211.211.211", "211.211.211.212"]` is valid as it is an array of ips + +--- + +### Invalid URL +The URL must have a protocol (`http://` or `https://`) and must be something like `https://example.com` or `https://example.com/some/path`. + +❌ `example.com` is invalid as it doesn't contain the protocol + +✅ `https://example.com/some/path` is valid as it contains a protocol + +--- ### Only one record type Earlier, is-a-dev used to allow for handling https redirections along with CNAME but the way we handle requests has changed since then. This is why a record file can only contain one record type. Either `CNAME` or `A` or `URL`. +❌ `"CNAME": "example.com", "URL": "https://something.com"` is invalid as it should only contain one type of record, either CNAME or URL. + diff --git a/domains/avnoor-gamerz.json b/domains/avnoor-gamerz.json new file mode 100644 index 0000000000..ddb3b8bb26 --- /dev/null +++ b/domains/avnoor-gamerz.json @@ -0,0 +1,12 @@ +{ + "description": "Official WEBSITE OF aVNOOR gAMERZ", + "repo": "https://github.com/Avnoor-Gamerz/avnoor-gamerz.github.io", + "owner": { + "username": "avnoor-gamerz", + "email": "avnoorchahal001@gmail.com", + "twitter": "avnoor-gamerz" + }, + "record": { + "CNAME": "avnoor-gamerz.github.io" + } +} \ No newline at end of file diff --git a/domains/bedanth.json b/domains/bedanth.json new file mode 100644 index 0000000000..dd82ce3ee1 --- /dev/null +++ b/domains/bedanth.json @@ -0,0 +1,11 @@ +{ + "description": "Bedant Hota's Portfolio", + "repo": "https://github.com/bedantH/bedantH.github.io", + "owner": { + "username": "bedantH", + "email": "mohanesh.h2003@gmail.com" + }, + "record": { + "CNAME": "bedantH.github.io" + } +} \ No newline at end of file diff --git a/domains/caleb.json b/domains/caleb.json index 615f01dd3a..9b6d43d36d 100644 --- a/domains/caleb.json +++ b/domains/caleb.json @@ -8,4 +8,4 @@ "record": { "URL": "https://calebden.io" } -} +} \ No newline at end of file diff --git a/domains/charalampos.json b/domains/charalampos.json new file mode 100644 index 0000000000..44e9205644 --- /dev/null +++ b/domains/charalampos.json @@ -0,0 +1,11 @@ +{ + "description": "Redirection domain for my personal website", + "repo": "https://github.com/cfanoulis/fanoulis.dev", + "owner": { + "username": "cfanoulis", + "email": "domains@fanoulis.dev" + }, + "record": { + "URL": "https://fanoulis.dev" + } +} \ No newline at end of file diff --git a/domains/daniel.json b/domains/daniel.json index 651180a647..f69282aa6f 100644 --- a/domains/daniel.json +++ b/domains/daniel.json @@ -8,4 +8,4 @@ "record": { "CNAME": "71bac7ca-1eac-46fe-9588-cd31d68b2e06.repl.co" } -} +} \ No newline at end of file diff --git a/domains/deadshot.json b/domains/deadshot.json index 9d4670aa41..fedfa67f58 100644 --- a/domains/deadshot.json +++ b/domains/deadshot.json @@ -9,4 +9,4 @@ "record": { "CNAME": "deadshotofficial.github.io" } -} +} \ No newline at end of file diff --git a/domains/didier.json b/domains/didier.json new file mode 100644 index 0000000000..0aa6c14d52 --- /dev/null +++ b/domains/didier.json @@ -0,0 +1,11 @@ +{ + "description": "Hello there I am Didier Munezero", + "repo": "https://github.com/didiermunezero", + "owner": { + "username": "didiermunezero", + "email": "didiermunezer38@gmail.com" + }, + "record": { + "CNAME": "didiermunezero.github.io" + } +} \ No newline at end of file diff --git a/domains/dwii.json b/domains/dwii.json index b5cd2203d8..92e8eb2da9 100644 --- a/domains/dwii.json +++ b/domains/dwii.json @@ -8,4 +8,4 @@ "record": { "URL": "https://dwii.my.id/" } -} +} \ No newline at end of file diff --git a/domains/fatgrizzly.json b/domains/fatgrizzly.json index 9160aabc07..ab28409788 100644 --- a/domains/fatgrizzly.json +++ b/domains/fatgrizzly.json @@ -11,4 +11,4 @@ "89.163.215.211" ] } -} +} \ No newline at end of file diff --git a/domains/flexico.json b/domains/flexico.json index 271aa1af29..0e075ee800 100644 --- a/domains/flexico.json +++ b/domains/flexico.json @@ -8,4 +8,4 @@ "record": { "CNAME": "7xh.github.io" } -} +} \ No newline at end of file diff --git a/domains/gingdev.json b/domains/gingdev.json index eedeecd648..4ddafcf2a6 100644 --- a/domains/gingdev.json +++ b/domains/gingdev.json @@ -10,4 +10,4 @@ "192.243.108.102" ] } -} +} \ No newline at end of file diff --git a/domains/json.json b/domains/json.json index a406cd7f4e..e2787e6753 100644 --- a/domains/json.json +++ b/domains/json.json @@ -7,4 +7,4 @@ "record": { "URL": "https://jasonaa.me/" } -} +} \ No newline at end of file diff --git a/domains/koolwiza.json b/domains/koolwiza.json index be0e560b3f..63344fe26c 100644 --- a/domains/koolwiza.json +++ b/domains/koolwiza.json @@ -1,11 +1,11 @@ { "owner": { "username": "Koolwiza", - "email": "koowliza@gmail.com" + "email": "koolwiza@gmail.com" }, "description": "Just a cool subdomain to have :)", "repo": "https://www.github.com/Koolwiza", "record": { "CNAME": "koolwiza.github.io" } -} +} \ No newline at end of file diff --git a/domains/lejhand.json b/domains/lejhand.json index 63c6796861..0ca4935ea7 100644 --- a/domains/lejhand.json +++ b/domains/lejhand.json @@ -8,4 +8,4 @@ "record": { "CNAME": "dazzling-williams-9e8070.netlify.app" } -} +} \ No newline at end of file diff --git a/domains/matthew.json b/domains/matthew.json index 7909c2f1e6..78b3b3ccf1 100644 --- a/domains/matthew.json +++ b/domains/matthew.json @@ -8,4 +8,4 @@ "record": { "URL": "https://mattglei.ch" } -} +} \ No newline at end of file diff --git a/domains/mysteriousk.json b/domains/mysteriousk.json index 14bc1fb7e1..44a8538087 100644 --- a/domains/mysteriousk.json +++ b/domains/mysteriousk.json @@ -8,4 +8,4 @@ "record": { "CNAME": "lawliet.host" } -} +} \ No newline at end of file diff --git a/domains/ovillafuerte94.json b/domains/ovillafuerte94.json index 63739647b7..edc251a5b9 100644 --- a/domains/ovillafuerte94.json +++ b/domains/ovillafuerte94.json @@ -1,11 +1,11 @@ { - "description": "Omar Villafuerte", - "repo": "https://github.com/ovillafuerte94/ovillafuerte94.github.io", - "owner": { - "username": "ovillafuerte94", - "email": "ovillafuerte.94@gmail.com" - }, - "record": { - "CNAME": "ovillafuerte94.github.io" - } + "description": "Omar Villafuerte", + "repo": "https://github.com/ovillafuerte94/ovillafuerte94.github.io", + "owner": { + "username": "ovillafuerte94", + "email": "ovillafuerte.94@gmail.com" + }, + "record": { + "CNAME": "ovillafuerte94.github.io" + } } \ No newline at end of file diff --git a/domains/rahulkirangaddam.json b/domains/rahulkirangaddam.json index 16673d37ce..6473e4784e 100644 --- a/domains/rahulkirangaddam.json +++ b/domains/rahulkirangaddam.json @@ -1,6 +1,6 @@ { "description": "Rahul Kiran Gaddam Profile", - "repo":"https://github.com/rahgadda/rahgadda.github.io", + "repo": "https://github.com/rahgadda/rahgadda.github.io", "owner": { "username": "rahgadda", "email": "gaddam.rahul@gmail.com" @@ -8,4 +8,4 @@ "record": { "CNAME": "rahgadda.github.io" } -} +} \ No newline at end of file diff --git a/domains/rohan.json b/domains/rohan.json index 832a60dac7..d7c83f0a2f 100644 --- a/domains/rohan.json +++ b/domains/rohan.json @@ -8,4 +8,4 @@ "record": { "URL": "https://rbansal.dev" } -} +} \ No newline at end of file diff --git a/domains/sjcdn.json b/domains/sjcdn.json new file mode 100644 index 0000000000..54e8f0cc88 --- /dev/null +++ b/domains/sjcdn.json @@ -0,0 +1,10 @@ +{ + "owner": { + "username": "CoolCoderSJ", + "email": "CoolCoderSJ@gmail.com" + }, + "description": "My CDN", + "record": { + "CNAME": "09d836a5-eaca-4299-bfec-44ca0dfc6d0d.repl.co" + } +} \ No newline at end of file diff --git a/domains/tessa.json b/domains/tessa.json new file mode 100644 index 0000000000..461033403c --- /dev/null +++ b/domains/tessa.json @@ -0,0 +1,11 @@ +{ + "description": "My main site :)", + "repo": "https://replit.com/@RoBlockHead/tessais-adev", + "owner": { + "username": "RoBlockHead", + "email": "tessa7551@gmail.com" + }, + "record": { + "CNAME": "06745170-24e7-4954-a619-2860f8b395c2.repl.co" + } +} \ No newline at end of file diff --git a/domains/tracker-brawley.json b/domains/tracker-brawley.json index a601a15b44..feec194ac9 100644 --- a/domains/tracker-brawley.json +++ b/domains/tracker-brawley.json @@ -1,4 +1,3 @@ - { "description": "a website for my biotapi", "repo": "https://github.com/brawlie/todo", @@ -9,4 +8,4 @@ "record": { "CNAME": "aa1b3bae-e49b-4efd-8c55-28719da5f58c.repl.co" } -} +} \ No newline at end of file diff --git a/domains/verite.json b/domains/verite.json index c57038fc95..0489798805 100644 --- a/domains/verite.json +++ b/domains/verite.json @@ -1,11 +1,11 @@ { - "repo": "https://github.com/makuzaverite/veritem.me", - "owner": { - "username": "makuzaverite", - "email": "mugaboverite@gmail.com", - "twitter": "makuza_mugabo_v" - }, - "record": { - "URL": "https://veritem.me" - } -} + "repo": "https://github.com/makuzaverite/veritem.me", + "owner": { + "username": "makuzaverite", + "email": "mugaboverite@gmail.com", + "twitter": "makuza_mugabo_v" + }, + "record": { + "URL": "https://veritem.me" + } +} \ No newline at end of file diff --git a/domains/wiicreation.json b/domains/wiicreation.json index f175fa206d..e0726aadb9 100644 --- a/domains/wiicreation.json +++ b/domains/wiicreation.json @@ -8,4 +8,4 @@ "record": { "CNAME": "C1200.github.io" } -} +} \ No newline at end of file diff --git a/domains/yuto.json b/domains/yuto.json index f5aa2bd11d..e2c5faec22 100644 --- a/domains/yuto.json +++ b/domains/yuto.json @@ -1,10 +1,10 @@ { - "owner": { - "username": "starptr", - "email": "yuto@berkeley.edu" - }, - "description": "Personal website", - "record": { - "URL": "https://yart.me" - } -} + "owner": { + "username": "starptr", + "email": "yuto@berkeley.edu" + }, + "description": "Personal website", + "record": { + "URL": "https://yart.me" + } +} \ No newline at end of file