From 8ce72bc7a4dcc5fa88e54b6cdae78839331370fd Mon Sep 17 00:00:00 2001 From: DIBSTER <76603072+DEV-DIBSTER@users.noreply.github.com> Date: Sun, 8 Sep 2024 22:00:56 -0400 Subject: [PATCH 1/3] Update json.test.js --- tests/json.test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/json.test.js b/tests/json.test.js index 3a1e357..722d523 100644 --- a/tests/json.test.js +++ b/tests/json.test.js @@ -48,3 +48,7 @@ test('Check if JSON file follows format', () => { core.setOutput('recordMessage', recordMessage); expect(passed).toBe(true); }); + +test('Check if JSON file matches the value name', () => { + +}); From d4a76268c37c4630ba25ded37f9120e6088f6ce0 Mon Sep 17 00:00:00 2001 From: DIBSTER <76603072+DEV-DIBSTER@users.noreply.github.com> Date: Sun, 8 Sep 2024 22:07:09 -0400 Subject: [PATCH 2/3] chore: adding validation --- tests/json.test.js | 7 ++++++- utils/getFileName.js | 17 +++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 utils/getFileName.js diff --git a/tests/json.test.js b/tests/json.test.js index 722d523..5533900 100644 --- a/tests/json.test.js +++ b/tests/json.test.js @@ -2,6 +2,7 @@ const core = require('@actions/core'); const getJSON = require('../utils/getJSON.js'); const checkInfo = require('../utils/checkInfo.js'); const checkRecords = require('../utils/checkRecords.js'); +const getFileName = require('../utils/getFileName.js'); const data = getJSON(process.env.FILES); function setupMessages() { @@ -50,5 +51,9 @@ test('Check if JSON file follows format', () => { }); test('Check if JSON file matches the value name', () => { - + const passed = getFileName(process.env.FILES, data); + let fileNameMessage = passed === true ? "File name matches target.RECORD_TYPE." : "File name does not match any target.RECORD_TYPE."; + + core.setOutput('fileNameMessage', fileNameMessage); + expect(passed).toBe(true); }); diff --git a/utils/getFileName.js b/utils/getFileName.js new file mode 100644 index 0000000..c5ff20b --- /dev/null +++ b/utils/getFileName.js @@ -0,0 +1,17 @@ +const { stripExt } = require('./utils.js'); + +async function getFileName(file, data) { + // Extract the file name without extension + const fileNameWithoutExt = stripExt(file); + + // Validate if the file name matches any of the target.RECORD_TYPE values + const recordTypes = Object.keys(data.target); + if (!recordTypes.includes(fileNameWithoutExt.toUpperCase())) { + core.setOutput('infoMessage', `File name ${fileNameWithoutExt} does not match any target.RECORD_TYPE`); + return false; + } else { + return true; + } +} + +module.exports = getFileName; \ No newline at end of file From 0e0cc45f6b437a864d0820f7fc20fef37b951571 Mon Sep 17 00:00:00 2001 From: DIBSTER <76603072+DEV-DIBSTER@users.noreply.github.com> Date: Sun, 8 Sep 2024 22:07:59 -0400 Subject: [PATCH 3/3] chore: removing it from another file --- utils/getJSON.js | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/utils/getJSON.js b/utils/getJSON.js index e76b1c1..e1fec48 100644 --- a/utils/getJSON.js +++ b/utils/getJSON.js @@ -15,16 +15,6 @@ function getJSON(file, filename) { const rawdata = fs.readFileSync(path); // Read the file const data = JSON.parse(rawdata); // Parse it - // Extract the file name without extension - const fileNameWithoutExt = stripExt(file); - - // Validate if the file name matches any of the target.RECORD_TYPE values - const recordTypes = Object.keys(data.target); - if (!recordTypes.includes(fileNameWithoutExt.toUpperCase())) { - core.setOutput('infoMessage', `File name ${fileNameWithoutExt} does not match any target.RECORD_TYPE`); - return false; - } - return data; // Return the parsed data if validation passes } return 3; // It doesn't exist