From 59c9cd0329d9610459c0febd2d627e301aff5525 Mon Sep 17 00:00:00 2001 From: Tweak Date: Thu, 19 Jan 2023 18:33:29 -0700 Subject: [PATCH] Add type checking. --- utils/checkRecords.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/utils/checkRecords.js b/utils/checkRecords.js index 2f2cfab..9db8741 100644 --- a/utils/checkRecords.js +++ b/utils/checkRecords.js @@ -1,14 +1,15 @@ -const { checkIfValidIP, checkIfValidFQDN, checkInvalidDomain } = require('./utils.js'); +const { checkIfValidIP, checkIfValidFQDN, checkInvalidDomain, isString } = require('./utils.js'); function checkRecords(data) { const recordType = Object.keys(data.target)[0]; - + const value = data.target[recordType].value; // Check if the domain is invalid if (checkInvalidDomain(data.target[recordType].name) === true) return false; // Check A record if (recordType.toLowerCase() === 'a') { - for (const record of data.target[recordType].value) { + if (!Array.isArray(value)) return false; + for (const record of value) { if (checkIfValidIP(record) == false) return false; } return true; @@ -16,7 +17,8 @@ function checkRecords(data) { // Check CNAME record if (recordType.toLowerCase() === 'cname') { - return checkIfValidFQDN(data.target[recordType].value); + if (!isString(value)) return false; + return checkIfValidFQDN(value); } return false;