dependencies: Upgrade mockito 3.5 to 4.5 (#2316)

* refactor: move tests of leader-followers into correct package

* dep: remove version constraint for Mockito in acyclic-visitor

* dep: remove version constraint for Mockito in caching

* chore: cleanup mockito-core import on some POMs

* dep: upgrade core.mocktio 3.5.6 to 4.5.1

"- org.mockito.Mockito#verifyZeroInteractions an alias of verifyNoMoreInteractions"
https://github.com/mockito/mockito/commit/caf35b24e2764df0498469526ecb3e7ec68a0430
This commit is contained in:
Robert Volkmann authored and GitHub committed 2022-11-20 10:16:53 +02:00
1 parent 84e83c4d43
commit 465a6871b2
41 files changed
+65 -111

No files matched your search

+1 -2
View File
@@ -53,8 +53,7 @@
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId> <artifactId>mockito-core</artifactId>
<version>1.10.19</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
@@ -26,7 +26,7 @@ package com.iluwatar.acyclicvisitor;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.*; import static org.mockito.Mockito.*;
/** /**
@@ -50,6 +50,6 @@ class HayesTest {
hayes.accept(mockVisitor); hayes.accept(mockVisitor);
verifyZeroInteractions(mockVisitor); verifyNoMoreInteractions(mockVisitor);
} }
} }
@@ -27,7 +27,7 @@ package com.iluwatar.acyclicvisitor;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
@@ -32,11 +32,11 @@ import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertTimeout; import static org.junit.jupiter.api.Assertions.assertTimeout;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.Mockito.timeout; import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import static org.mockito.internal.verification.VerificationModeFactory.times; import static org.mockito.internal.verification.VerificationModeFactory.times;
@@ -47,7 +47,6 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
import org.mockito.Captor; import org.mockito.Captor;
import org.mockito.Matchers;
import org.mockito.Mock; import org.mockito.Mock;
import org.mockito.MockitoAnnotations; import org.mockito.MockitoAnnotations;
@@ -190,7 +189,7 @@ class ThreadAsyncExecutorTest {
assertNotNull(asyncResult); assertNotNull(asyncResult);
assertFalse(asyncResult.isCompleted()); assertFalse(asyncResult.isCompleted());
verifyZeroInteractions(callback); verifyNoMoreInteractions(callback);
try { try {
asyncResult.getValue(); asyncResult.getValue();
@@ -296,7 +295,7 @@ class ThreadAsyncExecutorTest {
assertNotNull(asyncResult, "The AsyncResult should not be 'null', even though the task was 'null'."); assertNotNull(asyncResult, "The AsyncResult should not be 'null', even though the task was 'null'.");
asyncResult.await(); // Prevent timing issues, and wait until the result is available asyncResult.await(); // Prevent timing issues, and wait until the result is available
assertTrue(asyncResult.isCompleted()); assertTrue(asyncResult.isCompleted());
verify(callback, times(1)).onComplete(Matchers.isNull(), optionalCaptor.capture()); verify(callback, times(1)).onComplete(isNull(), optionalCaptor.capture());
final var optionalException = optionalCaptor.getValue(); final var optionalException = optionalCaptor.getValue();
assertNotNull(optionalException); assertNotNull(optionalException);
+1 -2
View File
@@ -41,8 +41,7 @@
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId> <artifactId>mockito-core</artifactId>
<version>1.10.19</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
@@ -53,6 +53,10 @@ public class MongoDb implements DbManager {
private MongoClient client; private MongoClient client;
private MongoDatabase db; private MongoDatabase db;
void setDB(MongoDatabase db) {
this.db = db;
}
/** /**
* Connect to Db. Check th connection * Connect to Db. Check th connection
*/ */
@@ -33,7 +33,6 @@ import org.bson.Document;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.Mock; import org.mockito.Mock;
import org.mockito.internal.util.reflection.Whitebox;
import static com.iluwatar.caching.constants.CachingConstants.ADD_INFO; import static com.iluwatar.caching.constants.CachingConstants.ADD_INFO;
import static com.iluwatar.caching.constants.CachingConstants.USER_ID; import static com.iluwatar.caching.constants.CachingConstants.USER_ID;
@@ -56,10 +55,8 @@ class MongoDbTest {
@BeforeEach @BeforeEach
void init() { void init() {
db = mock(MongoDatabase.class); db = mock(MongoDatabase.class);
Whitebox.setInternalState(mongoDb, "db", db); mongoDb.setDB(db);
userAccount = new UserAccount(ID, NAME, ADDITIONAL_INFO); userAccount = new UserAccount(ID, NAME, ADDITIONAL_INFO);
} }
@Test @Test
-1
View File
@@ -55,7 +55,6 @@
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
<version>4.1.0</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
+1
View File
@@ -46,6 +46,7 @@
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
<build> <build>
-5
View File
@@ -45,11 +45,6 @@
<artifactId>junit-jupiter-engine</artifactId> <artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
</dependencies> </dependencies>
<build> <build>
<plugins> <plugins>
+1
View File
@@ -46,6 +46,7 @@
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.joda</groupId> <groupId>org.joda</groupId>
@@ -24,16 +24,14 @@
*/ */
package com.iluwatar.event.aggregator; package com.iluwatar.event.aggregator;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import java.util.Objects; import java.util.Objects;
import java.util.function.BiFunction; import java.util.function.BiFunction;
import java.util.function.Function;
import java.util.function.Supplier; import java.util.function.Supplier;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -111,7 +109,7 @@ abstract class EventEmitterTest<E extends EventEmitter> {
} }
} else { } else {
// On any other normal day, the observers should have received nothing at all // On any other normal day, the observers should have received nothing at all
verifyZeroInteractions(observers); verifyNoMoreInteractions(observers);
} }
} }
@@ -24,12 +24,11 @@
*/ */
package com.iluwatar.event.aggregator; package com.iluwatar.event.aggregator;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import java.util.Arrays; import java.util.Arrays;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -63,7 +62,7 @@ class KingsHandTest extends EventEmitterTest<KingsHand> {
kingsHand.registerObserver(observer, Event.WHITE_WALKERS_SIGHTED); kingsHand.registerObserver(observer, Event.WHITE_WALKERS_SIGHTED);
// The kings hand should not pass any events before he received one // The kings hand should not pass any events before he received one
verifyZeroInteractions(observer); verifyNoMoreInteractions(observer);
// Verify if each event is passed on to the observer, nothing less, nothing more. // Verify if each event is passed on to the observer, nothing less, nothing more.
Arrays.stream(Event.values()).forEach(event -> { Arrays.stream(Event.values()).forEach(event -> {
@@ -25,12 +25,11 @@
package com.iluwatar.flux.store; package com.iluwatar.flux.store;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import com.iluwatar.flux.action.Content; import com.iluwatar.flux.action.Content;
import com.iluwatar.flux.action.ContentAction; import com.iluwatar.flux.action.ContentAction;
@@ -53,11 +52,11 @@ class ContentStoreTest {
final var view = mock(View.class); final var view = mock(View.class);
contentStore.registerView(view); contentStore.registerView(view);
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
// Content should not react on menu action ... // Content should not react on menu action ...
contentStore.onAction(new MenuAction(MenuItem.PRODUCTS)); contentStore.onAction(new MenuAction(MenuItem.PRODUCTS));
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
// ... but it should react on a content action // ... but it should react on a content action
contentStore.onAction(new ContentAction(Content.COMPANY)); contentStore.onAction(new ContentAction(Content.COMPANY));
@@ -25,12 +25,11 @@
package com.iluwatar.flux.store; package com.iluwatar.flux.store;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import com.iluwatar.flux.action.Content; import com.iluwatar.flux.action.Content;
import com.iluwatar.flux.action.ContentAction; import com.iluwatar.flux.action.ContentAction;
@@ -53,11 +52,11 @@ class MenuStoreTest {
final var view = mock(View.class); final var view = mock(View.class);
menuStore.registerView(view); menuStore.registerView(view);
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
// Menu should not react on content action ... // Menu should not react on content action ...
menuStore.onAction(new ContentAction(Content.COMPANY)); menuStore.onAction(new ContentAction(Content.COMPANY));
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
// ... but it should react on a menu action // ... but it should react on a menu action
menuStore.onAction(new MenuAction(MenuItem.PRODUCTS)); menuStore.onAction(new MenuAction(MenuItem.PRODUCTS));
@@ -24,7 +24,7 @@
*/ */
package com.iluwatar.flux.view; package com.iluwatar.flux.view;
import static org.mockito.Matchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
@@ -24,7 +24,7 @@
*/ */
package com.iluwatar.halfsynchalfasync; package com.iluwatar.halfsynchalfasync;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.inOrder; import static org.mockito.Mockito.inOrder;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
@@ -25,11 +25,11 @@
package com.iluwatar.intercepting.filter; package com.iluwatar.intercepting.filter;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Matchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -46,7 +46,7 @@ class FilterManagerTest {
final var target = mock(Target.class); final var target = mock(Target.class);
final var filterManager = new FilterManager(); final var filterManager = new FilterManager();
assertEquals("RUNNING...", filterManager.filterRequest(mock(Order.class))); assertEquals("RUNNING...", filterManager.filterRequest(mock(Order.class)));
verifyZeroInteractions(target); verifyNoMoreInteractions(target);
} }
@Test @Test
@@ -54,7 +54,7 @@ class FilterManagerTest {
final var target = mock(Target.class); final var target = mock(Target.class);
final var filterManager = new FilterManager(); final var filterManager = new FilterManager();
verifyZeroInteractions(target); verifyNoMoreInteractions(target);
final var filter = mock(Filter.class); final var filter = mock(Filter.class);
when(filter.execute(any(Order.class))).thenReturn("filter"); when(filter.execute(any(Order.class))).thenReturn("filter");
@@ -65,6 +65,6 @@ class FilterManagerTest {
assertEquals("filter", filterManager.filterRequest(order)); assertEquals("filter", filterManager.filterRequest(order));
verify(filter, times(1)).execute(any(Order.class)); verify(filter, times(1)).execute(any(Order.class));
verifyZeroInteractions(target, filter, order); verifyNoMoreInteractions(target, filter, order);
} }
} }
-5
View File
@@ -39,10 +39,5 @@
<artifactId>junit-jupiter-engine</artifactId> <artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
</dependencies> </dependencies>
</project> </project>
@@ -22,12 +22,10 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE. * THE SOFTWARE.
*/ */
package com; package com.iluwatar.leaderfollowers;
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import com.iluwatar.leaderfollowers.App;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
/** /**
@@ -22,12 +22,10 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE. * THE SOFTWARE.
*/ */
package com; package com.iluwatar.leaderfollowers;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertTrue;
import com.iluwatar.leaderfollowers.Task;
import com.iluwatar.leaderfollowers.TaskHandler;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
/** /**
@@ -22,12 +22,10 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE. * THE SOFTWARE.
*/ */
package com; package com.iluwatar.leaderfollowers;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import com.iluwatar.leaderfollowers.Task;
import com.iluwatar.leaderfollowers.TaskSet;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
/** /**
@@ -22,14 +22,11 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE. * THE SOFTWARE.
*/ */
package com; package com.iluwatar.leaderfollowers;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertNull;
import com.iluwatar.leaderfollowers.TaskHandler;
import com.iluwatar.leaderfollowers.TaskSet;
import com.iluwatar.leaderfollowers.WorkCenter;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
/** /**
@@ -27,7 +27,6 @@ package com.iluwatar.mediator;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -55,7 +54,7 @@ class PartyImplTest {
verify(partyMember2).joinedParty(party); verify(partyMember2).joinedParty(party);
party.act(partyMember1, Action.GOLD); party.act(partyMember1, Action.GOLD);
verifyZeroInteractions(partyMember1); verifyNoMoreInteractions(partyMember1);
verify(partyMember2).partyAction(Action.GOLD); verify(partyMember2).partyAction(Action.GOLD);
verifyNoMoreInteractions(partyMember1, partyMember2); verifyNoMoreInteractions(partyMember1, partyMember2);
@@ -27,7 +27,6 @@ package com.iluwatar.model.view.controller;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -47,12 +46,12 @@ class GiantControllerTest {
final var view = mock(GiantView.class); final var view = mock(GiantView.class);
final var controller = new GiantController(model, view); final var controller = new GiantController(model, view);
verifyZeroInteractions(model, view); verifyNoMoreInteractions(model, view);
for (final var health : Health.values()) { for (final var health : Health.values()) {
controller.setHealth(health); controller.setHealth(health);
verify(model).setHealth(health); verify(model).setHealth(health);
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
} }
controller.getHealth(); controller.getHealth();
@@ -71,12 +70,12 @@ class GiantControllerTest {
final var view = mock(GiantView.class); final var view = mock(GiantView.class);
final var controller = new GiantController(model, view); final var controller = new GiantController(model, view);
verifyZeroInteractions(model, view); verifyNoMoreInteractions(model, view);
for (final var fatigue : Fatigue.values()) { for (final var fatigue : Fatigue.values()) {
controller.setFatigue(fatigue); controller.setFatigue(fatigue);
verify(model).setFatigue(fatigue); verify(model).setFatigue(fatigue);
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
} }
controller.getFatigue(); controller.getFatigue();
@@ -95,12 +94,12 @@ class GiantControllerTest {
final var view = mock(GiantView.class); final var view = mock(GiantView.class);
final var controller = new GiantController(model, view); final var controller = new GiantController(model, view);
verifyZeroInteractions(model, view); verifyNoMoreInteractions(model, view);
for (final var nourishment : Nourishment.values()) { for (final var nourishment : Nourishment.values()) {
controller.setNourishment(nourishment); controller.setNourishment(nourishment);
verify(model).setNourishment(nourishment); verify(model).setNourishment(nourishment);
verifyZeroInteractions(view); verifyNoMoreInteractions(view);
} }
controller.getNourishment(); controller.getNourishment();
@@ -116,7 +115,7 @@ class GiantControllerTest {
final var view = mock(GiantView.class); final var view = mock(GiantView.class);
final var controller = new GiantController(model, view); final var controller = new GiantController(model, view);
verifyZeroInteractions(model, view); verifyNoMoreInteractions(model, view);
controller.updateView(); controller.updateView();
verify(view).displayGiant(model); verify(view).displayGiant(model);
@@ -25,13 +25,12 @@
package com.iluwatar.monostate; package com.iluwatar.monostate;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Matchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doNothing; import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -64,7 +63,7 @@ class LoadBalancerTest {
final var loadBalancer = new LoadBalancer(); final var loadBalancer = new LoadBalancer();
loadBalancer.addServer(server); loadBalancer.addServer(server);
verifyZeroInteractions(server); verifyNoMoreInteractions(server);
final var request = new Request("test"); final var request = new Request("test");
for (var i = 0; i < loadBalancer.getNoOfServers() * 2; i++) { for (var i = 0; i < loadBalancer.getNoOfServers() * 2; i++) {
@@ -29,7 +29,6 @@ import static org.mockito.Mockito.inOrder;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import com.iluwatar.observer.utils.InMemoryAppender; import com.iluwatar.observer.utils.InMemoryAppender;
import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.AfterEach;
@@ -65,7 +64,7 @@ class WeatherTest {
final var weather = new Weather(); final var weather = new Weather();
weather.addObserver(observer); weather.addObserver(observer);
verifyZeroInteractions(observer); verifyNoMoreInteractions(observer);
weather.timePasses(); weather.timePasses();
assertEquals("The weather changed to rainy.", appender.getLastMessage()); assertEquals("The weather changed to rainy.", appender.getLastMessage());
@@ -29,7 +29,6 @@ import static org.mockito.Mockito.inOrder;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import com.iluwatar.observer.WeatherObserver; import com.iluwatar.observer.WeatherObserver;
import com.iluwatar.observer.WeatherType; import com.iluwatar.observer.WeatherType;
@@ -67,7 +66,7 @@ class GWeatherTest {
final var weather = new GWeather(); final var weather = new GWeather();
weather.addObserver(observer); weather.addObserver(observer);
verifyZeroInteractions(observer); verifyNoMoreInteractions(observer);
weather.timePasses(); weather.timePasses();
assertEquals("The weather changed to rainy.", appender.getLastMessage()); assertEquals("The weather changed to rainy.", appender.getLastMessage());
@@ -27,11 +27,10 @@ package com.iluwatar.poison.pill;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor; import org.mockito.ArgumentCaptor;
@@ -47,7 +46,7 @@ class ProducerTest {
void testSend() throws Exception { void testSend() throws Exception {
final var publishPoint = mock(MqPublishPoint.class); final var publishPoint = mock(MqPublishPoint.class);
final var producer = new Producer("producer", publishPoint); final var producer = new Producer("producer", publishPoint);
verifyZeroInteractions(publishPoint); verifyNoMoreInteractions(publishPoint);
producer.send("Hello!"); producer.send("Hello!");
@@ -67,7 +66,7 @@ class ProducerTest {
void testStop() throws Exception { void testStop() throws Exception {
final var publishPoint = mock(MqPublishPoint.class); final var publishPoint = mock(MqPublishPoint.class);
final var producer = new Producer("producer", publishPoint); final var producer = new Producer("producer", publishPoint);
verifyZeroInteractions(publishPoint); verifyNoMoreInteractions(publishPoint);
producer.stop(); producer.stop();
verify(publishPoint).put(eq(Message.POISON_PILL)); verify(publishPoint).put(eq(Message.POISON_PILL));
-16
View File
@@ -43,7 +43,6 @@
<commons-dbcp.version>1.4</commons-dbcp.version> <commons-dbcp.version>1.4</commons-dbcp.version>
<camel.version>2.25.1</camel.version> <camel.version>2.25.1</camel.version>
<guava.version>19.0</guava.version> <guava.version>19.0</guava.version>
<mockito.version>3.5.6</mockito.version>
<htmlunit.version>2.66.0</htmlunit.version> <htmlunit.version>2.66.0</htmlunit.version>
<guice.version>4.0</guice.version> <guice.version>4.0</guice.version>
<mongo-java-driver.version>3.12.8</mongo-java-driver.version> <mongo-java-driver.version>3.12.8</mongo-java-driver.version>
@@ -226,21 +225,6 @@
</repositories> </repositories>
<dependencyManagement> <dependencyManagement>
<dependencies> <dependencies>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-inline</artifactId>
<version>${mockito.version}</version>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-junit-jupiter</artifactId>
<version>${mockito.version}</version>
</dependency>
<dependency> <dependency>
<groupId>org.springframework.boot</groupId> <groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId> <artifactId>spring-boot-dependencies</artifactId>
@@ -26,7 +26,7 @@ package com.iluwatar.producer.consumer;
import static java.time.Duration.ofMillis; import static java.time.Duration.ofMillis;
import static org.junit.jupiter.api.Assertions.assertTimeout; import static org.junit.jupiter.api.Assertions.assertTimeout;
import static org.mockito.Matchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
@@ -28,7 +28,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
+1
View File
@@ -46,6 +46,7 @@
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
<build> <build>
@@ -27,7 +27,6 @@ package com.iluwatar.threadpool;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -45,7 +44,7 @@ class WorkerTest {
void testRun() { void testRun() {
final var task = mock(Task.class); final var task = mock(Task.class);
final var worker = new Worker(task); final var worker = new Worker(task);
verifyZeroInteractions(task); verifyNoMoreInteractions(task);
worker.run(); worker.run();
verify(task).getTimeMs(); verify(task).getTimeMs();
+1
View File
@@ -46,6 +46,7 @@
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
<build> <build>
@@ -28,13 +28,12 @@ import static java.lang.Thread.UncaughtExceptionHandler;
import static java.lang.Thread.sleep; import static java.lang.Thread.sleep;
import static java.time.Duration.ofMillis; import static java.time.Duration.ofMillis;
import static org.junit.jupiter.api.Assertions.assertTimeout; import static org.junit.jupiter.api.Assertions.assertTimeout;
import static org.mockito.Matchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.atLeastOnce; import static org.mockito.Mockito.atLeastOnce;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@@ -87,7 +86,7 @@ class BallThreadTest {
sleep(1000); sleep(1000);
verifyZeroInteractions(ballItem); verifyNoMoreInteractions(ballItem);
ballThread.resumeMe(); ballThread.resumeMe();
sleep(300); sleep(300);
+1
View File
@@ -42,6 +42,7 @@
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId> <artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
<build> <build>
@@ -24,7 +24,7 @@
*/ */
package com.iluwatar.visitor; package com.iluwatar.visitor;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
/** /**
@@ -24,7 +24,7 @@
*/ */
package com.iluwatar.visitor; package com.iluwatar.visitor;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
/** /**
@@ -24,7 +24,7 @@
*/ */
package com.iluwatar.visitor; package com.iluwatar.visitor;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
/** /**
@@ -24,7 +24,7 @@
*/ */
package com.iluwatar.visitor; package com.iluwatar.visitor;
import static org.mockito.Matchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;