refactor: remove code smell java:S5786 (#2159)

https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786
This commit is contained in:
Robert Volkmann authored and GitHub committed 2022-10-30 18:21:21 +02:00
1 parent 5afc32cf23
commit 4cd8149502
155 files changed
+273 -273

No files matched your search

@@ -74,7 +74,7 @@ class ConfigureForDosVisitorTest {
@BeforeEach @BeforeEach
@AfterEach @AfterEach
public void clearLoggers() { void clearLoggers() {
TestLoggerFactory.clear(); TestLoggerFactory.clear();
} }
} }
@@ -44,7 +44,7 @@ class ConfigureForUnixVisitorTest {
@BeforeEach @BeforeEach
@AfterEach @AfterEach
public void clearLoggers() { void clearLoggers() {
TestLoggerFactory.clear(); TestLoggerFactory.clear();
} }
@@ -48,7 +48,7 @@ class AdapterPatternTest {
* This method runs before the test execution and sets the bean objects in the beans Map. * This method runs before the test execution and sets the bean objects in the beans Map.
*/ */
@BeforeEach @BeforeEach
public void setup() { void setup() {
beans = new HashMap<>(); beans = new HashMap<>();
var fishingBoatAdapter = spy(new FishingBoatAdapter()); var fishingBoatAdapter = spy(new FishingBoatAdapter());
@@ -48,7 +48,7 @@ class AggregatorTest {
private ProductInventoryClient inventoryClient; private ProductInventoryClient inventoryClient;
@BeforeEach @BeforeEach
public void setup() { void setup() {
MockitoAnnotations.openMocks(this); MockitoAnnotations.openMocks(this);
} }
@@ -48,7 +48,7 @@ class ApiGatewayTest {
private PriceClient priceClient; private PriceClient priceClient;
@BeforeEach @BeforeEach
public void setup() { void setup() {
MockitoAnnotations.openMocks(this); MockitoAnnotations.openMocks(this);
} }
@@ -49,7 +49,7 @@ class BusinessDelegateTest {
* execution of every test. * execution of every test.
*/ */
@BeforeEach @BeforeEach
public void setup() { void setup() {
netflixService = spy(new NetflixService()); netflixService = spy(new NetflixService());
youTubeService = spy(new YouTubeService()); youTubeService = spy(new YouTubeService());
@@ -39,7 +39,7 @@ class CachingTest {
* Setup of application test includes: initializing DB connection and cache size/capacity. * Setup of application test includes: initializing DB connection and cache size/capacity.
*/ */
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
// VirtualDB (instead of MongoDB) was used in running the JUnit tests // VirtualDB (instead of MongoDB) was used in running the JUnit tests
// to avoid Maven compilation errors. Set flag to true to run the // to avoid Maven compilation errors. Set flag to true to run the
// tests with MongoDB (provided that MongoDB is installed and socket // tests with MongoDB (provided that MongoDB is installed and socket
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
* <p> * <p>
* Could be done with mock objects as well where the call method call is verified. * Could be done with mock objects as well where the call method call is verified.
*/ */
public class CallbackTest { class CallbackTest {
private Integer callingCount = 0; private Integer callingCount = 0;
@@ -34,7 +34,7 @@ import org.slf4j.LoggerFactory;
/** /**
* App Test showing usage of circuit breaker. * App Test showing usage of circuit breaker.
*/ */
public class AppTest { class AppTest {
private static final Logger LOGGER = LoggerFactory.getLogger(AppTest.class); private static final Logger LOGGER = LoggerFactory.getLogger(AppTest.class);
@@ -60,7 +60,7 @@ public class AppTest {
* and retry time period of 2 seconds. * and retry time period of 2 seconds.
*/ */
@BeforeEach @BeforeEach
public void setupCircuitBreakers() { void setupCircuitBreakers() {
var delayedService = new DelayedRemoteService(System.nanoTime(), STARTUP_DELAY); var delayedService = new DelayedRemoteService(System.nanoTime(), STARTUP_DELAY);
//Set the circuit Breaker parameters //Set the circuit Breaker parameters
delayedServiceCircuitBreaker = new DefaultCircuitBreaker(delayedService, 3000, delayedServiceCircuitBreaker = new DefaultCircuitBreaker(delayedService, 3000,
@@ -78,7 +78,7 @@ public class AppTest {
} }
@Test @Test
public void testFailure_OpenStateTransition() { void testFailure_OpenStateTransition() {
//Calling delayed service, which will be unhealthy till 4 seconds //Calling delayed service, which will be unhealthy till 4 seconds
assertEquals("Delayed service is down", monitoringService.delayedServiceResponse()); assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
//As failure threshold is "1", the circuit breaker is changed to OPEN //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -93,7 +93,7 @@ public class AppTest {
} }
@Test @Test
public void testFailure_HalfOpenStateTransition() { void testFailure_HalfOpenStateTransition() {
//Calling delayed service, which will be unhealthy till 4 seconds //Calling delayed service, which will be unhealthy till 4 seconds
assertEquals("Delayed service is down", monitoringService.delayedServiceResponse()); assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
//As failure threshold is "1", the circuit breaker is changed to OPEN //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -112,7 +112,7 @@ public class AppTest {
} }
@Test @Test
public void testRecovery_ClosedStateTransition() { void testRecovery_ClosedStateTransition() {
//Calling delayed service, which will be unhealthy till 4 seconds //Calling delayed service, which will be unhealthy till 4 seconds
assertEquals("Delayed service is down", monitoringService.delayedServiceResponse()); assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
//As failure threshold is "1", the circuit breaker is changed to OPEN //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Circuit Breaker test * Circuit Breaker test
*/ */
public class DefaultCircuitBreakerTest { class DefaultCircuitBreakerTest {
//long timeout, int failureThreshold, long retryTimePeriod //long timeout, int failureThreshold, long retryTimePeriod
@Test @Test
@@ -53,7 +53,7 @@ class DelayedRemoteServiceTest {
* @throws RemoteServiceException * @throws RemoteServiceException
*/ */
@Test @Test
public void testParameterizedConstructor() throws RemoteServiceException { void testParameterizedConstructor() throws RemoteServiceException {
var obj = new DelayedRemoteService(System.nanoTime()-2000*1000*1000,1); var obj = new DelayedRemoteService(System.nanoTime()-2000*1000*1000,1);
assertEquals("Delayed service is working",obj.call()); assertEquals("Delayed service is working",obj.call());
} }
@@ -58,7 +58,7 @@ import static org.mockito.Mockito.*;
* Unit test for Function class. * Unit test for Function class.
*/ */
@ExtendWith(MockitoExtension.class) @ExtendWith(MockitoExtension.class)
public class UsageCostProcessorFunctionTest { class UsageCostProcessorFunctionTest {
@Mock @Mock
MessageHandlerUtility<UsageDetail> mockMessageHandlerUtilityForUsageADetail; MessageHandlerUtility<UsageDetail> mockMessageHandlerUtilityForUsageADetail;
@@ -74,7 +74,7 @@ public class UsageCostProcessorFunctionTest {
UsageCostProcessorFunction usageCostProcessorFunction; UsageCostProcessorFunction usageCostProcessorFunction;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
var messageBodyUsageDetail = new MessageBody<UsageDetail>(); var messageBodyUsageDetail = new MessageBody<UsageDetail>();
var usageDetailsList = new ArrayList<UsageDetail>(); var usageDetailsList = new ArrayList<UsageDetail>();
@@ -122,7 +122,7 @@ public class UsageCostProcessorFunctionTest {
* Unit test for HttpTriggerJava method. * Unit test for HttpTriggerJava method.
*/ */
@Test @Test
public void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception { void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
// Setup // Setup
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
@@ -148,7 +148,7 @@ public class UsageCostProcessorFunctionTest {
} }
@Test @Test
public void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception { void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
// Setup // Setup
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
final HttpRequestMessage<Optional<String>> req = mock(HttpRequestMessage.class); final HttpRequestMessage<Optional<String>> req = mock(HttpRequestMessage.class);
@@ -52,7 +52,7 @@ import static org.mockito.Mockito.*;
* Unit test for Function class. * Unit test for Function class.
*/ */
@ExtendWith(MockitoExtension.class) @ExtendWith(MockitoExtension.class)
public class UsageDetailPublisherFunctionTest { class UsageDetailPublisherFunctionTest {
@Mock @Mock
MessageHandlerUtility<UsageDetail> mockMessageHandlerUtility; MessageHandlerUtility<UsageDetail> mockMessageHandlerUtility;
@Mock @Mock
@@ -65,7 +65,7 @@ public class UsageDetailPublisherFunctionTest {
* Unit test for HttpTriggerJava method. * Unit test for HttpTriggerJava method.
*/ */
@Test @Test
public void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception { void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
// Setup // Setup
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
@@ -91,7 +91,7 @@ public class UsageDetailPublisherFunctionTest {
} }
@Test @Test
public void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception { void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
// Setup // Setup
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
@@ -40,7 +40,7 @@ import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension; import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class) @ExtendWith(MockitoExtension.class)
public class EventHandlerUtilityTest { class EventHandlerUtilityTest {
@Mock @Mock
EventGridPublisherClient<BinaryData> mockCustomEventClient; EventGridPublisherClient<BinaryData> mockCustomEventClient;
@@ -49,7 +49,7 @@ public class EventHandlerUtilityTest {
EventHandlerUtility<Message<UsageDetail>> eventHandlerUtility; EventHandlerUtility<Message<UsageDetail>> eventHandlerUtility;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
System.setProperty("EventGridURL", "https://www.dummyEndpoint.com/api/events"); System.setProperty("EventGridURL", "https://www.dummyEndpoint.com/api/events");
System.setProperty("EventGridKey", "EventGridURL"); System.setProperty("EventGridKey", "EventGridURL");
@@ -46,7 +46,7 @@ import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.*; import static org.mockito.Mockito.*;
@ExtendWith(MockitoExtension.class) @ExtendWith(MockitoExtension.class)
public class MessageHandlerUtilityTest { class MessageHandlerUtilityTest {
@Mock @Mock
private BlobClient mockBlobClient; private BlobClient mockBlobClient;
@@ -63,7 +63,7 @@ public class MessageHandlerUtilityTest {
private MessageReference messageReference; private MessageReference messageReference;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
System.setProperty("BlobStorageConnectionString", "https://www.dummyEndpoint.com/api/blobs"); System.setProperty("BlobStorageConnectionString", "https://www.dummyEndpoint.com/api/blobs");
var messageBody = new MessageBody<UsageDetail>(); var messageBody = new MessageBody<UsageDetail>();
@@ -39,7 +39,7 @@ import static org.junit.Assert.*;
and https://stackoverflow.com/questions/50211433/servlets-unit-testing and https://stackoverflow.com/questions/50211433/servlets-unit-testing
*/ */
public class AppServletTest extends Mockito{ class AppServletTest extends Mockito{
private String msgPartOne = "<h1>This Server Doesn't Support"; private String msgPartOne = "<h1>This Server Doesn't Support";
private String msgPartTwo = "Requests</h1>\n" private String msgPartTwo = "Requests</h1>\n"
+ "<h2>Use a GET request with boolean values for the following parameters<h2>\n" + "<h2>Use a GET request with boolean values for the following parameters<h2>\n"
@@ -47,7 +47,7 @@ public class AppServletTest extends Mockito{
private String destination = "newsDisplay.jsp"; private String destination = "newsDisplay.jsp";
@Test @Test
public void testDoGet() throws Exception { void testDoGet() throws Exception {
HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class); HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class); HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
RequestDispatcher mockDispatcher = Mockito.mock(RequestDispatcher.class); RequestDispatcher mockDispatcher = Mockito.mock(RequestDispatcher.class);
@@ -64,7 +64,7 @@ public class AppServletTest extends Mockito{
} }
@Test @Test
public void testDoPost() throws Exception { void testDoPost() throws Exception {
HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class); HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class); HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
StringWriter stringWriter = new StringWriter(); StringWriter stringWriter = new StringWriter();
@@ -78,7 +78,7 @@ public class AppServletTest extends Mockito{
} }
@Test @Test
public void testDoPut() throws Exception { void testDoPut() throws Exception {
HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class); HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class); HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
StringWriter stringWriter = new StringWriter(); StringWriter stringWriter = new StringWriter();
@@ -92,7 +92,7 @@ public class AppServletTest extends Mockito{
} }
@Test @Test
public void testDoDelete() throws Exception { void testDoDelete() throws Exception {
HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class); HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class); HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
StringWriter stringWriter = new StringWriter(); StringWriter stringWriter = new StringWriter();
@@ -30,9 +30,9 @@ import org.mockito.Mockito;
import static org.junit.Assert.*; import static org.junit.Assert.*;
public class JavaBeansTest { class JavaBeansTest {
@Test @Test
public void testDefaultConstructor() { void testDefaultConstructor() {
ClientPropertiesBean newBean = new ClientPropertiesBean(); ClientPropertiesBean newBean = new ClientPropertiesBean();
assertEquals("DEFAULT_NAME", newBean.getName()); assertEquals("DEFAULT_NAME", newBean.getName());
assertTrue(newBean.isBusinessInterest()); assertTrue(newBean.isBusinessInterest());
@@ -43,7 +43,7 @@ public class JavaBeansTest {
} }
@Test @Test
public void testNameGetterSetter() { void testNameGetterSetter() {
ClientPropertiesBean newBean = new ClientPropertiesBean(); ClientPropertiesBean newBean = new ClientPropertiesBean();
assertEquals("DEFAULT_NAME", newBean.getName()); assertEquals("DEFAULT_NAME", newBean.getName());
newBean.setName("TEST_NAME_ONE"); newBean.setName("TEST_NAME_ONE");
@@ -51,7 +51,7 @@ public class JavaBeansTest {
} }
@Test @Test
public void testBusinessSetterGetter() { void testBusinessSetterGetter() {
ClientPropertiesBean newBean = new ClientPropertiesBean(); ClientPropertiesBean newBean = new ClientPropertiesBean();
assertTrue(newBean.isBusinessInterest()); assertTrue(newBean.isBusinessInterest());
newBean.setBusinessInterest(false); newBean.setBusinessInterest(false);
@@ -59,7 +59,7 @@ public class JavaBeansTest {
} }
@Test @Test
public void testScienceSetterGetter() { void testScienceSetterGetter() {
ClientPropertiesBean newBean = new ClientPropertiesBean(); ClientPropertiesBean newBean = new ClientPropertiesBean();
assertTrue(newBean.isScienceNewsInterest()); assertTrue(newBean.isScienceNewsInterest());
newBean.setScienceNewsInterest(false); newBean.setScienceNewsInterest(false);
@@ -67,7 +67,7 @@ public class JavaBeansTest {
} }
@Test @Test
public void testSportsSetterGetter() { void testSportsSetterGetter() {
ClientPropertiesBean newBean = new ClientPropertiesBean(); ClientPropertiesBean newBean = new ClientPropertiesBean();
assertTrue(newBean.isSportsInterest()); assertTrue(newBean.isSportsInterest());
newBean.setSportsInterest(false); newBean.setSportsInterest(false);
@@ -75,7 +75,7 @@ public class JavaBeansTest {
} }
@Test @Test
public void testWorldSetterGetter() { void testWorldSetterGetter() {
ClientPropertiesBean newBean = new ClientPropertiesBean(); ClientPropertiesBean newBean = new ClientPropertiesBean();
assertTrue(newBean.isWorldNewsInterest()); assertTrue(newBean.isWorldNewsInterest());
newBean.setWorldNewsInterest(false); newBean.setWorldNewsInterest(false);
@@ -83,7 +83,7 @@ public class JavaBeansTest {
} }
@Test @Test
public void testRequestConstructor(){ void testRequestConstructor(){
HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class); HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
ClientPropertiesBean newBean = new ClientPropertiesBean((mockReq)); ClientPropertiesBean newBean = new ClientPropertiesBean((mockReq));
assertEquals("DEFAULT_NAME", newBean.getName()); assertEquals("DEFAULT_NAME", newBean.getName());
@@ -70,7 +70,7 @@ class DbCustomerDaoTest {
* Represents the scenario where DB connectivity is present. * Represents the scenario where DB connectivity is present.
*/ */
@Nested @Nested
public class ConnectionSuccess { class ConnectionSuccess {
/** /**
* Setup for connection success scenario. * Setup for connection success scenario.
@@ -78,7 +78,7 @@ class DbCustomerDaoTest {
* @throws Exception if any error occurs. * @throws Exception if any error occurs.
*/ */
@BeforeEach @BeforeEach
public void setUp() throws Exception { void setUp() throws Exception {
var dataSource = new JdbcDataSource(); var dataSource = new JdbcDataSource();
dataSource.setURL(DB_URL); dataSource.setURL(DB_URL);
dao = new DbCustomerDao(dataSource); dao = new DbCustomerDao(dataSource);
@@ -191,7 +191,7 @@ class DbCustomerDaoTest {
* @throws SQLException if any error occurs. * @throws SQLException if any error occurs.
*/ */
@BeforeEach @BeforeEach
public void setUp() throws SQLException { void setUp() throws SQLException {
dao = new DbCustomerDao(mockedDatasource()); dao = new DbCustomerDao(mockedDatasource());
} }
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ContentTest { class ContentTest {
@Test @Test
void testToString() { void testToString() {
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class MenuItemTest { class MenuItemTest {
@Test @Test
void testToString() { void testToString() {
@@ -49,7 +49,7 @@ import org.mockito.ArgumentCaptor;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class DispatcherTest { class DispatcherTest {
/** /**
* Dispatcher is a singleton with no way to reset it's internal state back to the beginning. * Dispatcher is a singleton with no way to reset it's internal state back to the beginning.
@@ -57,7 +57,7 @@ public class DispatcherTest {
* influence on each other. * influence on each other.
*/ */
@BeforeEach @BeforeEach
public void setUp() throws Exception { void setUp() throws Exception {
final var constructor = Dispatcher.class.getDeclaredConstructor(); final var constructor = Dispatcher.class.getDeclaredConstructor();
constructor.setAccessible(true); constructor.setAccessible(true);
@@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ContentStoreTest { class ContentStoreTest {
@Test @Test
void testOnAction() { void testOnAction() {
@@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class MenuStoreTest { class MenuStoreTest {
@Test @Test
void testOnAction() { void testOnAction() {
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ContentViewTest { class ContentViewTest {
@Test @Test
void testStoreChanged() { void testStoreChanged() {
@@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class MenuViewTest { class MenuViewTest {
@Test @Test
void testStoreChanged() { void testStoreChanged() {
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class AlchemistShopTest { class AlchemistShopTest {
@Test @Test
void testShop() { void testShop() {
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ApplicationExceptionTest { class ApplicationExceptionTest {
@Test @Test
void testCause() { void testCause() {
@@ -38,17 +38,17 @@ import org.junit.jupiter.params.provider.MethodSource;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class CommandTest { class CommandTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -66,7 +66,7 @@ public class CommandTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testDisplay(String request, String displayMessage) { void testDisplay(String request, String displayMessage) {
final var frontController = new FrontController(); final var frontController = new FrontController();
assertEquals(0, appender.getLogSize()); assertEquals(0, appender.getLogSize());
frontController.handleRequest(request); frontController.handleRequest(request);
@@ -38,17 +38,17 @@ import org.junit.jupiter.params.provider.MethodSource;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class FrontControllerTest { class FrontControllerTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -66,7 +66,7 @@ public class FrontControllerTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testDisplay(Command command, String displayMessage) { void testDisplay(Command command, String displayMessage) {
assertEquals(0, appender.getLogSize()); assertEquals(0, appender.getLogSize());
command.process(); command.process();
assertEquals(displayMessage, appender.getLastMessage()); assertEquals(displayMessage, appender.getLastMessage());
@@ -38,17 +38,17 @@ import org.junit.jupiter.params.provider.MethodSource;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ViewTest { class ViewTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -66,7 +66,7 @@ public class ViewTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testDisplay(View view, String displayMessage) { void testDisplay(View view, String displayMessage) {
assertEquals(0, appender.getLogSize()); assertEquals(0, appender.getLogSize());
view.display(); view.display();
assertEquals(displayMessage, appender.getLastMessage()); assertEquals(displayMessage, appender.getLastMessage());
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
/** /**
* App unit test class. * App unit test class.
*/ */
public class AppTest { class AppTest {
@Test @Test
void shouldExecuteApplicationWithoutException() { void shouldExecuteApplicationWithoutException() {
@@ -33,17 +33,17 @@ import org.junit.jupiter.api.BeforeEach;
/** /**
* FixedStepGameLoop unit test class. * FixedStepGameLoop unit test class.
*/ */
public class FixedStepGameLoopTest { class FixedStepGameLoopTest {
private FixedStepGameLoop gameLoop; private FixedStepGameLoop gameLoop;
@BeforeEach @BeforeEach
public void setup() { void setup() {
gameLoop = new FixedStepGameLoop(); gameLoop = new FixedStepGameLoop();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
gameLoop = null; gameLoop = null;
} }
@@ -35,12 +35,12 @@ class GameControllerTest {
private GameController controller; private GameController controller;
@BeforeEach @BeforeEach
public void setup() { void setup() {
controller = new GameController(); controller = new GameController();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
controller = null; controller = null;
} }
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Test for Guarded Queue * Test for Guarded Queue
*/ */
public class GuardedQueueTest { class GuardedQueueTest {
private volatile Integer value; private volatile Integer value;
@Test @Test
@@ -44,12 +44,12 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class AsynchronousServiceTest { class AsynchronousServiceTest {
private AsynchronousService service; private AsynchronousService service;
private AsyncTask<Object> task; private AsyncTask<Object> task;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
service = new AsynchronousService(new LinkedBlockingQueue<>()); service = new AsynchronousService(new LinkedBlockingQueue<>());
task = mock(AsyncTask.class); task = mock(AsyncTask.class);
} }
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class FilterManagerTest { class FilterManagerTest {
@Test @Test
void testFilterRequest() { void testFilterRequest() {
@@ -38,7 +38,7 @@ import org.junit.jupiter.params.provider.MethodSource;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class FilterTest { class FilterTest {
private static final Order PERFECT_ORDER = private static final Order PERFECT_ORDER =
new Order("name", "12345678901", "addr", "dep", "order"); new Order("name", "12345678901", "addr", "dep", "order");
@@ -89,7 +89,7 @@ public class FilterTest {
@ParameterizedTest @ParameterizedTest
@MethodSource("getTestData") @MethodSource("getTestData")
public void testExecute(Filter filter, Order order, String expectedResult) { void testExecute(Filter filter, Order order, String expectedResult) {
final var result = filter.execute(order); final var result = filter.execute(order);
assertNotNull(result); assertNotNull(result);
assertEquals(expectedResult, result.trim()); assertEquals(expectedResult, result.trim());
@@ -97,7 +97,7 @@ public class FilterTest {
@ParameterizedTest @ParameterizedTest
@MethodSource("getTestData") @MethodSource("getTestData")
public void testNext(Filter filter) { void testNext(Filter filter) {
assertNull(filter.getNext()); assertNull(filter.getNext());
assertSame(filter, filter.getLast()); assertSame(filter, filter.getLast());
} }
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class OrderTest { class OrderTest {
private static final String EXPECTED_VALUE = "test"; private static final String EXPECTED_VALUE = "test";
@@ -102,7 +102,7 @@ public abstract class ExpressionTest<E extends Expression> {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("expressionProvider") @MethodSource("expressionProvider")
public void testInterpret(NumberExpression first, NumberExpression second, int result) { void testInterpret(NumberExpression first, NumberExpression second, int result) {
final var expression = factory.apply(first, second); final var expression = factory.apply(first, second);
assertNotNull(expression); assertNotNull(expression);
assertEquals(result, expression.interpret()); assertEquals(result, expression.interpret());
@@ -113,7 +113,7 @@ public abstract class ExpressionTest<E extends Expression> {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("expressionProvider") @MethodSource("expressionProvider")
public void testToString(NumberExpression first, NumberExpression second) { void testToString(NumberExpression first, NumberExpression second) {
final var expression = factory.apply(first, second); final var expression = factory.apply(first, second);
assertNotNull(expression); assertNotNull(expression);
assertEquals(expectedToString, expression.toString()); assertEquals(expectedToString, expression.toString());
@@ -32,7 +32,7 @@ import org.junit.jupiter.params.provider.Arguments;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class MinusExpressionTest extends ExpressionTest<MinusExpression> { class MinusExpressionTest extends ExpressionTest<MinusExpression> {
/** /**
* Create a new set of test entries with the expected result * Create a new set of test entries with the expected result
@@ -32,7 +32,7 @@ import org.junit.jupiter.params.provider.Arguments;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class MultiplyExpressionTest extends ExpressionTest<MultiplyExpression> { class MultiplyExpressionTest extends ExpressionTest<MultiplyExpression> {
/** /**
* Create a new set of test entries with the expected result * Create a new set of test entries with the expected result
@@ -36,7 +36,7 @@ import org.junit.jupiter.params.provider.MethodSource;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class NumberExpressionTest extends ExpressionTest<NumberExpression> { class NumberExpressionTest extends ExpressionTest<NumberExpression> {
/** /**
* Create a new set of test entries with the expected result * Create a new set of test entries with the expected result
@@ -60,7 +60,7 @@ public class NumberExpressionTest extends ExpressionTest<NumberExpression> {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("expressionProvider") @MethodSource("expressionProvider")
public void testFromString(NumberExpression first) throws Exception { void testFromString(NumberExpression first) throws Exception {
final var expectedValue = first.interpret(); final var expectedValue = first.interpret();
final var testStringValue = String.valueOf(expectedValue); final var testStringValue = String.valueOf(expectedValue);
final var numberExpression = new NumberExpression(testStringValue); final var numberExpression = new NumberExpression(testStringValue);
@@ -32,7 +32,7 @@ import org.junit.jupiter.params.provider.Arguments;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class PlusExpressionTest extends ExpressionTest<PlusExpression> { class PlusExpressionTest extends ExpressionTest<PlusExpression> {
/** /**
* Create a new set of test entries with the expected result * Create a new set of test entries with the expected result
@@ -37,7 +37,7 @@ import org.junit.jupiter.params.provider.MethodSource;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class TreasureChestTest { class TreasureChestTest {
/** /**
* Create a list of all expected items in the chest. * Create a list of all expected items in the chest.
@@ -65,7 +65,7 @@ public class TreasureChestTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testIterator(Item expectedItem) { void testIterator(Item expectedItem) {
final var chest = new TreasureChest(); final var chest = new TreasureChest();
final var iterator = chest.iterator(expectedItem.getType()); final var iterator = chest.iterator(expectedItem.getType());
assertNotNull(iterator); assertNotNull(iterator);
@@ -92,7 +92,7 @@ public class TreasureChestTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testGetItems(Item expectedItem) throws Exception { void testGetItems(Item expectedItem) throws Exception {
final var chest = new TreasureChest(); final var chest = new TreasureChest();
final var items = chest.getItems(); final var items = chest.getItems();
assertNotNull(items); assertNotNull(items);
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class CakeTest { class CakeTest {
@Test @Test
void testSetId() { void testSetId() {
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class CakeBakingExceptionTest { class CakeBakingExceptionTest {
@Test @Test
void testConstructor() { void testConstructor() {
@@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class CakeBakingServiceImplTest { class CakeBakingServiceImplTest {
@Test @Test
void testLayers() { void testLayers() {
@@ -47,17 +47,17 @@ import org.slf4j.LoggerFactory;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class CakeViewImplTest { class CakeViewImplTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(CakeViewImpl.class); appender = new InMemoryAppender(CakeViewImpl.class);
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -31,7 +31,7 @@ import java.lang.reflect.Field;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class HolderNaiveTest extends AbstractHolderTest { class HolderNaiveTest extends AbstractHolderTest {
private final HolderNaive holder = new HolderNaive(); private final HolderNaive holder = new HolderNaive();
@@ -31,7 +31,7 @@ import java.lang.reflect.Field;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class HolderThreadSafeTest extends AbstractHolderTest { class HolderThreadSafeTest extends AbstractHolderTest {
private final HolderThreadSafe holder = new HolderThreadSafe(); private final HolderThreadSafe holder = new HolderThreadSafe();
@@ -32,7 +32,7 @@ import java.util.function.Supplier;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class Java8HolderTest extends AbstractHolderTest { class Java8HolderTest extends AbstractHolderTest {
private final Java8Holder holder = new Java8Holder(); private final Java8Holder holder = new Java8Holder();
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Message test case. * Message test case.
*/ */
public class MessageTest { class MessageTest {
@Test @Test
void testGetType() { void testGetType() {
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
/** /**
* BullyMessageManager unit test. * BullyMessageManager unit test.
*/ */
public class BullyMessageManagerTest { class BullyMessageManagerTest {
@Test @Test
void testSendHeartbeatMessage() { void testSendHeartbeatMessage() {
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
/** /**
* BullyInstance unit test. * BullyInstance unit test.
*/ */
public class BullyinstanceTest { class BullyinstanceTest {
@Test @Test
void testOnMessage() { void testOnMessage() {
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
/** /**
* RingInstance unit test. * RingInstance unit test.
*/ */
public class RingInstanceTest { class RingInstanceTest {
@Test @Test
void testOnMessage() { void testOnMessage() {
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
/** /**
* RingMessageManager unit test. * RingMessageManager unit test.
*/ */
public class RingMessageManagerTest { class RingMessageManagerTest {
@Test @Test
void testSendHeartbeatMessage() { void testSendHeartbeatMessage() {
+1 -1
View File
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Thief test * Thief test
*/ */
public class ThiefTest { class ThiefTest {
@Test @Test
void testThief() { void testThief() {
var thief = new Thief(); var thief = new Thief();
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class PartyImplTest { class PartyImplTest {
/** /**
* Verify if a member is notified when it's joining a party. Generate an action and see if the * Verify if a member is notified when it's joining a party. Generate an action and see if the
@@ -47,7 +47,7 @@ import org.slf4j.LoggerFactory;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class PartyMemberTest { class PartyMemberTest {
static Stream<Arguments> dataProvider() { static Stream<Arguments> dataProvider() {
return Stream.of( return Stream.of(
@@ -61,12 +61,12 @@ public class PartyMemberTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(PartyMemberBase.class); appender = new InMemoryAppender(PartyMemberBase.class);
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -75,7 +75,7 @@ public class PartyMemberTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testPartyAction(Supplier<PartyMember> memberSupplier) { void testPartyAction(Supplier<PartyMember> memberSupplier) {
final var member = memberSupplier.get(); final var member = memberSupplier.get();
for (final var action : Action.values()) { for (final var action : Action.values()) {
@@ -91,7 +91,7 @@ public class PartyMemberTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testAct(Supplier<PartyMember> memberSupplier) { void testAct(Supplier<PartyMember> memberSupplier) {
final var member = memberSupplier.get(); final var member = memberSupplier.get();
member.act(Action.GOLD); member.act(Action.GOLD);
@@ -115,7 +115,7 @@ public class PartyMemberTest {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testToString(Supplier<PartyMember> memberSupplier) { void testToString(Supplier<PartyMember> memberSupplier) {
final var member = memberSupplier.get(); final var member = memberSupplier.get();
final var memberClass = member.getClass(); final var memberClass = member.getClass();
assertEquals(memberClass.getSimpleName(), member.toString()); assertEquals(memberClass.getSimpleName(), member.toString());
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class StarTest { class StarTest {
/** /**
* Verify the stages of a dying sun, without going back in time * Verify the stages of a dying sun, without going back in time
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class GiantControllerTest { class GiantControllerTest {
/** /**
* Verify if the controller passes the health level through to the model and vice versa * Verify if the controller passes the health level through to the model and vice versa
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class GiantModelTest { class GiantModelTest {
/** /**
* Verify if the health value is set properly though the constructor and setter * Verify if the health value is set properly though the constructor and setter
@@ -42,17 +42,17 @@ import org.slf4j.LoggerFactory;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class GiantViewTest { class GiantViewTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(GiantView.class); appender = new InMemoryAppender(GiantView.class);
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class FileLoaderTest { class FileLoaderTest {
@Test @Test
void testLoadData() { void testLoadData() {
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
* This test case is responsible for testing our application by taking advantage of the * This test case is responsible for testing our application by taking advantage of the
* Model-View-Controller architectural pattern. * Model-View-Controller architectural pattern.
*/ */
public class FileSelectorPresenterTest { class FileSelectorPresenterTest {
/** /**
* The Presenter component. * The Presenter component.
@@ -57,7 +57,7 @@ public class FileSelectorPresenterTest {
* Initializes the components of the test case. * Initializes the components of the test case.
*/ */
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
this.stub = new FileSelectorStub(); this.stub = new FileSelectorStub();
this.loader = new FileLoader(); this.loader = new FileLoader();
presenter = new FileSelectorPresenter(this.stub); presenter = new FileSelectorPresenter(this.stub);
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Test for Monad Pattern * Test for Monad Pattern
*/ */
public class MonadTest { class MonadTest {
@Test @Test
void testForInvalidName() { void testForInvalidName() {
@@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.*; import static org.junit.jupiter.api.Assertions.*;
import static org.junit.jupiter.api.Assumptions.*; import static org.junit.jupiter.api.Assumptions.*;
public class BankTest { class BankTest {
private static final int ACCOUNT_NUM = 4; private static final int ACCOUNT_NUM = 4;
private static final int BASE_AMOUNT = 1000; private static final int BASE_AMOUNT = 1000;
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class LoadBalancerTest { class LoadBalancerTest {
@Test @Test
void testSameStateAmongstAllInstances() { void testSameStateAmongstAllInstances() {
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class NazgulTest { class NazgulTest {
/** /**
* Verify if {@link Nazgul#getInstance(NazgulName)} returns the correct Nazgul multiton instance * Verify if {@link Nazgul#getInstance(NazgulName)} returns the correct Nazgul multiton instance
@@ -33,17 +33,17 @@ import org.junit.Test;
/** /**
* Test for SimpleObject * Test for SimpleObject
*/ */
public class SimpleObjectTest { class SimpleObjectTest {
SimpleObject simpleObject; SimpleObject simpleObject;
@Before @Before
public void setUp() { void setUp() {
simpleObject = new SimpleObject(); simpleObject = new SimpleObject();
} }
@Test @Test
public void testName() { void testName() {
// given // given
String name = "Foobar"; String name = "Foobar";
assertNull(simpleObject.getName()); assertNull(simpleObject.getName());
@@ -41,7 +41,7 @@ import org.junit.Test;
/** /**
* Test for SimpleObjects * Test for SimpleObjects
*/ */
public class SimpleObjectsTest { class SimpleObjectsTest {
@Rule @Rule
public JUnitRuleMockery2 context = JUnitRuleMockery2.createFor(Mode.INTERFACES_AND_CLASSES); public JUnitRuleMockery2 context = JUnitRuleMockery2.createFor(Mode.INTERFACES_AND_CLASSES);
@@ -52,13 +52,13 @@ public class SimpleObjectsTest {
SimpleObjects simpleObjects; SimpleObjects simpleObjects;
@Before @Before
public void setUp() { void setUp() {
simpleObjects = new SimpleObjects(); simpleObjects = new SimpleObjects();
simpleObjects.container = mockContainer; simpleObjects.container = mockContainer;
} }
@Test @Test
public void testCreate() { void testCreate() {
// given // given
final SimpleObject simpleObject = new SimpleObject(); final SimpleObject simpleObject = new SimpleObject();
@@ -85,7 +85,7 @@ public class SimpleObjectsTest {
} }
@Test @Test
public void testListAll() { void testListAll() {
// given // given
final List<SimpleObject> all = Lists.newArrayList(); final List<SimpleObject> all = Lists.newArrayList();
@@ -44,17 +44,17 @@ import org.slf4j.LoggerFactory;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class TreeTest { class TreeTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Generation of Royalty Types using the object-mother * Test Generation of Royalty Types using the object-mother
*/ */
public class RoyaltyObjectMotherTest { class RoyaltyObjectMotherTest {
@Test @Test
void unsuccessfulKingFlirt() { void unsuccessfulKingFlirt() {
@@ -32,7 +32,7 @@ import java.util.List;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class HobbitsTest extends WeatherObserverTest<Hobbits> { class HobbitsTest extends WeatherObserverTest<Hobbits> {
@Override @Override
public Collection<Object[]> dataProvider() { public Collection<Object[]> dataProvider() {
@@ -32,7 +32,7 @@ import java.util.List;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class OrcsTest extends WeatherObserverTest<Orcs> { class OrcsTest extends WeatherObserverTest<Orcs> {
@Override @Override
public Collection<Object[]> dataProvider() { public Collection<Object[]> dataProvider() {
@@ -50,12 +50,12 @@ public abstract class WeatherObserverTest<O extends WeatherObserver> {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -80,7 +80,7 @@ public abstract class WeatherObserverTest<O extends WeatherObserver> {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testObserver(WeatherType weather, String response) { void testObserver(WeatherType weather, String response) {
final var observer = this.factory.get(); final var observer = this.factory.get();
assertEquals(0, appender.getLogSize()); assertEquals(0, appender.getLogSize());
@@ -41,17 +41,17 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class WeatherTest { class WeatherTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(Weather.class); appender = new InMemoryAppender(Weather.class);
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -34,7 +34,7 @@ import java.util.List;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class GHobbitsTest extends ObserverTest<GHobbits> { class GHobbitsTest extends ObserverTest<GHobbits> {
@Override @Override
public Collection<Object[]> dataProvider() { public Collection<Object[]> dataProvider() {
@@ -43,17 +43,17 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class GWeatherTest { class GWeatherTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(GWeather.class); appender = new InMemoryAppender(GWeather.class);
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -49,12 +49,12 @@ public abstract class ObserverTest<O extends Observer<?, ?, WeatherType>> {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -79,7 +79,7 @@ public abstract class ObserverTest<O extends Observer<?, ?, WeatherType>> {
*/ */
@ParameterizedTest @ParameterizedTest
@MethodSource("dataProvider") @MethodSource("dataProvider")
public void testObserver(WeatherType weather, String response) { void testObserver(WeatherType weather, String response) {
final var observer = this.factory.get(); final var observer = this.factory.get();
assertEquals(0, appender.getLogSize()); assertEquals(0, appender.getLogSize());
@@ -34,7 +34,7 @@ import java.util.List;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class OrcsTest extends ObserverTest<GOrcs> { class OrcsTest extends ObserverTest<GOrcs> {
@Override @Override
public Collection<Object[]> dataProvider() { public Collection<Object[]> dataProvider() {
@@ -34,12 +34,12 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Album Selection and Album Listing * Test Album Selection and Album Listing
*/ */
public class AlbumListPageTest { class AlbumListPageTest {
private final AlbumListPage albumListPage = new AlbumListPage(new WebClient()); private final AlbumListPage albumListPage = new AlbumListPage(new WebClient());
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
albumListPage.navigateToPage(); albumListPage.navigateToPage();
} }
@@ -34,12 +34,12 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Album Page Operations * Test Album Page Operations
*/ */
public class AlbumPageTest { class AlbumPageTest {
private final AlbumPage albumPage = new AlbumPage(new WebClient()); private final AlbumPage albumPage = new AlbumPage(new WebClient());
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
albumPage.navigateToPage(); albumPage.navigateToPage();
} }
@@ -34,12 +34,12 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Login Page Object * Test Login Page Object
*/ */
public class LoginPageTest { class LoginPageTest {
private final LoginPage loginPage = new LoginPage(new WebClient()); private final LoginPage loginPage = new LoginPage(new WebClient());
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
loginPage.navigateToPage(); loginPage.navigateToPage();
} }
@@ -33,12 +33,12 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Album Selection and Album Listing * Test Album Selection and Album Listing
*/ */
public class AlbumListPageTest { class AlbumListPageTest {
private final AlbumListPage albumListPage = new AlbumListPage(new WebClient()); private final AlbumListPage albumListPage = new AlbumListPage(new WebClient());
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
albumListPage.navigateToPage(); albumListPage.navigateToPage();
} }
@@ -33,12 +33,12 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Album Page Operations * Test Album Page Operations
*/ */
public class AlbumPageTest { class AlbumPageTest {
private final AlbumPage albumPage = new AlbumPage(new WebClient()); private final AlbumPage albumPage = new AlbumPage(new WebClient());
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
albumPage.navigateToPage(); albumPage.navigateToPage();
} }
@@ -33,12 +33,12 @@ import org.junit.jupiter.api.Test;
/** /**
* Test Login Page Object * Test Login Page Object
*/ */
public class LoginPageTest { class LoginPageTest {
private final LoginPage loginPage = new LoginPage(new WebClient()); private final LoginPage loginPage = new LoginPage(new WebClient());
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
loginPage.navigateToPage(); loginPage.navigateToPage();
} }
@@ -35,7 +35,7 @@ class ParameterObjectTest {
private static final Logger LOGGER = LoggerFactory.getLogger(ParameterObjectTest.class); private static final Logger LOGGER = LoggerFactory.getLogger(ParameterObjectTest.class);
@Test @Test
public void testForDefaultSortBy() { void testForDefaultSortBy() {
//Creating parameter object with default value for SortBy set //Creating parameter object with default value for SortBy set
ParameterObject params = ParameterObject.newBuilder() ParameterObject params = ParameterObject.newBuilder()
.withType("sneakers") .withType("sneakers")
@@ -49,7 +49,7 @@ class ParameterObjectTest {
} }
@Test @Test
public void testForDefaultSortOrder() { void testForDefaultSortOrder() {
//Creating parameter object with default value for SortOrder set //Creating parameter object with default value for SortOrder set
ParameterObject params = ParameterObject.newBuilder() ParameterObject params = ParameterObject.newBuilder()
.withType("sneakers") .withType("sneakers")
@@ -37,7 +37,7 @@ class SearchServiceTest {
private SearchService searchService; private SearchService searchService;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
//Creating parameter object with default values set //Creating parameter object with default values set
parameterObject = ParameterObject.newBuilder() parameterObject = ParameterObject.newBuilder()
.withType("sneakers") .withType("sneakers")
@@ -50,7 +50,7 @@ class SearchServiceTest {
* Testing parameter object against the overloaded method to verify if the behaviour is same. * Testing parameter object against the overloaded method to verify if the behaviour is same.
*/ */
@Test @Test
public void testDefaultParametersMatch() { void testDefaultParametersMatch() {
assertEquals(searchService.search(parameterObject), searchService.search("sneakers", assertEquals(searchService.search(parameterObject), searchService.search("sneakers",
SortOrder.ASC), "Default Parameter values do not not match."); SortOrder.ASC), "Default Parameter values do not not match.");
LOGGER.info("SortBy Default parameter value matches."); LOGGER.info("SortBy Default parameter value matches.");
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Test for {@link Pipeline} * Test for {@link Pipeline}
*/ */
public class PipelineTest { class PipelineTest {
@Test @Test
void testAddHandlersToPipeline() { void testAddHandlersToPipeline() {
@@ -42,17 +42,17 @@ import org.slf4j.LoggerFactory;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ConsumerTest { class ConsumerTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(Consumer.class); appender = new InMemoryAppender(Consumer.class);
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class PoisonMessageTest { class PoisonMessageTest {
@Test @Test
void testAddHeader() { void testAddHeader() {
@@ -41,7 +41,7 @@ import org.mockito.ArgumentCaptor;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ProducerTest { class ProducerTest {
@Test @Test
void testSend() throws Exception { void testSend() throws Exception {
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class SimpleMessageTest { class SimpleMessageTest {
@Test @Test
void testGetHeaders() { void testGetHeaders() {
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Test case for order of messages * Test case for order of messages
*/ */
public class PriorityMessageQueueTest { class PriorityMessageQueueTest {
@Test @Test
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
/** /**
* Check queue manager * Check queue manager
*/ */
public class QueueManagerTest { class QueueManagerTest {
@Test @Test
void publishMessage() { void publishMessage() {
@@ -36,17 +36,17 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ImmutableStewTest { class ImmutableStewTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -36,17 +36,17 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class StewTest { class StewTest {
private InMemoryAppender appender; private InMemoryAppender appender;
@BeforeEach @BeforeEach
public void setUp() { void setUp() {
appender = new InMemoryAppender(); appender = new InMemoryAppender();
} }
@AfterEach @AfterEach
public void tearDown() { void tearDown() {
appender.stop(); appender.stop();
} }
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ConsumerTest { class ConsumerTest {
private static final int ITEM_COUNT = 5; private static final int ITEM_COUNT = 5;
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
* *
* @author Jeroen Meulemeester * @author Jeroen Meulemeester
*/ */
public class ProducerTest { class ProducerTest {
@Test @Test
void testProduce() { void testProduce() {
Loaded 100 of 155 files, more files were not shown because too many files have changed in this diff. Show more