[val] in ecj we were constructing a different type than for javac, when using ‘val’ on an intersection type.

src/eclipseAgent/lombok/eclipse/agent/PatchVal.java

@@ -263,11 +263,15 @@ public class PatchVal {
 				resolved = null;
 			}
 			if (resolved != null) {
-				try {
+				if (resolved.getClass().getSimpleName().startsWith("IntersectionTypeBinding")) {
-					replacement = makeType(resolved, local.type, false);
+					// We intentionally deconstruct these into simply 'Object', because picking an arbitrary type amongst the intersection feels worse.
-					if (!decomponent) init.resolvedType = replacement.resolveType(scope);
+				} else {
-				} catch (Exception e) {
+					try {
-					// Some type thing failed.
+						replacement = makeType(resolved, local.type, false);
+						if (!decomponent) init.resolvedType = replacement.resolveType(scope);
+					} catch (Exception e) {
+						// Some type thing failed.
+					}
 				}
 			}
 		}