tiennm99/lombok
1
0 Fork 0
mirror of https://github.com/tiennm99/lombok.git synced 2026-10-15 20:15:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

[#625] Instead of '31' as a prime number for hashCode(), use something else. 31, probably owing to its inclusion in Effective Java, is overused, as proven by Maaartinus in issue 625. Switching to 277 instead. Also, 1231/1237 pair used for booleans has been replaced by 2591/2609.

Browse Source
This commit is contained in:
Reinier Zwitserloot committed 2014-01-09 21:24:04 +01:00
1 parent 685ddfd52e
commit a40a86ad53
32 files changed
+72 -65
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/transform/resource/after-ecj/DataPlain.java
+4 -4
View File
@@ -31,7 +31,7 @@ import lombok.Data;
return (other instanceof Data1);
}
public @java.lang.Override @java.lang.SuppressWarnings("all") int hashCode() {
final int PRIME = 31;
final int PRIME = 277;
int result = 1;
result = ((result * PRIME) + this.getX());
final java.lang.Object $name = this.getName();
@@ -78,7 +78,7 @@ import lombok.Data;
return (other instanceof Data2);
}
public @java.lang.Override @java.lang.SuppressWarnings("all") int hashCode() {
final int PRIME = 31;
final int PRIME = 277;
int result = 1;
result = ((result * PRIME) + this.getX());
final java.lang.Object $name = this.getName();
@@ -120,7 +120,7 @@ final @Data class Data3 {
return true;
}
public @java.lang.Override @java.lang.SuppressWarnings("all") int hashCode() {
final int PRIME = 31;
final int PRIME = 277;
int result = 1;
result = ((result * PRIME) + this.getX());
final java.lang.Object $name = this.getName();
@@ -167,7 +167,7 @@ final @Data @lombok.EqualsAndHashCode(callSuper = true) class Data4 extends java
return (other instanceof Data4);
}
public @java.lang.Override @java.lang.SuppressWarnings("all") int hashCode() {
final int PRIME = 31;
final int PRIME = 277;
int result = 1;
result = ((result * PRIME) + super.hashCode());
result = ((result * PRIME) + this.getX());