[issue #1615] fixes a bug where equals and hashcode would mess up if both the outer and the inner class have generics, the inner is non-static, and you generate equals/hashcode on the inner.

Note that in general this is just broken; do not put non-static inner classes in generics-carrying classes in the first place!
This commit is contained in:
Reinier Zwitserloot committed 2018-03-20 01:17:35 +01:00
1 parent ae611e1687
commit c08559b016
6 files changed
+121 -31

No files matched your search

@@ -0,0 +1,32 @@
public class EqualsAndHashCodeWithGenericsOnInners<A> {
@lombok.EqualsAndHashCode class Inner<B> {
int x;
Inner() {
super();
}
public @java.lang.Override @java.lang.SuppressWarnings("all") boolean equals(final java.lang.Object o) {
if ((o == this))
return true;
if ((! (o instanceof EqualsAndHashCodeWithGenericsOnInners.Inner)))
return false;
final EqualsAndHashCodeWithGenericsOnInners<?>.Inner<?> other = (EqualsAndHashCodeWithGenericsOnInners<?>.Inner<?>) o;
if ((! other.canEqual((java.lang.Object) this)))
return false;
if ((this.x != other.x))
return false;
return true;
}
protected @java.lang.SuppressWarnings("all") boolean canEqual(final java.lang.Object other) {
return (other instanceof EqualsAndHashCodeWithGenericsOnInners.Inner);
}
public @java.lang.Override @java.lang.SuppressWarnings("all") int hashCode() {
final int PRIME = 59;
int result = 1;
result = ((result * PRIME) + this.x);
return result;
}
}
public EqualsAndHashCodeWithGenericsOnInners() {
super();
}
}