16 Commits
Author SHA1 Message Date
Reinier Zwitserloot 0c5f878a4c [tests] This seemingly humongous commit is actually nothing: All test-cases now have @Generated annotations where before they did not. 2024-05-17 03:04:40 +02:00
Reinier Zwitserloot db19327cb4 [fixes #1628] Lombok now marks the result field used in the generated hashCode method as final if it isn’t modified. This doesn’t change its behavior whatsoever, but some linters and especially eclipse save actions (specifically: ‘mark local variables final if possible’) cause issues when they try to mess with generated code. Of course, now any save action with ‘remove useless modifiers’ would cause an issue but those don’t (yet…) exist. 2018-11-08 15:51:08 +01:00
Reinier Zwitserloot 9aac454aec fixing tests to account for generation of javax.annotation.Generated and ConstructorProperties being default-off. 2017-12-04 21:41:47 +01:00
Roel Spilker 045638ec1f Generate correct hashCode when callSuper and no fields included. Fixes #1505 2017-11-06 23:46:09 +01:00
Roel Spilker 70f77f928a [i1014] Only add lombok.Generated if it is explicitly turned on 2017-02-09 22:52:38 +01:00
Roel Spilker 9e4292dae4 add @lombok.Generated to generated classes, methods and fields 2017-01-06 01:05:16 +01:00
Reinier Zwitserloot 251fd03cd7 The hashCode() method now generates a magic prime instead of 0 for the hash of null values; this reduces collisions. 2015-06-25 00:13:12 +02:00
Reinier Zwitserloot a7bd812893 [i623] added eclipse code for generating @javax.annotation.Generated, and refactored java impl to reduce DRY violations. -f pretty now includes skipping generation of this annotation, and updated ALL the test cases. 2015-01-30 15:43:41 +01:00
Roel Spilker 4d24542dac [i660] canEqual is now protected instead of public.
Also fixed the total lack of canEqual in the usage examples.
2014-03-26 21:11:30 +01:00
Roel Spilker 14cc545276 Issue 625: use (even) better primes for hashcodes 2014-01-19 21:49:35 +01:00
Reinier Zwitserloot a40a86ad53 [#625] Instead of '31' as a prime number for hashCode(), use something else. 31, probably owing to its inclusion in Effective Java, is overused, as proven by Maaartinus in issue 625. Switching to 277 instead. Also, 1231/1237 pair used for booleans has been replaced by 2591/2609. 2014-01-09 21:24:04 +01:00
Reinier Zwitserloot b1877a77be fixed tests since Robbert Jan's fix for issue 377. 2012-07-16 22:24:04 +02:00
Roel Spilker 25def866b5 Issue 366: don't call the getter twice, fixed for Eclipse. 2012-04-29 23:57:48 +02:00
Roel Spilker 5a13db5dc9 Issue 366: don't call the getter twice, fixed for javac. 2012-04-29 23:57:47 +02:00
Roel Spilker 2fcfc4c3dc Fixed unit tests to take into account work on issue 289 and 287. 2011-11-01 00:53:21 +01:00
Roel Spilker 83e2fb5e00 Now either all or none of equals/hashCode/canEqual is generated. Fixes issue 240. 2011-07-18 21:05:00 +02:00