mirror of
https://github.com/tiennm99/noitu.git
synced 2026-10-11 03:13:45 +00:00
fix(proto): pin schema and generated code to LF checkouts
A Windows checkout with core.autocrlf enabled handed buf a CRLF schema, so an empty comment line reached the codegen plugin as a carriage return rather than an empty string. The plugin pads non-empty lines with a space, and the committed output kept a trailing space that an LF checkout never emits, breaking the generated-code sync check.
This commit is contained in:
1 parent
67e7405252
commit
7ec53bd52c
2 files changed
+10
-1
No files matched your search
@@ -7,3 +7,12 @@ proto/testdata/*.bin binary
|
|||||||
# it out of diffs makes reviews readable and stops it inflating language stats.
|
# it out of diffs makes reviews readable and stops it inflating language stats.
|
||||||
server/gen/** linguist-generated=true
|
server/gen/** linguist-generated=true
|
||||||
web/src/lib/proto/** linguist-generated=true
|
web/src/lib/proto/** linguist-generated=true
|
||||||
|
|
||||||
|
# core.autocrlf on Windows would otherwise check these out with CRLF. buf keeps
|
||||||
|
# the CR inside comment text, so an empty `//` line reaches the codegen plugin
|
||||||
|
# as "\r" instead of "", and the plugin pads non-empty lines with a space. The
|
||||||
|
# committed output then carries a trailing space that a LF checkout never
|
||||||
|
# produces, and the generated-code sync check fails on Linux.
|
||||||
|
*.proto text eol=lf
|
||||||
|
server/gen/** text eol=lf
|
||||||
|
web/src/lib/proto/** text eol=lf
|
||||||
+1
-1
@@ -137,7 +137,7 @@ export declare const ResignSchema: GenMessage<Resign>;
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* RequestRematch asks to play again in the same room after a game ends.
|
* RequestRematch asks to play again in the same room after a game ends.
|
||||||
*
|
*
|
||||||
* There is no matching decline: leaving the room is the decline, and the
|
* There is no matching decline: leaving the room is the decline, and the
|
||||||
* server already learns about that from the socket closing. One message and
|
* server already learns about that from the socket closing. One message and
|
||||||
* one timeout cover every way a rematch does not happen.
|
* one timeout cover every way a rematch does not happen.
|
||||||
|
|||||||
Reference in new issue
Block a user