From 058803a60169a33edda34c0079de967f2617efde Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Thu, 13 Nov 2025 13:25:52 +0100 Subject: [PATCH] Remove obsolete parameter include_body --- src/serena/symbol.py | 3 +-- src/serena/tools/symbol_tools.py | 1 - src/solidlsp/language_servers/al_language_server.py | 2 +- src/solidlsp/ls.py | 6 +----- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/serena/symbol.py b/src/serena/symbol.py index f3dc2270..e3753041 100644 --- a/src/serena/symbol.py +++ b/src/serena/symbol.py @@ -491,7 +491,6 @@ class LanguageServerSymbolRetriever: def find_by_name( self, name_path: str, - include_body: bool = False, include_kinds: Sequence[SymbolKind] | None = None, exclude_kinds: Sequence[SymbolKind] | None = None, substring_matching: bool = False, @@ -504,7 +503,7 @@ class LanguageServerSymbolRetriever: """ symbols: list[LanguageServerSymbol] = [] for lang_server in self._ls_manager.iter_language_servers(): - symbol_roots = lang_server.request_full_symbol_tree(within_relative_path=within_relative_path, include_body=include_body) + symbol_roots = lang_server.request_full_symbol_tree(within_relative_path=within_relative_path) for root in symbol_roots: symbols.extend( LanguageServerSymbol(root).find( diff --git a/src/serena/tools/symbol_tools.py b/src/serena/tools/symbol_tools.py index bd31fc48..01c0dfaa 100644 --- a/src/serena/tools/symbol_tools.py +++ b/src/serena/tools/symbol_tools.py @@ -150,7 +150,6 @@ class FindSymbolTool(Tool, ToolMarkerSymbolicRead): symbol_retriever = self.create_language_server_symbol_retriever() symbols = symbol_retriever.find_by_name( name_path, - include_body=include_body, include_kinds=parsed_include_kinds, exclude_kinds=parsed_exclude_kinds, substring_matching=substring_matching, diff --git a/src/solidlsp/language_servers/al_language_server.py b/src/solidlsp/language_servers/al_language_server.py index be83fc5a..2bc1b1ad 100644 --- a/src/solidlsp/language_servers/al_language_server.py +++ b/src/solidlsp/language_servers/al_language_server.py @@ -680,7 +680,7 @@ class ALLanguageServer(SolidLanguageServer): return super().is_ignored_dirname(dirname) or dirname in al_ignore_dirs @override - def request_full_symbol_tree(self, within_relative_path: str | None = None, include_body: bool = False) -> list[dict]: + def request_full_symbol_tree(self, within_relative_path: str | None = None) -> list[dict]: """ Override to handle AL's requirement of opening files before requesting symbols. diff --git a/src/solidlsp/ls.py b/src/solidlsp/ls.py index c64c05bd..ce91fb45 100644 --- a/src/solidlsp/ls.py +++ b/src/solidlsp/ls.py @@ -1081,9 +1081,7 @@ class SolidLanguageServer(ABC): return document_symbols - def request_full_symbol_tree( - self, within_relative_path: str | None = None, include_body: bool = False - ) -> list[ls_types.UnifiedSymbolInformation]: + def request_full_symbol_tree(self, within_relative_path: str | None = None) -> list[ls_types.UnifiedSymbolInformation]: """ Will go through all files in the project or within a relative path and build a tree of symbols. Note: this may be slow the first time it is called, especially if `within_relative_path` is not used to restrict the search. @@ -1098,8 +1096,6 @@ class SolidLanguageServer(ABC): :param within_relative_path: pass a relative path to only consider symbols within this path. If a file is passed, only the symbols within this file will be considered. If a directory is passed, all files within this directory will be considered. - :param include_body: whether to include the body of the symbols in the result. - :return: A list of root symbols representing the top-level packages/modules in the project. """ if within_relative_path is not None: