From 25139d1d74435b86ddd1c8ee6104e9be59d55049 Mon Sep 17 00:00:00 2001 From: MischaPanch Date: Thu, 24 Jul 2025 19:02:33 +0200 Subject: [PATCH] Improved performance of find_all_non_ignored_files by not descending into ignored dirs --- src/serena/util/file_system.py | 6 ++++-- src/serena/util/inspection.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/serena/util/file_system.py b/src/serena/util/file_system.py index e4195aec..0999aef1 100644 --- a/src/serena/util/file_system.py +++ b/src/serena/util/file_system.py @@ -76,8 +76,10 @@ def find_all_non_ignored_files(repo_root: str) -> list[str]: :return: A list of all non-ignored files in the repository """ gitignore_parser = GitignoreParser(repo_root) - _, files = scan_directory(repo_root, recursive=True) - return [file for file in files if not gitignore_parser.should_ignore(file)] + _, files = scan_directory( + repo_root, recursive=True, is_ignored_dir=gitignore_parser.should_ignore, is_ignored_file=gitignore_parser.should_ignore + ) + return files @dataclass diff --git a/src/serena/util/inspection.py b/src/serena/util/inspection.py index 4a859c1f..668cf545 100644 --- a/src/serena/util/inspection.py +++ b/src/serena/util/inspection.py @@ -19,7 +19,7 @@ def iter_subclasses(cls: type[T], recursive: bool = True) -> Generator[type[T], yield from iter_subclasses(subclass, recursive) -def determine_programming_language_composition(repo_path: str, rel_path_to_gitignore: str = ".gitignore") -> dict[str, float]: +def determine_programming_language_composition(repo_path: str) -> dict[str, float]: """ Determine the programming language composition of a repository.