From 4b86e7b5e5818f80d28c6819325f8c821aba5dfe Mon Sep 17 00:00:00 2001 From: Yen <5915590+antigenius0910@users.noreply.github.com> Date: Wed, 4 Mar 2026 07:12:32 -0600 Subject: [PATCH] Enable Rego tests on Windows now that Regal fixed upstream path handling (#1114) - Bump Regal from v0.36.1 to v0.39.0 which includes Windows path fixes (upstream fix: https://github.com/StyraInc/regal/issues/1683) - Remove sys.platform == "win32" skipif from TestRegoLanguageServer Co-authored-by: Claude Sonnet 4.6 --- .github/workflows/pytest.yml | 2 +- test/solidlsp/rego/test_rego_basic.py | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml index 51577d5c..7377ca4e 100644 --- a/.github/workflows/pytest.yml +++ b/.github/workflows/pytest.yml @@ -397,7 +397,7 @@ jobs: - name: Install Regal (Rego Language Server) shell: bash run: | - REGAL_VERSION="0.36.1" + REGAL_VERSION="0.39.0" if [[ "${{ runner.os }}" == "Linux" ]]; then if [[ "$(uname -m)" == "x86_64" ]]; then diff --git a/test/solidlsp/rego/test_rego_basic.py b/test/solidlsp/rego/test_rego_basic.py index e4185e85..4da3efcd 100644 --- a/test/solidlsp/rego/test_rego_basic.py +++ b/test/solidlsp/rego/test_rego_basic.py @@ -1,7 +1,6 @@ """Tests for Rego language server (Regal) functionality.""" import os -import sys import pytest @@ -11,9 +10,6 @@ from solidlsp.ls_utils import SymbolUtils @pytest.mark.rego -@pytest.mark.skipif( - sys.platform == "win32", reason="Regal LSP has Windows path handling bug - see https://github.com/StyraInc/regal/issues/1683" -) class TestRegoLanguageServer: """Test Regal language server functionality for Rego."""