From 5d7aeb680f6c814a697a981d1b442e3970b55278 Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Thu, 16 Oct 2025 22:35:31 +0200 Subject: [PATCH] Intelephense: Account for spaces in launch command (use robust list syntax instead of string) --- src/solidlsp/language_servers/intelephense.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/solidlsp/language_servers/intelephense.py b/src/solidlsp/language_servers/intelephense.py index b9e86619..3f4f6e0b 100644 --- a/src/solidlsp/language_servers/intelephense.py +++ b/src/solidlsp/language_servers/intelephense.py @@ -39,9 +39,7 @@ class Intelephense(SolidLanguageServer): return super().is_ignored_dirname(dirname) or dirname in ["node_modules", "vendor", "cache"] @classmethod - def _setup_runtime_dependencies( - cls, logger: LanguageServerLogger, config: LanguageServerConfig, solidlsp_settings: SolidLSPSettings - ) -> str: + def _setup_runtime_dependencies(cls, logger: LanguageServerLogger, solidlsp_settings: SolidLSPSettings) -> list[str]: """ Setup runtime dependencies for Intelephense and return the command to start the server. """ @@ -84,13 +82,13 @@ class Intelephense(SolidLanguageServer): intelephense_executable_path ), f"intelephense executable not found at {intelephense_executable_path}, something went wrong." - return f"{intelephense_executable_path} --stdio" + return [intelephense_executable_path, "--stdio"] def __init__( self, config: LanguageServerConfig, logger: LanguageServerLogger, repository_root_path: str, solidlsp_settings: SolidLSPSettings ): # Setup runtime dependencies before initializing - intelephense_cmd = self._setup_runtime_dependencies(logger, config, solidlsp_settings) + intelephense_cmd = self._setup_runtime_dependencies(logger, solidlsp_settings) super().__init__( config,