From 6a8a1810ed6750c92838abf95381f2e2b1d78790 Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Thu, 10 Jul 2025 23:16:34 +0200 Subject: [PATCH] Rename variables: symbol_manager -> symbol_retriever --- src/serena/code_editor.py | 10 +++++----- test/serena/test_symbol_editing.py | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/serena/code_editor.py b/src/serena/code_editor.py index 34096dc7..f2492b04 100644 --- a/src/serena/code_editor.py +++ b/src/serena/code_editor.py @@ -212,13 +212,13 @@ class CodeEditor(Generic[TSymbol], ABC): class LanguageServerCodeEditor(CodeEditor[LanguageServerSymbol]): - def __init__(self, symbol_manager: LanguageServerSymbolRetriever, agent: Optional["SerenaAgent"] = None): - super().__init__(project_root=symbol_manager.get_language_server().repository_root_path, agent=agent) - self._symbol_manager = symbol_manager + def __init__(self, symbol_retriever: LanguageServerSymbolRetriever, agent: Optional["SerenaAgent"] = None): + super().__init__(project_root=symbol_retriever.get_language_server().repository_root_path, agent=agent) + self._symbol_retriever = symbol_retriever @property def _lang_server(self) -> SolidLanguageServer: - return self._symbol_manager.get_language_server() + return self._symbol_retriever.get_language_server() class EditedFile(CodeEditor.EditedFile): def __init__(self, lang_server: SolidLanguageServer, relative_path: str, file_buffer: LSPFileBuffer): @@ -245,7 +245,7 @@ class LanguageServerCodeEditor(CodeEditor[LanguageServerSymbol]): return self._lang_server.language_server.retrieve_full_file_content(relative_path) def _find_unique_symbol(self, name_path: str, relative_file_path: str) -> LanguageServerSymbol: - symbol_candidates = self._symbol_manager.find_by_name(name_path, within_relative_path=relative_file_path) + symbol_candidates = self._symbol_retriever.find_by_name(name_path, within_relative_path=relative_file_path) if len(symbol_candidates) == 0: raise ValueError(f"No symbol with name {name_path} found in file {relative_file_path}") if len(symbol_candidates) > 1: diff --git a/test/serena/test_symbol_editing.py b/test/serena/test_symbol_editing.py index 5fa44011..1f5cea0c 100644 --- a/test/serena/test_symbol_editing.py +++ b/test/serena/test_symbol_editing.py @@ -221,9 +221,9 @@ class EditingTest: return f.read() def run_test(self, content_after_ground_truth: str) -> None: - with self._setup() as symbol_manager: + with self._setup() as symbol_retriever: content_before = self._read_file(self.rel_path) - code_editor = LanguageServerCodeEditor(symbol_manager) + code_editor = LanguageServerCodeEditor(symbol_retriever) self._apply_edit(code_editor) content_after = self._read_file(self.rel_path) code_diff = CodeDiff(self.rel_path, original_content=content_before, modified_content=content_after)