tiennm99/serena
1
0 Fork 0
mirror of https://github.com/tiennm99/serena.git synced 2026-10-14 12:17:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark flaky tests with xfail instead of skip

Browse Source
This commit is contained in:
Dominik Jain authored and Dominik Jain committed 2026-02-24 20:20:27 +01:00
1 parent 8e6aad0f73
commit 7ce1d0e564
5 files changed
+10 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/solidlsp/swift/test_swift_basic.py
+3 -3
View File
@@ -100,7 +100,7 @@ class TestSwiftLanguageServerBasics:
utils_def = definitions[0]
assert utils_def.get("uri", "").endswith("utils.swift"), "Definition should be in utils.swift"
@pytest.mark.skipif(is_ci, reason="Test is flaky in CI")
@pytest.mark.xfail(is_ci, reason="Test is flaky in CI") # See #1040
@pytest.mark.parametrize("language_server", [Language.SWIFT], indirect=True)
def test_request_references_calculator_class(self, language_server: SolidLanguageServer) -> None:
"""Test request_references on the Calculator class."""
@@ -123,7 +123,7 @@ class TestSwiftLanguageServerBasics:
line_5_refs = [ref for ref in calculator_refs if ref.get("range", {}).get("start", {}).get("line") == 4]
assert len(line_5_refs) > 0, "Calculator should be referenced at line 5"
@pytest.mark.skipif(is_ci, reason="Test is flaky in CI")
@pytest.mark.xfail(is_ci, reason="Test is flaky in CI") # See #1040
@pytest.mark.parametrize("language_server", [Language.SWIFT], indirect=True)
def test_request_references_user_struct(self, language_server: SolidLanguageServer) -> None:
"""Test request_references on the User struct."""
@@ -145,7 +145,7 @@ class TestSwiftLanguageServerBasics:
line_9_refs = [ref for ref in user_refs if ref.get("range", {}).get("start", {}).get("line") == 8]
assert len(line_9_refs) > 0, "User should be referenced at line 9"
@pytest.mark.skipif(is_ci, reason="Test is flaky in CI")
@pytest.mark.xfail(is_ci, reason="Test is flaky in CI") # See #1040
@pytest.mark.parametrize("language_server", [Language.SWIFT], indirect=True)
def test_request_references_utils_struct(self, language_server: SolidLanguageServer) -> None:
"""Test request_references on the Utils struct."""