From 83f5f3bdf442ee7bc9a9fbc58639677b35925bb7 Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Mon, 15 Dec 2025 13:58:12 +0100 Subject: [PATCH] Fix config key for gui_log_window --- src/serena/agent.py | 3 +++ src/serena/config/serena_config.py | 10 ++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/serena/agent.py b/src/serena/agent.py index 394c14bb..e596dd1c 100644 --- a/src/serena/agent.py +++ b/src/serena/agent.py @@ -195,6 +195,7 @@ class SerenaAgent: # open GUI log window if enabled self._gui_log_viewer: Optional["GuiLogViewer"] = None if self.serena_config.gui_log_window_enabled: + log.info("Opening GUI window") if platform.system() == "Darwin": log.warning("GUI log window is not supported on macOS") else: @@ -204,6 +205,8 @@ class SerenaAgent: self._gui_log_viewer = GuiLogViewer("dashboard", title="Serena Logs", memory_log_handler=get_memory_log_handler()) self._gui_log_viewer.start() + else: + log.debug("GUI window is disabled") # set the agent context if context is None: diff --git a/src/serena/config/serena_config.py b/src/serena/config/serena_config.py index 75f916b8..06e1c6d1 100644 --- a/src/serena/config/serena_config.py +++ b/src/serena/config/serena_config.py @@ -464,11 +464,13 @@ class SerenaConfig(ToolInclusionDefinition, ToStringMixin): ) instance.projects.append(project) - # set other configuration parameters - def get_value_or_default(field_name: str) -> Any: - return loaded_commented_yaml.get(field_name, get_dataclass_default(SerenaConfig, field_name)) + def get_value_or_default(key: str, field_name: str | None = None) -> Any: + if field_name is None: + field_name = key + return loaded_commented_yaml.get(key, get_dataclass_default(SerenaConfig, field_name)) - instance.gui_log_window_enabled = get_value_or_default("gui_log_window_enabled") + # set other configuration parameters + instance.gui_log_window_enabled = get_value_or_default("gui_log_window", "gui_log_window_enabled") instance.web_dashboard_listen_address = get_value_or_default("web_dashboard_listen_address") instance.log_level = loaded_commented_yaml.get("log_level", loaded_commented_yaml.get("gui_log_level", logging.INFO)) instance.web_dashboard = get_value_or_default("web_dashboard")