From 98966c6a598bb96a63a6defda310b4d8c3b92616 Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Mon, 13 Jul 2026 22:39:03 +0200 Subject: [PATCH] Remove incorrect DTOs for JetBrains /runInspectionsOnFile call --- src/serena/jetbrains/jetbrains_plugin_client.py | 7 +++++-- src/serena/jetbrains/jetbrains_types.py | 16 ---------------- 2 files changed, 5 insertions(+), 18 deletions(-) diff --git a/src/serena/jetbrains/jetbrains_plugin_client.py b/src/serena/jetbrains/jetbrains_plugin_client.py index 090adbdf..eec3393c 100644 --- a/src/serena/jetbrains/jetbrains_plugin_client.py +++ b/src/serena/jetbrains/jetbrains_plugin_client.py @@ -686,7 +686,7 @@ class JetBrainsPluginClient(ToStringMixin): inspection_names: list[str] | None = None, start_line: int | None = None, end_line: int | None = None, - ) -> jb.RunInspectionsResponse: + ) -> dict: """ Runs IDE inspections on the given file and returns the results. @@ -695,6 +695,9 @@ class JetBrainsPluginClient(ToStringMixin): :param inspection_names: optional list of specific inspection names to run :param start_line: optional start line to restrict the inspection range :param end_line: optional end line to restrict the inspection range + :return: the inspection results as a dictionary. + NOTE: The response is currently *not* a well-defined DTO, because it stores variable data in keys. + Consequently, the `pythonify` option is disabled for this request, and the response is returned as-is. """ request_data: dict[str, Any] = { "relativePath": relative_path, @@ -707,7 +710,7 @@ class JetBrainsPluginClient(ToStringMixin): request_data["startLine"] = start_line if end_line is not None: request_data["endLine"] = end_line - return cast(jb.RunInspectionsResponse, self._make_request("POST", "/runInspectionsOnFile", request_data, pythonify=False)) + return self._make_request("POST", "/runInspectionsOnFile", request_data, pythonify=False) def list_inspections( self, diff --git a/src/serena/jetbrains/jetbrains_types.py b/src/serena/jetbrains/jetbrains_types.py index ce488ea2..65add4fb 100644 --- a/src/serena/jetbrains/jetbrains_types.py +++ b/src/serena/jetbrains/jetbrains_types.py @@ -91,22 +91,6 @@ class TypeHierarchyResponse(TypedDict): num_levels_not_included: NotRequired[int] -class InspectionResultDTO(TypedDict): - inspection_name: str - severity: str - message: str - relative_path: str - start_line: int - end_line: int - start_col: NotRequired[int] - end_col: NotRequired[int] - quick_fix_available: NotRequired[bool] - - -class RunInspectionsResponse(TypedDict): - inspections: list[InspectionResultDTO] - - class InspectionInfoDTO(TypedDict): name: str group_path: str